Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fallback to default trace endpoint for link exporter. #444

Merged
merged 3 commits into from
Jan 16, 2025
Merged

fix: Fallback to default trace endpoint for link exporter. #444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d8a2c72
Configure localVisualizations for sample app.
wolfgangcodes Jan 16, 2025
dd52de0
If not specifed fall back to traceEndpoint
wolfgangcodes Jan 16, 2025
ef6b4f5
Add test for when endpoint is ommitted
wolfgangcodes Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/honeycomb-opentelemetry-web/examples/hello-world-web/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ const main = () => {
dataAttributes: ['hello', 'barBiz'],
},
},
localVisualizations: true,
});
sdk.start();
const tracer = trace.getTracer('click-tracer');
Expand Down
5 changes: 4 additions & 1 deletion packages/honeycomb-opentelemetry-web/src/console-trace-link-exporter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import { HoneycombOptions } from './types';
import {
createHoneycombSDKLogMessage,
getTracesApiKey,
getTracesEndpoint,
isClassic,
} from './util';
import {
Expand All @@ -24,7 +25,9 @@ export function configureConsoleTraceLinkExporter(
options?: HoneycombOptions,
): SpanExporter {
const apiKey = getTracesApiKey(options);
const { authRoot, uiRoot } = getUrlRoots(options?.endpoint);
const { authRoot, uiRoot } = getUrlRoots(
options?.tracesEndpoint || getTracesEndpoint(options),
);
return new ConsoleTraceLinkExporter(
options?.serviceName,
apiKey,
Expand Down
29 changes: 29 additions & 0 deletions packages/honeycomb-opentelemetry-web/test/honeycomb-debug.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,5 +69,34 @@ describe('when debug is set to true', () => {
`@honeycombio/opentelemetry-web: Sample Rate configured for traces: '${testConfig.sampleRate}'`,
);
});
it('should log the configured options to the console when endpoint is omitted', () => {
const testConfig = {
debug: true,
apiKey: 'my-key',
serviceName: 'my-service',
sampleRate: 2,
};
new HoneycombWebSDK(testConfig);
expect(consoleSpy).toHaveBeenNthCalledWith(
3,
'@honeycombio/opentelemetry-web: 🐝 Honeycomb Web SDK Debug Mode Enabled 🐝',
);
expect(consoleSpy).toHaveBeenNthCalledWith(
4,
`@honeycombio/opentelemetry-web: API Key configured for traces: '${testConfig.apiKey}'`,
);
expect(consoleSpy).toHaveBeenNthCalledWith(
5,
`@honeycombio/opentelemetry-web: Service Name configured for traces: '${testConfig.serviceName}'`,
);
expect(consoleSpy).toHaveBeenNthCalledWith(
6,
`@honeycombio/opentelemetry-web: Endpoint configured for traces: 'https://api.honeycomb.io/v1/traces'`,
);
expect(consoleSpy).toHaveBeenNthCalledWith(
7,
`@honeycombio/opentelemetry-web: Sample Rate configured for traces: '${testConfig.sampleRate}'`,
);
});
});
});
Loading