Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fallback to default trace endpoint for link exporter. #444

Merged
merged 3 commits into from
Jan 16, 2025
Merged

fix: Fallback to default trace endpoint for link exporter. #444

merged 3 commits into from
Jan 16, 2025

Conversation

wolfgangcodes
Copy link
Contributor

@wolfgangcodes wolfgangcodes commented Jan 16, 2025 •
edited
Loading

Which problem is this PR solving?

Short description of the changes

Fall back to computed traces endpoint if not supplied.

How to verify that this has the expected result

Configure the sample app (without) providing an end point and run:

npm run example:start:hello-world-web

You should see the SDK start successfully and links to traces in the console.

@wolfgangcodes wolfgangcodes force-pushed the wg/debug-exporter-endpoint branch from ef36505 to 1ac0c42 Compare January 16, 2025 17:47
@wolfgangcodes wolfgangcodes changed the title Fix: Apply defaults configuration options in constructor. fix: Apply defaults configuration options in constructor. Jan 16, 2025
@wolfgangcodes wolfgangcodes force-pushed the wg/debug-exporter-endpoint branch 2 times, most recently from d8b9f42 to 2579b67 Compare January 16, 2025 18:16
@wolfgangcodes wolfgangcodes force-pushed the wg/debug-exporter-endpoint branch from 2579b67 to dd52de0 Compare January 16, 2025 18:39
@wolfgangcodes wolfgangcodes marked this pull request as ready for review January 16, 2025 19:08
@wolfgangcodes wolfgangcodes requested a review from a team as a code owner January 16, 2025 19:08
pkanal
pkanal reviewed Jan 16, 2025
View reviewed changes
Copy link
Contributor

@pkanal pkanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test to show that this fixes the underlying bug?

@wolfgangcodes
Copy link
Contributor Author

Can we add a test to show that this fixes the underlying bug?

@pkanal ef6b4f5 😸

pkanal
pkanal approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@pkanal pkanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so fast! 🚢

@wolfgangcodes wolfgangcodes changed the title fix: Apply defaults configuration options in constructor. fix: Fall back to default trace endpoint for link exporter. Jan 16, 2025
@wolfgangcodes wolfgangcodes changed the title fix: Fall back to default trace endpoint for link exporter. fix: Fallback to default trace endpoint for link exporter. Jan 16, 2025
@wolfgangcodes wolfgangcodes merged commit 496bd33 into main Jan 16, 2025
15 checks passed
@wolfgangcodes wolfgangcodes deleted the wg/debug-exporter-endpoint branch January 16, 2025 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkanal pkanal pkanal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError: Failed to construct 'URL': Invalid URL
2 participants
@wolfgangcodes @pkanal