Repository navigation
docs(resolver): clarify that a bare dash is literal - #306
Conversation
Remove the unsupported stdin array source claim and keep the compiled resolver in sync. Runtime behavior is unchanged. Hive-Run: hivecommons#305 Hive-Plan: issue-305-option-A Hive-Spec: issue-305#option-A Signed-off-by: mendezr <mendezr@users.noreply.github.com>
Hive-Run: hivecommons#305 Hive-Plan: issue-305-option-A Hive-Spec: issue-305#option-A Signed-off-by: mendezr <mendezr@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Another agent tried to open a PR from |
|
hive/awaiting-ci: CI pending — sweep will merge when green. 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
There was a problem hiding this comment.
Looks correct to me — comment-only change, and the new wording matches the tree.
Checked at 70db3d2:
src/cli.tshas no-/stdin value handling anywhere (the onlystdinreference is the TTY check atsrc/cli.ts:102), so the old// - (stdin) handled at CLI level before thiswas describing code that does not exist.src/resolver.test.ts:188-190already pins--pa_f=-resolving to the literal string-, which is exactly what the new comment atsrc/resolver.ts:55-56says.dist/resolver.{js,d.ts,js.map}are regenerated and theverify PR contentsdist-sync check is green.
This is option A from #305, which the issue itself proposed, so no open decision here. No runtime change.
— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
There was a problem hiding this comment.
Looks correct to me — comment-only change, matches option A as decided in #305.
Verified against the tree at 70db3d2:
src/cli.tshas no code path that reads stdin for a-argument (onlyprocess.stdin.isTTYatcli.ts:102and the interactiveask()readline inresolver.ts:185), so the old "handled at CLI level" comment was indeed wrong.src/resolver.test.ts:188-191already pins--pa_f=-as the literal string-, which is what the new comment atsrc/resolver.ts:55now says.dist/resolver.{js,d.ts,js.map}are regenerated, so the dist-sync CI gate passes.
Optional, not blocking: the test title at src/resolver.test.ts:188 still reads keeps "-" (stdin placeholder) as a single literal — dropping "(stdin placeholder)" would make it consistent with the new wording.
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Hive filed review findings that do not block this PR as backlog items:
Cap: 10 backlog item(s) per PR per day. |
11b31f6
into
hivecommons:main
|
Merged by hive contributor-lane auto-merge: CI green for ≥30m, reviewer verdict approve, @mendezr holds the trusted tier in this hive's contributor registry. |
Summary
-as a literal value and regenerate compiled artifacts.Fixes #305
Validation
npm run lintnpm run buildnpm test(426 passing, coverage thresholds passed)git diff --check— hive: backend=pi model=openai-codex/gpt-6.1-sol
🐝 Hive Agent:
contributor| SHA:70db3d2