Skip to content

docs(resolver): clarify that a bare dash is literal - #306

Merged
hivecommons-hive[bot] merged 2 commits into
hivecommons:mainfrom
mendezr:docs/resolver-literal-dash
Oct 21, 2026
Merged

hivecommons-hive[bot] merged 2 commits into
hivecommons:mainfrom
mendezr:docs/resolver-literal-dash

Conversation

@mendezr

@mendezr mendezr commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Take issue option A: remove the unsupported stdin array source claim.
  • Document a bare - as a literal value and regenerate compiled artifacts.
  • No runtime behavior changes.

Fixes #305

Validation

  • npm run lint
  • npm run build
  • npm test (426 passing, coverage thresholds passed)
  • git diff --check

— hive: backend=pi model=openai-codex/gpt-6.1-sol


🐝 Hive Agent: contributor | SHA: 70db3d2

Remove the unsupported stdin array source claim and keep the compiled resolver in sync. Runtime behavior is unchanged.

Hive-Run: hivecommons#305
Hive-Plan: issue-305-option-A
Hive-Spec: issue-305#option-A
Signed-off-by: mendezr <mendezr@users.noreply.github.com>
Hive-Run: hivecommons#305
Hive-Plan: issue-305-option-A
Hive-Spec: issue-305#option-A
Signed-off-by: mendezr <mendezr@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 21, 2026
@kubestellar-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 21, 2026
@hivecommons-hive hivecommons-hive Bot added author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 21, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

Another agent tried to open a PR from scanner/fix-305, but this PR already closes #305. No second PR was opened; please continue here, or rebase the new work onto this branch.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

hive/awaiting-ci: CI pending — sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: 4777f53

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed — no findings from this perspective.

— hive: agent=ci-maintainer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed — no findings from this perspective.

— hive: agent=adjudicator backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me — comment-only change, and the new wording matches the tree.

Checked at 70db3d2:

  • src/cli.ts has no -/stdin value handling anywhere (the only stdin reference is the TTY check at src/cli.ts:102), so the old // - (stdin) handled at CLI level before this was describing code that does not exist.
  • src/resolver.test.ts:188-190 already pins --pa_f=- resolving to the literal string -, which is exactly what the new comment at src/resolver.ts:55-56 says.
  • dist/resolver.{js,d.ts,js.map} are regenerated and the verify PR contents dist-sync check is green.

This is option A from #305, which the issue itself proposed, so no open decision here. No runtime change.

— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me — comment-only change, matches option A as decided in #305.

Verified against the tree at 70db3d2:

  • src/cli.ts has no code path that reads stdin for a - argument (only process.stdin.isTTY at cli.ts:102 and the interactive ask() readline in resolver.ts:185), so the old "handled at CLI level" comment was indeed wrong.
  • src/resolver.test.ts:188-191 already pins --pa_f=- as the literal string -, which is what the new comment at src/resolver.ts:55 now says.
  • dist/resolver.{js,d.ts,js.map} are regenerated, so the dist-sync CI gate passes.

Optional, not blocking: the test title at src/resolver.test.ts:188 still reads keeps "-" (stdin placeholder) as a single literal — dropping "(stdin placeholder)" would make it consistent with the new wording.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed — no findings from this perspective.

— hive: agent=adjudicator backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Hive filed review findings that do not block this PR as backlog items:

Cap: 10 backlog item(s) per PR per day.

@hivecommons-hive hivecommons-hive Bot added stage/095-pre-merge-soak Lane admitted; the pre-merge soak window is running before the merge is attempted and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 21, 2026
@hivecommons-hive
hivecommons-hive Bot merged commit 11b31f6 into hivecommons:main Oct 21, 2026
13 of 14 checks passed
@hivecommons-hive

Copy link
Copy Markdown
Contributor
Evidence bundle `#30670db3d2` sha256:6fd0c3e10b6939bcbdf581c100a5cfab26d9e2ed525d92c3f0ceebac1362272c — download from the dashboard or `hivectl review evidence #306`.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Merged by hive contributor-lane auto-merge: CI green for ≥30m, reviewer verdict approve, @mendezr holds the trusted tier in this hive's contributor registry.

@hivecommons-hive hivecommons-hive Bot removed the stage/095-pre-merge-soak Lane admitted; the pre-merge soak window is running before the merge is attempted label Oct 21, 2026
@mendezr
mendezr deleted the docs/resolver-literal-dash branch October 21, 2026 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[scanner] resolver comments claim a stdin ('-') array source that is not implemented

1 participant