Add formula macro support#58
Open
rsenne wants to merge 3 commits into
Open
Conversation
Introduces support for StatsModels.jl @formula macro and FormulaTerm parsing for generalized additive models (GAMs). Adds SmoothTerm type and s() constructor for smooth spline terms, updates FitGAM and GAMFormula to handle FormulaTerm input, and extends tests for formula macro usage and smooth term parsing. Project.toml updated to include StatsModels dependency.
Contributor
|
Codecov looks like a helpful tool, is there a free version? |
Contributor
Author
|
Yes! Codecov is completely free for open source projects. I think @hendersontrent will have to set it up as the repository owner? |
Merged
Contributor
Author
|
merge conflicts should be solved! |
Owner
|
@rsenne Two just got created due to some changes following last merge. I can resolve otherwise feel free to yourself. I should be able to review this PR soon! |
Contributor
Author
|
i think that should do it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR to resolve #46.
I think some deep review on this would be good. I also think once this PR #55 and #57 are merged--an overhaul of test suite would be good. I feel a critical mass is being hit that adding code coverage through CodeCov would be helpful to track and missing tests etc. What do you think?