Add linear terms#55
Merged
Merged
Conversation
This was referenced Nov 23, 2025
Contributor
Author
|
just a quick ping on this :) |
Contributor
Author
|
gentle ping on this again |
Owner
This was referenced May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should partially fulfill the requirements of #41. Right now I don't have it set up for categorical predictors. But should now have access to non-spline terms. This depends on my previous PR #51 so that should get merged first. Also, think better logic for handling the different distributions will be necessary. Let me know if additional tests are desired. I think it would be good at some point to add more tests comparing to other packages as well.