Moving the byFilterDeletion form gridstudy to commons-ui #3809
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -6,44 +6,33 @@ | |||||
| */ | ||||||
|
|
||||||
| import { yupResolver } from '@hookform/resolvers/yup'; | ||||||
| import { | ||||||
| ByFilterDeletionDto, | ||||||
| ByFilterDeletionForm, | ||||||
| ByFilterDeletionFormData, | ||||||
| byFilterDeletionDtoToForm, | ||||||
| byFilterDeletionFormSchema, | ||||||
| FieldConstants, | ||||||
| CustomFormProvider, | ||||||
| snackWithFallback, | ||||||
| useSnackMessage, | ||||||
| } from '@gridsuite/commons-ui'; | ||||||
| import { useForm } from 'react-hook-form'; | ||||||
| import { FunctionComponent, useCallback, useEffect } from 'react'; | ||||||
| import { ModificationDialog } from '../../../commons/modificationDialog'; | ||||||
| import { useOpenShortWaitFetching } from 'components/dialogs/commons/handle-modification-form'; | ||||||
| import { FORM_LOADING_DELAY } from 'components/network/constants'; | ||||||
| import { deleteEquipmentByFilter } from '../../../../../services/study/network-modifications'; | ||||||
| import { FetchStatus } from '../../../../../services/utils'; | ||||||
| import { NetworkModificationDialogProps } from '../../../../graph/menus/network-modifications/network-modification-menu.type'; | ||||||
|
|
||||||
| const emptyFormData: ByFilterDeletionFormData = { | ||||||
| [FieldConstants.TYPE]: null, | ||||||
| [FieldConstants.FILTERS]: [], | ||||||
| }; | ||||||
|
|
||||||
| type ByFilterDeletionDialogProps = NetworkModificationDialogProps & { | ||||||
| editData: ByFilterDeletionDto; | ||||||
|
Contributor
There was a problem hiding this comment.
Suggested change
editData is optional (cf creation mode). and you can add uuid here (if you remove it from the DTO). |
||||||
| }; | ||||||
|
|
||||||
| /** | ||||||
|
|
@@ -69,17 +58,14 @@ | |||||
|
|
||||||
| const formMethods = useForm<ByFilterDeletionFormData>({ | ||||||
|
Contributor
There was a problem hiding this comment.
Suggested change
|
||||||
| defaultValues: emptyFormData, | ||||||
| resolver: yupResolver<ByFilterDeletionFormData>(byFilterDeletionFormSchema), | ||||||
|
Contributor
There was a problem hiding this comment.
Suggested change
|
||||||
| }); | ||||||
|
|
||||||
| const { reset } = formMethods; | ||||||
|
|
||||||
| const fromEditDataToFormValues = useCallback( | ||||||
| (data: ByFilterDeletionDto) => { | ||||||
| reset(byFilterDeletionDtoToForm(data)); | ||||||
| }, | ||||||
| [reset] | ||||||
| ); | ||||||
|
|
@@ -95,8 +81,8 @@ | |||||
| deleteEquipmentByFilter( | ||||||
| studyUuid, | ||||||
| currentNodeUuid, | ||||||
| formData[FieldConstants.TYPE], | ||||||
| formData[FieldConstants.FILTERS], | ||||||
| editData?.uuid | ||||||
|
Comment on lines
81
to
86
Contributor
There was a problem hiding this comment. we should use: const dto = byFilterDeletionFormToDto(form); ex: #3815 |
||||||
| ).catch((error) => { | ||||||
| snackWithFallback(snackError, error, { headerId: 'UnableToDeleteEquipment' }); | ||||||
|
|
@@ -116,7 +102,7 @@ | |||||
| }); | ||||||
|
|
||||||
| return ( | ||||||
| <CustomFormProvider validationSchema={byFilterDeletionFormSchema} {...formMethods}> | ||||||
| <ModificationDialog | ||||||
| fullWidth | ||||||
| maxWidth={'md'} | ||||||
|
|
||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And we put it in commons-ui too