Moving the byFilterDeletion form gridstudy to commons-ui#3809
Open
benrejebmoh wants to merge 2 commits intomainfrom
Open
Moving the byFilterDeletion form gridstudy to commons-ui#3809benrejebmoh wants to merge 2 commits intomainfrom
benrejebmoh wants to merge 2 commits intomainfrom
Conversation
Signed-off-by: benrejebmoh <mohamed.ben-rejeb@rte-france.com>
dbraquart
requested changes
Mar 17, 2026
Contributor
dbraquart
left a comment
dbraquart
left a comment
There was a problem hiding this comment.
code: little change requests
tests: sounds good
Comment on lines
81
to
86
| deleteEquipmentByFilter( | ||
| studyUuid, | ||
| currentNodeUuid, | ||
| formData[TYPE], | ||
| formData[FILTERS], | ||
| formData[FieldConstants.TYPE], | ||
| formData[FieldConstants.FILTERS], | ||
| editData?.uuid |
Contributor
There was a problem hiding this comment.
we should use:
const dto = byFilterDeletionFormToDto(form);
deleteEquipmentByFilter(studyUuid, currentNodeUuid, editData?.uuid, dto)
ex: #3815
| [TYPE]: null, | ||
| [FILTERS]: [], | ||
| type ByFilterDeletionDialogProps = NetworkModificationDialogProps & { | ||
| editData: ByFilterDeletionDto; |
Contributor
There was a problem hiding this comment.
Suggested change
| editData: ByFilterDeletionDto; | |
| editData?: ByFilterDeletionDto & { uuid: UUID }; |
editData is optional (cf creation mode). and you can add uuid here (if you remove it from the DTO).
| .min(1, 'FieldIsRequired'), | ||
| }) | ||
| .required(); | ||
| const emptyFormData: ByFilterDeletionFormData = { |
Contributor
There was a problem hiding this comment.
Suggested change
| const emptyFormData: ByFilterDeletionFormData = { | |
| const emptyFormData: DeepNullable<ByFilterDeletionFormData> = { |
And we put it in commons-ui too
| @@ -69,17 +58,14 @@ const ByFilterDeletionDialog: FunctionComponent<ByFilterDeletionDialogProps> = ( | |||
|
|
|||
| const formMethods = useForm<ByFilterDeletionFormData>({ | |||
Contributor
There was a problem hiding this comment.
Suggested change
| const formMethods = useForm<ByFilterDeletionFormData>({ | |
| const formMethods = useForm<DeepNullable<ByFilterDeletionFormData>>({ |
| const formMethods = useForm<ByFilterDeletionFormData>({ | ||
| defaultValues: emptyFormData, | ||
| resolver: yupResolver<ByFilterDeletionFormData>(formSchema), | ||
| resolver: yupResolver<ByFilterDeletionFormData>(byFilterDeletionFormSchema), |
Contributor
There was a problem hiding this comment.
Suggested change
| resolver: yupResolver<ByFilterDeletionFormData>(byFilterDeletionFormSchema), | |
| resolver: yupResolver<DeepNullable<ByFilterDeletionFormData>>(byFilterDeletionFormSchema), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Extracting byFilterDeletion to commons-ui for common usage with other front apps