Konradjanica.heightfitting

[KonradJanica]

#19

Adds an option to allow text downsizing to fit height.

See methods:

• setHeightFitting()
• isHeightFitting()

See members:

• isHeightFitting
• heightToFit

Works in project https://github.com/KonradJanica/aMatch

Notes:

• I did it very quickly and AutofitLayout isn't tested but only one line was added.
• mIsHeightFitting is a static member due to autofit() being a static method

P.S. sorry about the entire file change, I think my IDE changed something... I suggest maybe leaving it as a new branch until thoroughly tested.

[grantland]

This would be an awesome feature to add, however, it is very difficult to review as the entire files are shown as changed. Any chance you can update this with correct diffs?

[KonradJanica]

I'll take a look, no guarantees because I'm a bit stretched for time this month. Without thinking I automatically changed tab indenting to 4 space indenting via the android studio prompt.
:-(

[brcolow]

Question 1:

This line:

int targetHeight = view.getHeight() - view.getPaddingTop() - view.getPaddingTop();

Should it not be:

int targetHeight = view.getHeight() - view.getPaddingTop() - view.getPaddingBottom();

Question 2:

These two lines:

float textHeight = getTextHeight(text, paint, targetWidth, size);
textHeight = getTextHeight(text, paint, targetWidth, size);

the second line seems redundant, is it not?

[shahimclt]

Hey @grantland. can you merge this please? My specific case needs this badly.
Thanks.