Added height fitting option (by KonradJanica)

[Will5]

Took KonradJanica's code (#43) and reformatted for easier review by grantland.

[grantland]

nit: revert

[grantland]

This is much cleaner!

The new API method names seem a bit odd to me. Instead of #isHeightFitting(), #setHeightFitting(boolean), etc. do you think #isAutofitWidthEnabled(), setAutofitHeightEnabled(boolean) sounds more natural? Additionally, this would allow us to eventually deprecate #isEnabled(), #getEnabled(boolean) and add #isAutofitWidthEnabled() and #setAutofitWidthEnabled(boolean).

[Will5]

The proposed naming convention of #isAutofitHeightEnabled() and #setAutofitHeightEnabled(boolean), along with #isAutofitWidthEnabled() and #setAutofitWidthEnabled(boolean) sound much cleaner to me!

[Will5]

I pushed a commit with the API refactoring. Let me know if it sounds clearer.

[AllanHasegawa]

Why AutofitHelper::mIsAutofitHeightEnabled is a static variable?

If I use two different AutofitTextView in my app, one with AutofitHeight enabled, and a second with AutofitHeight disabled, then the first will get AutofitHeight disabled too. Is this the expected behaviour?

[Will5]

I believe the field is static so that it can be accessed via the private static void autofit(TextView view, TextPaint paint, float minTextSize, float maxTextSize, int maxLines, float precision) method. I'm not sure that the method needs to be static though. @grantland?

[AllanHasegawa]

I think you could leave the method autofit(...) static, but then pass mIsAutofitHeightEnabled as a parameter to it. This way, each AutofitTextView can have its own mIsAutofitHeightEnabled setting instead of sharing a global one.

[Will5]

Good point! I pushed the appropriate change

[AllanHasegawa]

Awesome, looks good ^^

Thank you for your commits.

Just a small nitpick. The variable named mIsAutofitHeightEnabled is using "Hungarian Notation" to denote it is a "member variable". See Google's code style: link.

When you use it inside a static function (like the autofit(...)), I think the proper naming convention would be to remove the "m" before the variable name, as it is no longer a "member variable".

[Will5]

Thank you @AranHase!

[ejohansson]

Any updates on this. Have been checking in on this pull request for a while now?

[johnnylambada]

I made a quick fork of this with @Will5 's changes because I need to use it in my project. It's available from jitpack.io here: https://github.com/flipagram/android-autofittextview -- When this is all merged in I'll remove my fork.

[slvrfn]

why has this still not been merged?

[AndreasBoehm]

Please merge this PR, we do need this fix for our project as well. Thanks!