Skip to content

Fixed visitStringValueNode for string blocks #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fixed visitStringValueNode for string blocks #454

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
797bf9a
Fixed visitStringValueNode for string blocks
sh1l0n Apr 3, 2024
ddf3610
format string even with is not a block
sh1l0n Apr 3, 2024
ae3d44c
Align with https://spec.graphql.org/June2018/#sec-String-Value
sh1l0n Apr 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions gql/lib/src/language/printer.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,10 +172,20 @@ class _PrintVisitor extends Visitor<String> {

@override
String visitStringValueNode(StringValueNode stringValueNode) {
final formattedString = stringValueNode.value
.replaceAll('"""', '\\"""')
.replaceAll('\"', '\\"')
.replaceAll('\/', '\\/')
.replaceAll('\\', '\\\\')
.replaceAll('\b', '\\b')
.replaceAll('\f', '\\f')
.replaceAll('\n', '\\n')
.replaceAll('\r', '\\r')
.replaceAll('\t', '\\t');
if (!stringValueNode.isBlock) {
return [
'"',
stringValueNode.value,
formattedString,
'"',
].join();
}
Expand All @@ -184,7 +194,7 @@ class _PrintVisitor extends Visitor<String> {
'"""',
"\n",
_indent(_tabs),
stringValueNode.value.replaceAll('"""', '\\"""'),
formattedString,
"\n",
_indent(_tabs),
'"""',
Expand Down