Skip to content

Fixed visitStringValueNode for string blocks #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fixed visitStringValueNode for string blocks #454

wants to merge 3 commits into from

Conversation

sh1l0n
Copy link

@sh1l0n sh1l0n commented Apr 3, 2024 •
edited
Loading

Fix: #453

Before

"Lore ipsum
One
Two"

After:

"Lore ipsum\nOne\nTwo"

@sh1l0n sh1l0n mentioned this pull request Apr 4, 2024
Open
@knaeckeKami
Copy link
Collaborator

knaeckeKami commented Apr 8, 2024 •
edited
Loading

Please fix the linting errors

Also, please add tests that call printNode(parseString("....") on blocks, non-blocks mit multiline strings.
I think the escape logic is now wrong, since you escape block strings which should not be escaped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Printer fails with string blocks
2 participants
@sh1l0n @knaeckeKami