Skip to content

[TEST] Reservation 관련 서비스 테스트 #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Friox merged 6 commits into from
Aug 7, 2025
Merged

[TEST] Reservation 관련 서비스 테스트 #229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
944ca18
test: ReservationService 테스트 코드 작성 (#210)
Friox Aug 6, 2025
8e8a979
test: SeatReservationService 테스트 코드 작성 (#210)
Friox Aug 6, 2025
0ecd569
test: TicketService 테스트 코드 작성 (#210)
Friox Aug 6, 2025
ebbdf09
refactor: SeatReservationService 테스트 코드 메서드명 수정 (#210)
Friox Aug 6, 2025
4ee5e35
refactor: TicketService 테스트 코드 메서드명 수정 (#210)
Friox Aug 6, 2025
fa83dd9
docs: 만료된 예약 조회 관련 테스트 DisplayName 변경 (#210)
Friox Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
264 changes: 250 additions & 14 deletions src/test/java/com/sudo/railo/booking/application/ReservationServiceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,27 +2,35 @@

import static org.assertj.core.api.Assertions.*;

import java.time.LocalDate;
import java.time.LocalDateTime;
import java.time.LocalTime;
import java.util.List;

import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.DisplayName;
import org.junit.jupiter.api.Test;
import org.springframework.beans.factory.annotation.Autowired;

import com.sudo.railo.booking.application.dto.request.ReservationCreateRequest;
import com.sudo.railo.booking.application.dto.request.ReservationDeleteRequest;
import com.sudo.railo.booking.application.dto.response.ReservationDetail;
import com.sudo.railo.booking.domain.Reservation;
import com.sudo.railo.booking.domain.status.ReservationStatus;
import com.sudo.railo.booking.domain.type.PassengerSummary;
import com.sudo.railo.booking.domain.type.PassengerType;
import com.sudo.railo.booking.domain.type.TripType;
import com.sudo.railo.booking.exception.BookingError;
import com.sudo.railo.booking.infrastructure.reservation.ReservationRepository;
import com.sudo.railo.global.exception.error.BusinessException;
import com.sudo.railo.member.domain.Member;
import com.sudo.railo.member.infrastructure.MemberRepository;
import com.sudo.railo.support.annotation.ServiceTest;
import com.sudo.railo.support.fixture.MemberFixture;
import com.sudo.railo.support.helper.ReservationTestHelper;
import com.sudo.railo.support.helper.TrainScheduleTestHelper;
import com.sudo.railo.support.helper.TrainScheduleTestHelper.TrainScheduleWithStopStations;
import com.sudo.railo.support.helper.TrainTestHelper;
import com.sudo.railo.train.domain.ScheduleStop;
import com.sudo.railo.train.domain.Train;
import com.sudo.railo.train.domain.type.CarType;

Expand All @@ -44,26 +52,34 @@ class ReservationServiceTest {
@Autowired
private TrainScheduleTestHelper trainScheduleTestHelper;

@Autowired
private ReservationTestHelper reservationTestHelper;

@Autowired
private ReservationRepository reservationRepository;

@Test
@DisplayName("유효한 요청으로 예약이 성공한다")
void createReservation_success() {
//given
Train train = trainTestHelper.createKTX();
TrainScheduleWithStopStations scheduleWithStops = trainScheduleTestHelper.createSchedule(train);
private Member member;
private Train train;
private TrainScheduleWithStopStations schedule;
private List<Long> standardSeatIds;

@BeforeEach
void setup() {
Member member = MemberFixture.createStandardMember();
memberRepository.save(member);
this.member = memberRepository.save(member);
train = trainTestHelper.createKTX();
schedule = trainScheduleTestHelper.createSchedule(train);
standardSeatIds = trainTestHelper.getSeatIds(train, CarType.STANDARD, 2);
}

List<Long> standardSeatIds = trainTestHelper.getSeatIds(train, CarType.STANDARD, 2);
ScheduleStop departureStop = trainScheduleTestHelper.getScheduleStopByStationName(scheduleWithStops, "서울");
ScheduleStop arrivalStop = trainScheduleTestHelper.getScheduleStopByStationName(scheduleWithStops, "부산");
@Test
@DisplayName("유효한 요청으로 예약이 성공한다")
void validRequest_createReservation_success() {
// given
ReservationCreateRequest request = new ReservationCreateRequest(
scheduleWithStops.trainSchedule().getId(),
departureStop.getStation().getId(),
arrivalStop.getStation().getId(),
schedule.trainSchedule().getId(),
schedule.scheduleStops().get(0).getId(),
schedule.scheduleStops().get(1).getId(),
List.of(new PassengerSummary(PassengerType.ADULT, 1), new PassengerSummary(PassengerType.CHILD, 1)),
standardSeatIds,
TripType.OW
Expand All @@ -82,4 +98,224 @@ void createReservation_success() {
assertThat(savedReservation.getFare()).isEqualTo(80000);
assertThat(savedReservation.getReservationCode()).isNotNull();
}

@Test
@DisplayName("멤버번호와 예약 ID로 특정 예약 조회에 성공한다")
void memberNoAndReservationId_getReservation_success() {
// given
String memberNo = member.getMemberDetail().getMemberNo();

Train train = trainTestHelper.createKTX();
TrainScheduleWithStopStations schedule = trainScheduleTestHelper.createSchedule(train);
Reservation reservation = reservationTestHelper.createReservation(member, schedule);
Reservation entity = reservationRepository.save(reservation);

// when
ReservationDetail result = reservationService.getReservation(memberNo, entity.getId());

// then
assertThat(result.reservationId()).isEqualTo(entity.getId());
assertThat(result.reservationCode()).isEqualTo(reservation.getReservationCode());
assertThat(result.departureStationName()).isEqualTo(
schedule.scheduleStops().get(0).getStation().getStationName());
assertThat(result.arrivalStationName()).isEqualTo(
schedule.scheduleStops().get(1).getStation().getStationName());
}

@Test
@DisplayName("올바른 멤버번호와 잘못된 예약 ID로 특정 예약 조회 시 예외를 반환한다")
void memberNoAndInvalidReservationId_getReservation_throwException() {
// given
String memberNo = member.getMemberDetail().getMemberNo();

Train train = trainTestHelper.createKTX();
TrainScheduleWithStopStations schedule = trainScheduleTestHelper.createSchedule(train);
Reservation reservation = reservationTestHelper.createReservation(member, schedule);
Reservation entity = reservationRepository.save(reservation);

// when & then
assertThatThrownBy(() -> reservationService.getReservation(memberNo, 2L))
.isInstanceOf(BusinessException.class);

reservationRepository.save(reservation);
}

@Test
@DisplayName("올바른 멤버번호와 만료된 예약 ID로 특정 예약 조회 시 예외를 반환한다")
void memberNoAndExpiredReservationId_getReservation_throwException() {
// given
String memberNo = member.getMemberDetail().getMemberNo();
Reservation reservation = Reservation.builder()
.trainSchedule(schedule.trainSchedule())
.member(member)
.reservationCode("20250806100001D49J")
.tripType(TripType.OW)
.totalPassengers(1)
.passengerSummary("[{\"passengerType\":\"ADULT\",\"count\":1}]")
.reservationStatus(ReservationStatus.RESERVED)
.expiresAt(LocalDateTime.now().minusMinutes(10))
.fare(50000)
.departureStop(schedule.scheduleStops().get(0))
.arrivalStop(schedule.scheduleStops().get(1))
.build();
Reservation entity = reservationRepository.save(reservation);

// when & then
assertThatThrownBy(() -> reservationService.getReservation(memberNo, entity.getId()))
.isInstanceOf(BusinessException.class)
.hasMessage(BookingError.RESERVATION_EXPIRED.getMessage());
}

@Test
@DisplayName("멤버번호로 관련한 예약 목록 조회에 성공한다")
void memberNo_getReservations_success() {
// given
String memberNo = member.getMemberDetail().getMemberNo();

Train train = trainTestHelper.createKTX();
TrainScheduleWithStopStations scheduleBusanToDongDaegu = trainScheduleTestHelper.createCustomSchedule()
.scheduleName("커스텀 노선 - 부산에서 동대구")
.operationDate(LocalDate.now())
.train(train)
.addStop("부산", null, LocalTime.of(5, 0))
.addStop("동대구", LocalTime.of(8, 0), null)
.build();

TrainScheduleWithStopStations scheduleDaejeonToSeoul = trainScheduleTestHelper.createCustomSchedule()
.scheduleName("커스텀 노선 - 대전에서 서울")
.operationDate(LocalDate.now())
.train(train)
.addStop("대전", null, LocalTime.of(10, 0))
.addStop("서울", LocalTime.of(12, 0), null)
.build();

Reservation reservation1 = reservationTestHelper.createReservation(member, scheduleBusanToDongDaegu);
Reservation reservation2 = reservationTestHelper.createReservation(member, scheduleDaejeonToSeoul);
Reservation entity1 = reservationRepository.save(reservation1);
Reservation entity2 = reservationRepository.save(reservation2);

// when
List<ReservationDetail> result = reservationService.getReservations(memberNo);

// then
assertThat(result.size()).isEqualTo(2);
ReservationDetail result1 = result.get(0);
ReservationDetail result2 = result.get(1);

assertThat(result1.reservationId()).isEqualTo(entity1.getId());
assertThat(result1.reservationCode()).isEqualTo(reservation1.getReservationCode());
assertThat(result1.departureStationName()).isEqualTo(
scheduleBusanToDongDaegu.scheduleStops().get(0).getStation().getStationName());
assertThat(result1.arrivalStationName()).isEqualTo(
scheduleBusanToDongDaegu.scheduleStops().get(1).getStation().getStationName());

assertThat(result2.reservationId()).isEqualTo(entity2.getId());
assertThat(result2.reservationCode()).isEqualTo(reservation2.getReservationCode());
assertThat(result2.departureStationName()).isEqualTo(
scheduleDaejeonToSeoul.scheduleStops().get(0).getStation().getStationName());
assertThat(result2.arrivalStationName()).isEqualTo(
scheduleDaejeonToSeoul.scheduleStops().get(1).getStation().getStationName());
}

@Test
@DisplayName("멤버번호로 예약 목록 조회 시 만료된 예약을 제외하고 조회에 성공한다")
void memberNoAndExpiredReservation_getReservations_success() {
// given
String memberNo = member.getMemberDetail().getMemberNo();

Train train = trainTestHelper.createKTX();
TrainScheduleWithStopStations scheduleBusanToDongDaegu = trainScheduleTestHelper.createCustomSchedule()
.scheduleName("커스텀 노선 - 부산에서 동대구")
.operationDate(LocalDate.now())
.train(train)
.addStop("부산", null, LocalTime.of(5, 0))
.addStop("동대구", LocalTime.of(8, 0), null)
.build();

TrainScheduleWithStopStations scheduleDaejeonToSeoul = trainScheduleTestHelper.createCustomSchedule()
.scheduleName("커스텀 노선 - 대전에서 서울")
.operationDate(LocalDate.now())
.train(train)
.addStop("대전", null, LocalTime.of(10, 0))
.addStop("서울", LocalTime.of(12, 0), null)
.build();

Reservation reservation1 = Reservation.builder()
.trainSchedule(scheduleBusanToDongDaegu.trainSchedule())
.member(member)
.reservationCode("20250806100001D49J")
.tripType(TripType.OW)
.totalPassengers(1)
.passengerSummary("[{\"passengerType\":\"ADULT\",\"count\":1}]")
.reservationStatus(ReservationStatus.RESERVED)
.expiresAt(LocalDateTime.now().minusMinutes(10))
.fare(50000)
.departureStop(scheduleBusanToDongDaegu.scheduleStops().get(0))
.arrivalStop(scheduleBusanToDongDaegu.scheduleStops().get(1))
.build();
Reservation reservation2 = reservationTestHelper.createReservation(member, scheduleDaejeonToSeoul);
Reservation entity1 = reservationRepository.save(reservation1);
Reservation entity2 = reservationRepository.save(reservation2);

// when
List<ReservationDetail> result = reservationService.getReservations(memberNo);

// then
assertThat(result.size()).isEqualTo(1);
ReservationDetail result1 = result.get(0);

assertThat(result1.reservationId()).isEqualTo(entity2.getId());
assertThat(result1.reservationCode()).isEqualTo(reservation2.getReservationCode());
assertThat(result1.departureStationName()).isEqualTo(
scheduleDaejeonToSeoul.scheduleStops().get(0).getStation().getStationName());
assertThat(result1.arrivalStationName()).isEqualTo(
scheduleDaejeonToSeoul.scheduleStops().get(1).getStation().getStationName());
}

@Test
@DisplayName("올바른 예약 삭제 요청 DTO로 예약 삭제에 성공한다")
void validRequestDto_deleteReservation_success() {
// given
Train train = trainTestHelper.createKTX();
TrainScheduleWithStopStations schedule = trainScheduleTestHelper.createSchedule(train);
Reservation reservation = reservationTestHelper.createReservation(member, schedule);
Reservation entity = reservationRepository.save(reservation);
ReservationDeleteRequest request = new ReservationDeleteRequest(entity.getId());

// when
reservationService.deleteReservation(request);

// then
List<Reservation> result = reservationRepository.findAll();
assertThat(result.size()).isEqualTo(0);
}

@Test
@DisplayName("만료된 예약 일괄삭제에 성공한다")
void expireReservations_success() {
// given
Reservation reservation = Reservation.builder()
.trainSchedule(schedule.trainSchedule())
.member(member)
.reservationCode("20250806100001D49J")
.tripType(TripType.OW)
.totalPassengers(1)
.passengerSummary("[{\"passengerType\":\"ADULT\",\"count\":1}]")
.reservationStatus(ReservationStatus.RESERVED)
.expiresAt(LocalDateTime.now().minusMinutes(10))
.fare(50000)
.departureStop(schedule.scheduleStops().get(0))
.arrivalStop(schedule.scheduleStops().get(1))
.build();
for (int i = 0; i < 3; i++) {
reservationRepository.save(reservation);
}

// when
reservationService.expireReservations();

// then
List<Reservation> result = reservationRepository.findAll();
assertThat(result.size()).isEqualTo(0);
}
}
Loading
Loading