[TEST] Reservation 관련 서비스 테스트 #229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Friox
requested review from
EndlessMilkyway,
Jimin730,
Ogu1208,
Yunsung-Jo and
chanwonlee
chanwonlee
approved these changes
Aug 6, 2025
Contributor
chanwonlee
left a comment
chanwonlee
left a comment
There was a problem hiding this comment.
pr에 자세하게 테스트 목록을 작성해 주셔서 코드 확인하기 수월했습니다! 고생하셨습니다!
src/test/java/com/sudo/railo/booking/application/ReservationServiceTest.java
Show resolved
Hide resolved
EndlessMilkyway
approved these changes
Aug 7, 2025
Contributor
EndlessMilkyway
left a comment
EndlessMilkyway
left a comment
There was a problem hiding this comment.
도메인이 복잡해서 테스트를 작성하기 힘드셨을텐데도 불구하고 잘 해주신 것 같습니다. 고생하셨습니다! 👍
Ogu1208
approved these changes
Aug 7, 2025
Contributor
Ogu1208
left a comment
Ogu1208
left a comment
There was a problem hiding this comment.
저도 열차 조회 테스트 코드 작성하면서 예약쪽 데이터 생성에 머리가 아팠는데 이쪽도 만만치 않군요.. ㅠㅠ
고생하셨습니다!! 👍👍
src/test/java/com/sudo/railo/booking/application/ReservationServiceTest.java
Outdated
Show resolved
Hide resolved
Friox
force-pushed
the
test/210-reservation
branch
from
3613456 to
fa83dd9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 Issue (필수)
주요 변경 사항 (필수)
ReservationService테스트 코드 작성SeatReservationService테스트 코드 작성TicketService테스트 코드 작성리뷰어 참고 사항
Warning
위 PR을 반영하여 작업한 브랜치 입니다.
GitHub 상 코드리뷰가 편하도록 작업한 커밋만 분리했습니다.
이 PR 단독으로 테스트가 불가능하며, 별도로 반영해 주셔야 테스트 가능합니다.
모두 머지 또는 해결된 후 리베이스하겠습니다!
booking.application.dto.response의TicketReadResponse에서,Long seatReservationId를 주석처리해주셔야TicketService테스트를 정상적으로 진행할 수 있습니다.작성한 테스트 코드는 다음과 같습니다.
ReservationServiceSeatReservationServiceTicketService추가 정보
없음
PR 작성 체크리스트 (필수)