Skip to content

feat: remove python 3.8 support #1215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/sync-repo-settings.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ branchProtectionRules:
- 'OwlBot Post Processor'
- 'Kokoro'
- 'Samples - Lint'
- 'Samples - Python 3.8'
- 'Samples - Python 3.9'
- 'Samples - Python 3.10'
- 'Samples - Python 3.11'
Expand Down
40 changes: 0 additions & 40 deletions .kokoro/samples/python3.8/common.cfg

This file was deleted.

6 changes: 0 additions & 6 deletions .kokoro/samples/python3.8/continuous.cfg

This file was deleted.

11 changes: 0 additions & 11 deletions .kokoro/samples/python3.8/periodic-head.cfg

This file was deleted.

6 changes: 0 additions & 6 deletions .kokoro/samples/python3.8/periodic.cfg

This file was deleted.

6 changes: 0 additions & 6 deletions .kokoro/samples/python3.8/presubmit.cfg

This file was deleted.

12 changes: 5 additions & 7 deletions CONTRIBUTING.rst
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ In order to add a feature:
documentation.

- The feature must work fully on the following CPython versions:
3.8, 3.9, 3.10, 3.11, 3.12, and 3.13 on both UNIX and Windows.
3.9, 3.10, 3.11, 3.12, and 3.13 on both UNIX and Windows.

- The feature must not add unnecessary dependencies (where
"unnecessary" is of course subjective, but new dependencies should
Expand Down Expand Up @@ -148,7 +148,7 @@ Running System Tests

.. note::

System tests are only configured to run under Python 3.8, 3.12, and 3.13.
System tests are only configured to run under Python 3.12, and 3.13.
For expediency, we do not run them in older versions of Python 3.

This alone will not run the tests. You'll need to change some local
Expand Down Expand Up @@ -195,11 +195,11 @@ configure them just like the System Tests.

# Run all tests in a folder
$ cd samples/snippets
$ nox -s py-3.8
$ nox -s py-3.9

# Run a single sample test
$ cd samples/snippets
$ nox -s py-3.8 -- -k <name of test>
$ nox -s py-3.9 -- -k <name of test>

********************************************
Note About ``README`` as it pertains to PyPI
Expand All @@ -221,14 +221,12 @@ Supported Python Versions

We support:

- `Python 3.8`_
- `Python 3.9`_
- `Python 3.10`_
- `Python 3.11`_
- `Python 3.12`_
- `Python 3.13`_

.. _Python 3.8: https://docs.python.org/3.8/
.. _Python 3.9: https://docs.python.org/3.9/
.. _Python 3.10: https://docs.python.org/3.10/
.. _Python 3.11: https://docs.python.org/3.11/
Expand All @@ -241,7 +239,7 @@ Supported versions can be found in our ``noxfile.py`` `config`_.
.. _config: https://github.com/googleapis/python-bigquery-sqlalchemy/blob/main/noxfile.py


We also explicitly decided to support Python 3 beginning with version 3.8.
We also explicitly decided to support Python 3 beginning with version 3.9.
Reasons for this include:

- Encouraging use of newest versions of Python 3
Expand Down
2 changes: 1 addition & 1 deletion README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ dependencies.

Supported Python Versions
^^^^^^^^^^^^^^^^^^^^^^^^^
Python >= 3.8, <3.14
Python >= 3.9, <3.14

Unsupported Python Versions
^^^^^^^^^^^^^^^^^^^^^^^^^^^
Expand Down
20 changes: 4 additions & 16 deletions noxfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,9 @@
"setup.py",
]

DEFAULT_PYTHON_VERSION = "3.8"
DEFAULT_PYTHON_VERSION = "3.9"

UNIT_TEST_PYTHON_VERSIONS: List[str] = ["3.8", "3.9", "3.10", "3.11", "3.12", "3.13"]
UNIT_TEST_PYTHON_VERSIONS: List[str] = ["3.9", "3.10", "3.11", "3.12", "3.13"]
UNIT_TEST_STANDARD_DEPENDENCIES = [
"mock",
"asyncmock",
Expand All @@ -56,11 +56,6 @@
"tests",
]
UNIT_TEST_EXTRAS_BY_PYTHON: Dict[str, List[str]] = {
"3.8": [
"tests",
"alembic",
"bqstorage",
],
"3.11": [
"tests",
"geography",
Expand All @@ -78,7 +73,7 @@
],
}

SYSTEM_TEST_PYTHON_VERSIONS: List[str] = ["3.8", "3.12", "3.13"]
SYSTEM_TEST_PYTHON_VERSIONS: List[str] = ["3.12", "3.13"]
SYSTEM_TEST_STANDARD_DEPENDENCIES: List[str] = [
"mock",
"pytest",
Expand All @@ -91,11 +86,6 @@
"tests",
]
SYSTEM_TEST_EXTRAS_BY_PYTHON: Dict[str, List[str]] = {
"3.8": [
"tests",
"alembic",
"bqstorage",
],
"3.12": [
"tests",
"geography",
Expand Down Expand Up @@ -398,9 +388,7 @@ def compliance(session):
"-c",
constraints_path,
)
if session.python == "3.8":
extras = "[tests,alembic]"
elif session.python in ["3.12", "3.13"]:
if session.python in ["3.12", "3.13"]:
extras = "[tests,geography]"
else:
extras = "[tests]"
Expand Down
5 changes: 2 additions & 3 deletions owlbot.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,14 +30,13 @@
# ----------------------------------------------------------------------------
extras = ["tests"]
extras_by_python = {
"3.8": ["tests", "alembic", "bqstorage"],
"3.11": ["tests", "geography", "bqstorage"],
"3.12": ["tests", "geography", "bqstorage"],
"3.13": ["tests", "geography", "bqstorage"],
}
templated_files = common.py_library(
unit_test_python_versions=["3.8", "3.9", "3.10", "3.11", "3.12", "3.13"],
system_test_python_versions=["3.8", "3.12", "3.13"],
unit_test_python_versions=["3.9", "3.10", "3.11", "3.12", "3.13"],
system_test_python_versions=["3.12", "3.13"],
cov_level=100,
unit_test_extras=extras,
unit_test_extras_by_python=extras_by_python,
Expand Down
2 changes: 1 addition & 1 deletion samples/snippets/noxfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ def get_pytest_env_vars() -> Dict[str, str]:

# DO NOT EDIT - automatically generated.
# All versions used to test samples.
ALL_VERSIONS = ["3.7", "3.8", "3.9", "3.10", "3.11", "3.12", "3.13"]
ALL_VERSIONS = ["3.7", "3.9", "3.10", "3.11", "3.12", "3.13"]

# Any default versions that should be ignored.
IGNORED_VERSIONS = TEST_CONFIG["ignored_versions"]
Expand Down
3 changes: 0 additions & 3 deletions samples/snippets/requirements-test.txt
Original file line number Diff line number Diff line change
Expand Up @@ -5,16 +5,13 @@ google-auth==2.40.3
google-cloud-testutils==1.6.4
iniconfig==2.1.0
packaging==25.0
pluggy===1.5.0; python_version == '3.8'
pluggy==1.6.0; python_version >= '3.9'
py==1.11.0
pyasn1==0.6.1
pyasn1-modules==0.4.2
pyparsing===3.1.4; python_version == '3.8'
pyparsing==3.2.3; python_version >= '3.9'
pytest===6.2.5
rsa==4.9.1
six==1.17.0
toml==0.10.2
typing-extensions===4.13.0; python_version == '3.8'
typing-extensions==4.14.1; python_version >= '3.9'
13 changes: 0 additions & 13 deletions samples/snippets/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,37 +1,26 @@
alembic===1.14.0; python_version == '3.8'
alembic==1.16.4; python_version >= '3.9'
certifi==2025.7.14
charset-normalizer==3.4.2
geoalchemy2==0.17.1
google-api-core[grpc]==2.25.1
google-auth==2.40.3
google-cloud-bigquery===3.30.0; python_version == '3.8'
google-cloud-bigquery==3.35.0; python_version >= '3.9'
google-cloud-core==2.4.3
google-crc32c===1.5.0; python_version == '3.8'
google-crc32c==1.7.1; python_version >= '3.9'
google-resumable-media==2.7.2
googleapis-common-protos==1.70.0
greenlet===3.1.1; python_version == '3.8'
greenlet==3.2.3; python_version >= '3.9'
grpcio===1.68.0; python_version == '3.8'
grpcio==1.73.1; python_version >= '3.9'
grpcio-status===1.68.0; python_version == '3.8'
grpcio-status==1.73.1; python_version >= '3.9'
idna==3.10
importlib-resources===6.4.5; python_version == '3.8'
importlib-resources==6.5.2; python_version >= '3.9'
mako===1.3.5; python_version == '3.8'
mako==1.3.10; python_version >= '3.9'
markupsafe===2.1.5; python_version == '3.8'
markupsafe==3.0.2; python_version >= '3.9'
packaging==25.0
proto-plus==1.26.1
protobuf===5.28.3; python_version == '3.8'
protobuf==6.31.1; python_version >= '3.9'
pyasn1==0.6.1
pyasn1-modules==0.4.2
pyparsing===3.1.4; python_version == '3.8'
pyparsing==3.2.3; python_version >= '3.9'
python-dateutil==2.9.0.post0
pytz==2025.2
Expand All @@ -41,7 +30,5 @@ shapely===2.0.7; python_version <= '3.9'
shapely==2.1.1; python_version >= '3.10'
six==1.17.0
sqlalchemy===1.4.27
typing-extensions===4.13.0; python_version == '3.8'
typing-extensions==4.14.1; python_version >= '3.9'
urllib3===2.2.3; python_version == '3.8'
urllib3==2.5.0; python_version >= '3.9'
13 changes: 0 additions & 13 deletions testing/constraints-3.8.txt

This file was deleted.