feat: remove python 3.8 support #1215
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
chalmerlowe
added
the
kokoro:run
yoshi-kokoro
removed
the
kokoro:run
chalmerlowe
added
the
automerge
Linchin
reviewed
Jul 23, 2025
| @@ -56,11 +58,6 @@ | |||
| "tests", | |||
| ] | |||
| UNIT_TEST_EXTRAS_BY_PYTHON: Dict[str, List[str]] = { | |||
| "3.8": [ | |||
There was a problem hiding this comment.
Do we want to change this to 3.9 instead?
Linchin
reviewed
Jul 23, 2025
| @@ -148,7 +148,7 @@ Running System Tests | |||
|
|
|||
| .. note:: | |||
|
|
|||
| System tests are only configured to run under Python 3.8, 3.12, and 3.13. | |||
| System tests are only configured to run under Python 3.12, and 3.13. | |||
Linchin
reviewed
Jul 23, 2025
| @@ -398,9 +426,7 @@ def compliance(session): | |||
| "-c", | |||
| constraints_path, | |||
| ) | |||
| if session.python == "3.8": | |||
| extras = "[tests,alembic]" | |||
There was a problem hiding this comment.
I wonder if we still need coverage for alembic?
Linchin
reviewed
Jul 23, 2025
| @@ -30,14 +30,13 @@ | |||
| # ---------------------------------------------------------------------------- | |||
| extras = ["tests"] | |||
| extras_by_python = { | |||
| "3.8": ["tests", "alembic", "bqstorage"], | |||
There was a problem hiding this comment.
It feels like we need to change this into 3.9 too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds several minor tweaks that were useful for debugging some of the mods to this PR (and are useful in general for all future debugging efforts), such as:
pip freezeto display what dependencies have been installed@calculate_durationdecorator to confirm the total time to execute anox session.