-
Notifications
You must be signed in to change notification settings - Fork 138
feat: remove python 3.8 support #1215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@@ -56,11 +58,6 @@ | |||
"tests", | |||
] | |||
UNIT_TEST_EXTRAS_BY_PYTHON: Dict[str, List[str]] = { | |||
"3.8": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to change this to 3.9 instead?
@@ -148,7 +148,7 @@ Running System Tests | |||
|
|||
.. note:: | |||
|
|||
System tests are only configured to run under Python 3.8, 3.12, and 3.13. | |||
System tests are only configured to run under Python 3.12, and 3.13. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to add 3.9 here
@@ -398,9 +426,7 @@ def compliance(session): | |||
"-c", | |||
constraints_path, | |||
) | |||
if session.python == "3.8": | |||
extras = "[tests,alembic]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we still need coverage for alembic?
@@ -30,14 +30,13 @@ | |||
# ---------------------------------------------------------------------------- | |||
extras = ["tests"] | |||
extras_by_python = { | |||
"3.8": ["tests", "alembic", "bqstorage"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It feels like we need to change this into 3.9 too?
Also adds several minor tweaks that were useful for debugging some of the mods to this PR (and are useful in general for all future debugging efforts), such as:
pip freeze
to display what dependencies have been installed@calculate_duration
decorator to confirm the total time to execute anox session
.