-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ChocolateClassicalSans-Regular.ttf #8699
Conversation
Adding vhea/vmtx tables
FontBakery reportfontbakery version: 0.13.0a6 Check results[34] ChocolateClassicalSans-Regular.ttf🔥 FAIL Ensure files are not too large.
🔥 FAIL METADATA.pb: Check URL on copyright string is the same as in repository_url field.
But: font copyright string has 'https://github.com/MoonlitOwen/ChocolateSans', OFL text has 'https://github.com/MoonlitOwen/ChocolateSans' and HTML description has 'github.com/MoonlitOwen/ChocolateSans' [code: mismatch]🔥 FAIL Shapes languages in all GF glyphsets.
|
ofl/chocolateclassicalsans/ChocolateClassicalSans-Regular.ttf | |
---|---|
Dehinted Size | 9.7Mb |
Hinted Size | 9.7Mb |
Increase | 24 bytes |
Change | 0.0 % |
ℹ️ INFO Font contains all required tables?
- ℹ️ INFO
This font contains the following optional tables:
- loca
- prep
- GPOS
- GSUB
- gasp
- vhea
- vmtx
[code: optional-tables]
ℹ️ INFO METADATA.pb: Validate family.minisite_url field.
- ℹ️ INFO
Please consider adding a family.minisite_url entry.
[code: lacks-minisite-url]
ℹ️ INFO Does DESCRIPTION file contain a upstream Git repo URL?
- ℹ️ INFO
Found a git repo URL: https://github.com/MoonlitOwen/ChocolateSans
[code: url-found]
ℹ️ INFO Check for presence of an ARTICLE.en_us.html file
- ℹ️ INFO
This font doesn't have an ARTICLE.en_us.html file.
[code: missing-article]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
- ℹ️ INFO
These are the ppm ranges declared on the gasp table:
PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®
[code: ranges][1] Family checks
Summary
💥 ERROR | ☠ FATAL | 🔥 FAIL | ⏩ SKIP | ℹ️ INFO | ✅ PASS | 🔎 DEBUG | |
---|---|---|---|---|---|---|---|
0 | 0 | 3 | 22 | 57 | 10 | 151 | 0 |
0% | 0% | 1% | 9% | 23% | 4% | 62% | 0% |
Note: The following loglevels were omitted in this report:
- SKIP
- PASS
- DEBUG
@aaronbell, I see some tofu in dev-sandbox. But nothing changed in sources regarding language support, can you confirm? Dev-sandbox version:API version |
Nope, zero change to the language coverage. Actually, it looks like the same glyphs are missing as were missing in Iansui. So I’m guessing there’s a glyphset problem on dev? |
Updated font to include vmtx and vhea tables.
(data was in the font, but due to the metadata missing in the fontinfo file, fontmake was not generating the tables. This has now been corrected). See #8694