Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing vertical spacing information for Traditional Chinese fonts #8694

Closed
NightFurySL2001 opened this issue Dec 6, 2024 · 1 comment · Fixed by #8700 or #8699
Closed

Missing vertical spacing information for Traditional Chinese fonts #8694

NightFurySL2001 opened this issue Dec 6, 2024 · 1 comment · Fixed by #8700 or #8699
Assignees
@aaronbell
Labels
I Font Bug P2
Milestone
2025 Q1

Comments

@NightFurySL2001
Copy link
Contributor

The two new Traditional Chinese font, Chocolate Classical Sans and Cactus Classical Serif have issues with vertical typesetting.

Describe the bug

Chinese text when typeset vertically has extraneous gap between character.

Chocolate Classical Sans:
Image

Cactus Classical Serif:
Image

It seems like the rebuild by @aaronbell in https://github.com/aaronbell/ChocolateSans and https://github.com/aaronbell/CactusSerif (missing ttf by the way) mistakenly dropped the vhea/vmtx table that were present in the original upstream font.

To Reproduce

  1. Create a HTML with <p style="writing-mode: vertical-rl" lang="zh-Hant"></p>
  2. Load the font in HTMl and apply to the <p>
  3. View in Google Chrome browser/Microsoft Edge browser.

Expected behavior

Text should have no spacing between characters vertically. LXGW WenKai TC does not show this problem.
Image

Additional context

Sample HTML 
<html>
    <head>
        <link rel="preconnect" href="https://fonts.googleapis.com">
        <link rel="preconnect" href="https://fonts.gstatic.com" crossorigin>
        <link href="https://fonts.googleapis.com/css2?family=Cactus+Classical+Serif&family=Chocolate+Classical+Sans&family=LXGW+WenKai+TC&display=swap" rel="stylesheet">
        <style>
            body {
                writing-mode: vertical-rl;
                font-family: "Chocolate Classical Sans";  //change the font-family here
                font-size: 20pt;
                padding: 1em;
            }
        </style>
    </head>
    <body>
        <h1>漢字</h1>
        <p>
            漢字，又稱漢文、華文、中文、華語字、唐話字、唐人字、中國字，是書寫漢語所使用的文字系統，也是現今世界上唯一仍廣泛使用的語素文字，主要流行於漢字文化圈（特別是大中華地區），也是聯合國四種官方文字之一（另外三種皆為拼音文字，分別是英語、法語與西班牙語使用的拉丁文字、俄語使用的西里爾文字和阿拉伯語使用的阿拉伯文字）。
        </p>
        <p>
            漢字是世界歷史上唯一被高度發展的語素文字，從基礎的象形字和指事字發展出了現今以形聲字和會意字為主流的六書系統，加上各類異體字和生僻字在所有字典中總共收錄超過十萬字。每個漢字在結構上由最基礎的筆畫進行二維排列組成，每個筆畫不包含任何語素，相當於表音文字的字母；由筆畫組成的偏旁部首是漢字內部結構上的最小語素單位，相當於一些表音文字的詞根。除形聲字外的漢字通常不具備音素，而形聲字的聲旁則帶有一定表音功能，但因為其大多基於上古漢語的發音所以與現代標準漢語有一些差異。現今漢字通常使用額外獨立的標音幫助閱讀，在中華民國時期主要使用注音符號，但在台灣以外的地區（特別是中國大陸）主要使用拉丁化的漢語拼音。雖然絕大多數漢字單字都擁有自身的獨立含義，在語法上相當於英文的單詞，但漢語詞彙通常都是由兩個以上單字組成的合成詞。
        </p>
    </body>
</html>
@NightFurySL2001 NightFurySL2001 changed the title Missing vertical typesetting information for Traditional Chinese fonts Missing vertical spacing information for Traditional Chinese fonts Dec 6, 2024
This was referenced Dec 6, 2024
Merged
Merged
@chrissimpkins chrissimpkins added this to the 2025 Q1 milestone Dec 6, 2024
@chrissimpkins chrissimpkins moved this from Todo to In Progress in Google Fonts Dec 6, 2024
@chrissimpkins chrissimpkins linked a pull request Dec 6, 2024 that will close this issue
Update ChocolateClassicalSans-Regular.ttf #8699
Merged
@chrissimpkins
Copy link
Collaborator

Thank you for the report! Aaron included fixes in:

We'll roll these out in early Q1.

@github-project-automation github-project-automation bot moved this from In Progress to In Dev / PR Merged in Google Fonts Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aaronbell aaronbell

Labels
I Font Bug P2
Projects
Google Fonts
Status: In Dev / PR Merged
Milestone
2025 Q1
3 participants
@chrissimpkins @aaronbell @NightFurySL2001