Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asset: Version 1.003; ttfautohint (v1.8.4.7-5d5b) added #7044

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

yanone
Copy link
Collaborator

@yanone yanone commented Nov 30, 2023

9c7c131: [gftools-packager] Asset: Version 1.003; ttfautohint (v1.8.4.7-5d5b) added

…added

* Asset Version 1.003; ttfautohint (v1.8.4.7-5d5b) taken from the upstream repo https://github.com/SorkinType/Asset at commit SorkinType/Asset@8b65aa0.
@yanone yanone linked an issue Nov 30, 2023 that may be closed by this pull request
Copy link

FontBakery report

fontbakery version: 0.10.4

[1] Experimental checks
🔥 FAIL: Shapes languages in all GF glyphsets. (com.google.fonts/check/glyphsets/shape_languages)
  • 🔥 FAIL GF_Latin_Core glyphset:
Language FAIL messages
lg_Latn (Ganda) The locl feature did not affect Eng
haw_Latn (Hawaiian) Some base glyphs were missing: ʻ
^ Shaper produced a .notdef
dyo_Latn (Jola-Fonyi) The locl feature did not affect Eng
ny_Latn (Nyanja) The locl feature did not affect Eng
teo_Latn (Teso) Some base glyphs were missing: Ɔ, Ɛ, Ɨ, Ʉ, ɔ, ɛ, ɨ, ʉ, ᵃ, ᵉ, ᵋ, ᵒ, ᵓ, ᵘ, ᶤ, ᶶ, ⁱ
^ Shaper produced a .notdef
wo_Latn (Wolof) The locl feature did not affect Eng

[code: failed-language-shaping]


[1] Family checks
INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
  • INFO From a total of 1 font files, 1 of them (100.00%) lack a STAT table.

    And these are the most common STAT axis orderings:
    [code: summary]


[18] Asset-Regular.ttf
WARN: DESCRIPTION.en_us.html should end in a linebreak. (com.google.fonts/check/description/eof_linebreak)
  • WARN The last characther on DESCRIPTION.en_us.html is not a line-break. Please add it. [code: missing-eof-linebreak]
WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)
  • WARN The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02C7 CARON: try adding one of: tifinagh, yi, canadian-aboriginal

  • U+02D8 BREVE: try adding one of: yi, canadian-aboriginal

  • U+02D9 DOT ABOVE: try adding one of: yi, canadian-aboriginal

  • U+02DB OGONEK: try adding one of: yi, canadian-aboriginal

  • U+02DD DOUBLE ACUTE ACCENT: not included in any glyphset definition

  • U+0306 COMBINING BREVE: try adding one of: tifinagh, old-permic

  • U+030A COMBINING RING ABOVE: try adding syriac

  • U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: osage, cherokee

  • U+030C COMBINING CARON: try adding one of: cherokee, tai-le

  • U+0312 COMBINING TURNED COMMA ABOVE: not included in any glyphset definition
    35 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: cyrillic-ext, latin, latin-ext, math, menu, symbols [code: unreachable-subsetting]

WARN: Glyphs are similiar to Google Fonts version? (com.google.fonts/check/production_glyphs_similarity)
  • WARN Following glyphs differ greatly from Google Fonts version:
    • .notdef
    • Aring
    • Atilde
    • Ccedilla
    • Itilde
    • Ntilde
    • Otilde
    • Rcaron
    • aring and ccedilla
WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
  • WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
WARN: Check if each glyph has the recommended amount of contours. (com.google.fonts/check/contour_count)
  • WARN This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct.

The following glyphs do not have the recommended number of contours:

- Glyph name: aogonek	Contours detected: 3	Expected: 2

- Glyph name: eogonek	Contours detected: 3	Expected: 2

- Glyph name: Uogonek	Contours detected: 2	Expected: 1

- Glyph name: uogonek	Contours detected: 2	Expected: 1

- Glyph name: Uogonek	Contours detected: 2	Expected: 1

- Glyph name: aogonek	Contours detected: 3	Expected: 2

- Glyph name: eogonek	Contours detected: 3	Expected: 2

- Glyph name: uogonek	Contours detected: 2	Expected: 1

[code: contour-count]

WARN: Check math signs have the same width. (com.google.fonts/check/math_signs_width)
  • WARN The most common width is 1684 among a set of 5 math glyphs.
    The following math glyphs have a different width, though:

Width = 1429:
less, greater

Width = 1714:
logicalnot

Width = 1468:
multiply

Width = 1200:
notequal
[code: width-outliers]

WARN: Do any segments have colinear vectors? (com.google.fonts/check/outline_colinear_vectors)
  • WARN The following glyphs have colinear vectors:

    • Lslash (U+0141): L<<2400.0,810.0>--<2400.0,800.0>> -> L<<2400.0,800.0>--<2399.0,788.0>>

    • N (U+004E): L<<1805.0,0.0>--<1439.0,315.0>> -> L<<1439.0,315.0>--<739.0,915.0>>

    • Nacute (U+0143): L<<1805.0,0.0>--<1439.0,315.0>> -> L<<1439.0,315.0>--<739.0,915.0>>

    • Ncaron (U+0147): L<<1805.0,0.0>--<1439.0,315.0>> -> L<<1439.0,315.0>--<739.0,915.0>>

    • Ntilde (U+00D1): L<<1805.0,0.0>--<1439.0,315.0>> -> L<<1439.0,315.0>--<739.0,915.0>>

    • Oslash (U+00D8): L<<1753.0,645.0>--<1753.0,675.0>> -> L<<1753.0,675.0>--<1752.0,703.0>>

    • P (U+0050): L<<1655.0,1170.0>--<1655.0,619.0>> -> L<<1655.0,619.0>--<1657.0,573.0>>

    • Z (U+005A): L<<2584.0,507.0>--<2631.0,507.0>> -> L<<2631.0,507.0>--<2677.0,508.0>>

    • Zacute (U+0179): L<<2584.0,507.0>--<2631.0,507.0>> -> L<<2631.0,507.0>--<2677.0,508.0>>

    • Zcaron (U+017D): L<<2584.0,507.0>--<2631.0,507.0>> -> L<<2631.0,507.0>--<2677.0,508.0>>

    • 41 more.

Use -F or --full-lists to disable shortening of long lists. [code: found-colinear-vectors]

WARN: Do outlines contain any jaggy segments? (com.google.fonts/check/outline_jaggy_segments)
  • WARN The following glyphs have jaggy segments:

    • B (U+0042): B<<2382.0,690.0>-<2193.0,681.0>-<1993.0,679.0>>/B<<1993.0,679.0>-<2242.0,678.0>-<2460.5,669.0>> = 0.8030409927805215

    • R (U+0052): B<<2317.5,629.0>-<2179.0,622.0>-<2029.0,621.0>>/L<<2029.0,621.0>--<2454.0,621.0>> = 0.3819662047286989

    • Racute (U+0154): B<<2317.5,629.0>-<2179.0,622.0>-<2029.0,621.0>>/L<<2029.0,621.0>--<2454.0,621.0>> = 0.3819662047286989

    • Rcaron (U+0158): B<<2317.5,629.0>-<2179.0,622.0>-<2029.0,621.0>>/L<<2029.0,621.0>--<2454.0,621.0>> = 0.3819662047286989

    • a (U+0061): B<<1078.0,996.0>-<932.0,996.0>-<804.0,988.0>>/B<<804.0,988.0>-<995.0,988.0>-<1111.0,935.5>> = 3.576334374997269

    • aacute (U+00E1): B<<1078.0,996.0>-<932.0,996.0>-<804.0,988.0>>/B<<804.0,988.0>-<995.0,988.0>-<1111.0,935.5>> = 3.576334374997269

    • abreve (U+0103): B<<1078.0,996.0>-<932.0,996.0>-<804.0,988.0>>/B<<804.0,988.0>-<995.0,988.0>-<1111.0,935.5>> = 3.576334374997269

    • acircumflex (U+00E2): B<<1078.0,996.0>-<932.0,996.0>-<804.0,988.0>>/B<<804.0,988.0>-<995.0,988.0>-<1111.0,935.5>> = 3.576334374997269

    • adieresis (U+00E4): B<<1078.0,996.0>-<932.0,996.0>-<804.0,988.0>>/B<<804.0,988.0>-<995.0,988.0>-<1111.0,935.5>> = 3.576334374997269

    • ae (U+00E6): B<<1091.5,982.5>-<990.0,988.0>-<849.0,988.0>>/B<<849.0,988.0>-<943.0,986.0>-<1014.0,969.5>> = 1.2188752351313326

    • 58 more.

Use -F or --full-lists to disable shortening of long lists. [code: found-jaggy-segments]

WARN: Do outlines contain any semi-vertical or semi-horizontal lines? (com.google.fonts/check/outline_semi_vertical)
  • WARN The following glyphs have semi-vertical/semi-horizontal lines:

    • Ccedilla (U+00C7): L<<1371.0,156.0>--<1372.0,-124.0>>

    • Eng (U+014A): L<<2801.0,922.0>--<2799.0,535.0>>

    • Scedilla (U+015E): L<<1362.0,156.0>--<1363.0,-124.0>>

    • at (U+0040): L<<2586.0,660.0>--<2585.0,454.0>>

    • bar (U+007C): L<<360.0,525.0>--<362.0,290.0>>

    • bar (U+007C): L<<362.0,772.0>--<360.0,525.0>>

    • bar (U+007C): L<<365.0,1145.0>--<362.0,772.0>>

    • ccedilla (U+00E7): L<<1185.0,156.0>--<1186.0,-124.0>>

    • cedilla (U+00B8): L<<792.0,156.0>--<793.0,-124.0>>

    • dcroat (U+0111): L<<1475.0,1113.0>--<1293.0,1112.0>>

    • 18 more.

Use -F or --full-lists to disable shortening of long lists. [code: found-semi-vertical]

WARN: Ensure dotted circle glyph is present and can attach marks. (com.google.fonts/check/dotted_circle)
  • WARN No dotted circle glyph present [code: missing-dotted-circle]
WARN: Ensure soft_dotted characters lose their dot when combined with marks that replace the dot. (com.google.fonts/check/soft_dotted)
  • WARN The dot of soft dotted characters used in orthographies must disappear in the following strings: į̀ į́ į̂ į̃ į̄ į̌ ị̀ ị́ ị̂ ị̃ ị̄

The dot of soft dotted characters should disappear in other cases, for example: į̆ į̇ į̈ į̊ į̋ į̒ į̣̀ į̣́ į̣̂ į̣̃ į̣̄ į̣̆ į̣̇ į̣̈ į̣̊ į̣̋ į̣̌ į̣̒ į̦̀ į̦́

Your font fully covers the following languages that require the soft-dotted feature: Dutch (Latn, 31,709,104 speakers), Lithuanian (Latn, 2,357,094 speakers), Navajo (Latn, 166,319 speakers).

Your font does not cover the following languages that require the soft-dotted feature: Mango (Latn, 77,000 speakers), Igbo (Latn, 27,823,640 speakers), Gulay (Latn, 250,478 speakers), Sar (Latn, 500,000 speakers), Ebira (Latn, 2,200,000 speakers), Dan (Latn, 1,099,244 speakers), Basaa (Latn, 332,940 speakers), Kom (Latn, 360,685 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Nateni (Latn, 100,000 speakers), Belarusian (Cyrl, 10,064,517 speakers), Ma’di (Latn, 584,000 speakers), Aghem (Latn, 38,843 speakers), Avokaya (Latn, 100,000 speakers), Koonzime (Latn, 40,000 speakers), Ejagham (Latn, 120,000 speakers), Lugbara (Latn, 2,200,000 speakers). [code: soft-dotted]

INFO: Does DESCRIPTION file contain a upstream Git repo URL? (com.google.fonts/check/description/git_url)
INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
  • INFO Hinting filesize impact:
ofl/asset/Asset-Regular.ttf
Dehinted Size 154.1kb
Hinted Size 182.3kb
Increase 28.2kb
Change 18.3 %
[code: size-impact]
INFO: EPAR table present in font? (com.google.fonts/check/epar)
INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
  • INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
  • INFO Version string is: "Version 1.003; ttfautohint (v1.8.4.7-5d5b)"
    The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
    "Version 1.3; git-0d08353-release" [code: bad-format]
INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
  • INFO This font contains the following optional tables:

    • cvt

    • fpgm

    • loca

    • prep

    • GPOS

    • GSUB

    • gasp [code: optional-tables]

INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
  • INFO ofl/asset [code: family-path]

Summary

💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 1 11 63 8 172 0
0% 0% 4% 25% 3% 67% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@yanone yanone added I Small Fix bugs fixed but nothing added III Improve rendering / layout by addition of manual hinting, kerning or else labels Dec 1, 2023
@yanone
Copy link
Collaborator Author

yanone commented Dec 1, 2023

The font was re-engineered from a source found by Eben which shows some minor differences in outlines (mainly accents). Also, more importantly, this font has kerning whereas the live font doesn't, which causes quite some metric regressions. I call them progressions, though, because now it has kerning ;)

@yanone yanone added I Font Bug and removed I Small Fix bugs fixed but nothing added labels Dec 1, 2023
@RosaWagner RosaWagner merged commit ade3d53 into main Dec 6, 2023
9 checks passed
@RosaWagner RosaWagner deleted the gftools_packager_ofl_asset branch December 6, 2023 15:26
@RosaWagner RosaWagner added I Small Fix bugs fixed but nothing added and removed I Font Bug labels Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I Small Fix bugs fixed but nothing added III Improve rendering / layout by addition of manual hinting, kerning or else
Projects
Status: Live
Development

Successfully merging this pull request may close these issues.

Asset: acute and grave diacritics are reversed in uppercase letters
2 participants