Asset: Hot-fixed acute/grave diacritics on capital letters

[yanone]

No description provided.

[github-actions]

FontBakery report

fontbakery version: 0.10.3

[1] Experimental checks

🔥 FAIL: Shapes languages in all GF glyphsets. (com.google.fonts/check/glyphsets/shape_languages)

• 🔥 FAIL GF_Latin_Kernel/kl_Latn (Kalaallisut): [FAIL: Some mark glyphs were missing: ◌̀, ◌́, ◌̂, ◌̃, ◌̊] [code: failed-language-shaping]
• 🔥 FAIL GF_Latin_Kernel/zu_Latn (Zulu): [FAIL: Some mark glyphs were missing: ◌̀, ◌́, ◌̂, ◌̃, ◌̄, ◌̆, ◌̈, ◌̊, ◌̧] [code: failed-language-shaping]

[1] Family checks

ℹ INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)

• ℹ INFO From a total of 1 font files, 1 of them (100.00%) lack a STAT table.

  And these are the most common STAT axis orderings:
  [code: summary]

[33] Asset-Regular.ttf

🔥 FAIL: Does DESCRIPTION file contain a upstream Git repo URL? (com.google.fonts/check/description/git_url)

• 🔥 FAIL Please host your font project on a public Git repo (such as GitHub or GitLab) and place a link in the DESCRIPTION.en_us.html file. [code: lacks-git-url]

🔥 FAIL: Check Google Fonts glyph coverage. (com.google.fonts/check/glyph_coverage)

• 🔥 FAIL Missing required codepoints:

  • 0x2026 (HORIZONTAL ELLIPSIS)

  • 0x0308 (COMBINING DIAERESIS)

  • 0x0300 (COMBINING GRAVE ACCENT)

  • 0x0301 (COMBINING ACUTE ACCENT)

  • 0x030B (COMBINING DOUBLE ACUTE ACCENT)

  • 0x0304 (COMBINING MACRON)

  • 0x02D9 (DOT ABOVE)

  • 0x0102 (LATIN CAPITAL LETTER A WITH BREVE)

  • 0x0100 (LATIN CAPITAL LETTER A WITH MACRON)

  • 0x0104 (LATIN CAPITAL LETTER A WITH OGONEK)

  • 109 more.

Use -F or --full-lists to disable shortening of long lists. [code: missing-codepoints]

🔥 FAIL: Check license file has good copyright string. (com.google.fonts/check/license/OFL_copyright)

• 🔥 FAIL First line in license file is:

"copyright (c) 2011 by sorkin type co (www.sorkintype.com),"

which does not match the expected format, similar to:

"Copyright 2022 The Familyname Project Authors (git url)" [code: bad-format]

🔥 FAIL: Check copyright namerecords match license file. (com.google.fonts/check/name/license)

• 🔥 FAIL License file OFL.txt exists but NameID 13 (LICENSE DESCRIPTION) value on platform 3 (WINDOWS) is not specified for that. Value was: "This Font Software is licensed under the SIL Open Font License, Version 1.1." Must be changed to "This Font Software is licensed under the SIL Open Font License, Version 1.1. This license is available with a FAQ at: https://scripts.sil.org/OFL" [code: wrong]

🔥 FAIL: Copyright notices match canonical pattern in METADATA.pb (com.google.fonts/check/metadata/valid_copyright)

• 🔥 FAIL METADATA.pb: Copyright notices should match a pattern similar to:
  "Copyright 2020 The Familyname Project Authors (git url)"
  But instead we have got:
  "copyright (c) 2011, sorkin type co (www.sorkintype.com) with reserved font name "asset". this font software is licensed under the sil open font license, version 1.1. this license is available with a faq at: http://scripts.sil.org/ofl" [code: bad-notice-format]

🔥 FAIL: Copyright notices match canonical pattern in fonts (com.google.fonts/check/font_copyright)

• 🔥 FAIL Name Table entry: Copyright notices should match a pattern similar to: "Copyright 2019 The Familyname Project Authors (git url)"
  But instead we have got:
  "Copyright (c) 2011, Sorkin Type Co (www.sorkintype.com)
  with Reserved Font Name "Asset".

This Font Software is licensed under the SIL Open Font License,
Version 1.1. This license is available with a FAQ at:
http://scripts.sil.org/OFL" [code: bad-notice-format]

🔥 FAIL: METADATA.pb: Check URL on copyright string is the same as in repository_url field. (com.google.fonts/check/metadata/consistent_repo_urls)

• 🔥 FAIL Please add a family.source.repository_url entry. [code: lacks-repo-url]

🔥 FAIL: Version number has increased since previous release on Google Fonts? (com.google.fonts/check/version_bump)

• 🔥 FAIL Version number 1.0019989013671875 is equal to version on Google Fonts.
• 🔥 FAIL Version number 1.0019989013671875 is equal to version on Google Fonts GitHub repo.

🔥 FAIL: Copyright field for this font on METADATA.pb matches all copyright notice entries on the name table ? (com.google.fonts/check/metadata/nameid/copyright)

• 🔥 FAIL Copyright field for this font on METADATA.pb ("Copyright (c) 2011, Sorkin Type Co (www.sorkintype.com) with Reserved Font Name "Asset". This Font Software is licensed under the SIL Open Font License, Version 1.1. This license is available with a FAQ at: http://scripts.sil.org/OFL") differs from a copyright notice entry on the name table: "Copyright (c) 2011, Sorkin Type Co (www.sorkintype.com)
  with Reserved Font Name "Asset".

This Font Software is licensed under the SIL Open Font License,
Version 1.1. This license is available with a FAQ at:
http://scripts.sil.org/OFL" [code: mismatch]

🔥 FAIL: Check if the vertical metrics of a family are similar to the same family hosted on Google Fonts. (com.google.fonts/check/vertical_metrics_regressions)

• 🔥 FAIL Asset Regular: OS/2 sTypoDescender is -598 when it should be -589 [code: bad-typo-descender]

🔥 FAIL: Ensure METADATA.pb does not use escaped strings. (com.google.fonts/check/metadata/escaped_strings)

• 🔥 FAIL Found escaped chars at 'Copyright (c) 2011, Sorkin Type Co (www.sorkintype.com) with Reserved Font Name '. Please use an unicode string instead. [code: escaped-strings]

🔥 FAIL: OS/2.fsSelection bit 7 (USE_TYPO_METRICS) is set in all fonts. (com.google.fonts/check/os2/use_typo_metrics)

• 🔥 FAIL OS/2.fsSelection bit 7 (USE_TYPO_METRICS) wasNOT set in the following fonts: ['ofl/asset/Asset-Regular.ttf']. [code: missing-os2-fsselection-bit7]

🔥 FAIL: Checking OS/2 Metrics match hhea Metrics. (com.google.fonts/check/os2_metrics_match_hhea)

• 🔥 FAIL OS/2 sTypoDescender (-598) and hhea descent (-589) must be equal. [code: descender]

🔥 FAIL: Font contains '.notdef' as its first glyph? (com.google.fonts/check/mandatory_glyphs)

• 🔥 FAIL The '.notdef' glyph should contain a drawing, but it is blank. [code: notdef-is-blank]

⚠ WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)

• ⚠ WARN The following codepoints supported by the font are not covered by
  any subsets defined in the font's metadata file, and will never
  be served. You can solve this by either manually adding additional
  subset declarations to METADATA.pb, or by editing the glyphset
  definitions.

• U+0127 LATIN SMALL LETTER H WITH STROKE: try adding latin-ext

• U+0128 LATIN CAPITAL LETTER I WITH TILDE: try adding one of: vietnamese, latin-ext

• U+0129 LATIN SMALL LETTER I WITH TILDE: try adding one of: vietnamese, latin-ext

• U+0133 LATIN SMALL LIGATURE IJ: try adding latin-ext

• U+0134 LATIN CAPITAL LETTER J WITH CIRCUMFLEX: try adding latin-ext

• U+0135 LATIN SMALL LETTER J WITH CIRCUMFLEX: try adding latin-ext

• U+0137 LATIN SMALL LETTER K WITH CEDILLA: try adding latin-ext

• U+0138 LATIN SMALL LETTER KRA: try adding latin-ext

• U+0140 LATIN SMALL LETTER L WITH MIDDLE DOT: try adding latin-ext

• U+0141 LATIN CAPITAL LETTER L WITH STROKE: try adding latin-ext
  10 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: latin, menu [code: unreachable-subsetting]

⚠ WARN: Copyright notice on METADATA.pb should not contain 'Reserved Font Name'. (com.google.fonts/check/metadata/reserved_font_name)

• ⚠ WARN METADATA.pb: copyright field ("Copyright (c) 2011, Sorkin Type Co (www.sorkintype.com) with Reserved Font Name "Asset". This Font Software is licensed under the SIL Open Font License, Version 1.1. This license is available with a FAQ at: http://scripts.sil.org/OFL") contains "Reserved Font Name". This is an error except in a few specific rare cases. [code: rfn]

⚠ WARN: Name table strings must not contain the string 'Reserved Font Name'. (com.google.fonts/check/name/rfn)

• ⚠ WARN Name table entry contains "Reserved Font Name" for a family name ("Asset".

This Font Software is licensed under the SIL Open Font License,
Version 1.1. This license is available with a FAQ at:
http://scripts.sil) that differs from the currently used family name (Asset), which is fine. [code: legacy-familyname]

⚠ WARN: On a family update, the DESCRIPTION.en_us.html file should ideally also be updated. (com.google.fonts/check/description/family_update)

• ⚠ WARN The DESCRIPTION.en_us.html file in this family has not changed in comparison to the latest font release on the google/fonts github repo.
  Please consider mentioning note-worthy improvements made to the family recently. [code: description-not-updated]

⚠ WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)

• ⚠ WARN This font file does not have a 'meta' table. [code: lacks-meta-table]

⚠ WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)

• ⚠ WARN The following glyphs could not be reached by codepoint or substitution rules:

  • nonmarkingreturn
    [code: unreachable-glyphs]

⚠ WARN: Check math signs have the same width. (com.google.fonts/check/math_signs_width)

• ⚠ WARN The most common width is 1684 among a set of 4 math glyphs.
  The following math glyphs have a different width, though:

Width = 1429:
less, greater

Width = 1714:
logicalnot

Width = 1468:
multiply
[code: width-outliers]

⚠ WARN: Check if OS/2 xAvgCharWidth is correct. (com.google.fonts/check/xavgcharwidth)

• ⚠ WARN OS/2 xAvgCharWidth is 2499 but it should be 2485 which corresponds to the average of the widths of all glyphs in the font. [code: xAvgCharWidth-wrong]

⚠ WARN: Does GPOS table have kerning information? This check skips monospaced fonts as defined by post.isFixedPitch value (com.google.fonts/check/gpos_kerning_info)

• ⚠ WARN GPOS table lacks kerning information. [code: lacks-kern-info]

⚠ WARN: Are there any misaligned on-curve points? (com.google.fonts/check/outline_alignment_miss)

• ⚠ WARN The following glyphs have on-curve points which have potentially incorrect y coordinates:

  • dollar (U+0024): X=299.0,Y=1.5 (should be at baseline 0?)

  • one (U+0031): X=1264.0,Y=1291.5 (should be at cap-height 1291?)

  • five (U+0035): X=412.5,Y=1292.5 (should be at cap-height 1291?)

  • eight (U+0038): X=729.5,Y=-1.0 (should be at baseline 0?)

  • C (U+0043): X=2307.0,Y=1292.5 (should be at cap-height 1291?)

  • G (U+0047): X=1979.0,Y=1289.5 (should be at cap-height 1291?)

  • K (U+004B): X=2189.0,Y=1.0 (should be at baseline 0?)

  • S (U+0053): X=281.0,Y=1.5 (should be at baseline 0?)

  • b (U+0062): X=1386.0,Y=1047.5 (should be at x-height 1047?)

  • c (U+0063): X=1915.5,Y=1.0 (should be at baseline 0?)

  • 51 more.

Use -F or --full-lists to disable shortening of long lists. [code: found-misalignments]

⚠ WARN: Do outlines contain any jaggy segments? (com.google.fonts/check/outline_jaggy_segments)

• ⚠ WARN The following glyphs have jaggy segments:

  • B (U+0042): B<<2256.0,684.0>-<2125.0,680.0>-<1993.0,679.0>>/B<<1993.0,679.0>-<2156.0,678.0>-<2313.0,674.5>> = 0.7855540720123465

  • R (U+0052): B<<2317.5,629.0>-<2179.0,622.0>-<2029.0,621.0>>/L<<2029.0,621.0>--<2454.0,621.0>> = 0.3819662047286989

  • Racute (U+0154): B<<2317.5,629.0>-<2179.0,622.0>-<2029.0,621.0>>/L<<2029.0,621.0>--<2454.0,621.0>> = 0.3819662047286989

  • Rcaron (U+0158): B<<2317.5,629.0>-<2179.0,622.0>-<2029.0,621.0>>/L<<2029.0,621.0>--<2454.0,621.0>> = 0.3819662047286989

  • Rcommaaccent (U+0156): B<<2317.5,629.0>-<2179.0,622.0>-<2029.0,621.0>>/L<<2029.0,621.0>--<2454.0,621.0>> = 0.3819662047286989

  • a (U+0061): B<<935.5,994.0>-<864.0,992.0>-<804.0,988.0>>/B<<804.0,988.0>-<898.0,988.0>-<976.0,974.5>> = 3.8140748342903783

  • aacute (U+00E1): B<<935.5,994.0>-<864.0,992.0>-<804.0,988.0>>/B<<804.0,988.0>-<898.0,988.0>-<976.0,974.5>> = 3.8140748342903783

  • acircumflex (U+00E2): B<<935.5,994.0>-<864.0,992.0>-<804.0,988.0>>/B<<804.0,988.0>-<898.0,988.0>-<976.0,974.5>> = 3.8140748342903783

  • adieresis (U+00E4): B<<935.5,994.0>-<864.0,992.0>-<804.0,988.0>>/B<<804.0,988.0>-<898.0,988.0>-<976.0,974.5>> = 3.8140748342903783

  • ae (U+00E6): B<<1091.5,983.0>-<990.0,988.0>-<849.0,988.0>>/B<<849.0,988.0>-<943.0,986.0>-<1014.0,969.5>> = 1.2188752351313326

  • 31 more.

Use -F or --full-lists to disable shortening of long lists. [code: found-jaggy-segments]

⚠ WARN: Do outlines contain any semi-vertical or semi-horizontal lines? (com.google.fonts/check/outline_semi_vertical)

• ⚠ WARN The following glyphs have semi-vertical/semi-horizontal lines:

  • cedilla (U+00B8): L<<792.0,156.0>--<793.0,-124.0>> [code: found-semi-vertical]

ℹ INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)

• ℹ INFO Hinting filesize impact:

	ofl/asset/Asset-Regular.ttf
Dehinted Size	47.2kb
Hinted Size	47.3kb
Increase	32 bytes
Change	0.1 %
[code: size-impact]

ℹ INFO: Font has old ttfautohint applied? (com.google.fonts/check/old_ttfautohint)

• ℹ INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 1.002'] [code: version-not-detected]

ℹ INFO: EPAR table present in font? (com.google.fonts/check/epar)

• ℹ INFO EPAR table not present in font. To learn more see When missing EPAR table, just emit INFO alert fonttools/fontbakery#818 [code: lacks-EPAR]

ℹ INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)

• ℹ INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

ℹ INFO: Check for font-v versioning. (com.google.fonts/check/fontv)

• ℹ INFO Version string is: "Version 1.002"
  The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
  "Version 1.3; git-0d08353-release" [code: bad-format]

ℹ INFO: Font contains all required tables? (com.google.fonts/check/required_tables)

• ℹ INFO This font contains the following optional tables:

  • loca

  • prep

  • gasp [code: optional-tables]

ℹ INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)

• ℹ INFO ofl/asset [code: family-path]

Summary

💔 ERROR	🔥 FAIL	⚠ WARN	💤 SKIP	ℹ INFO	🍞 PASS	🔎 DEBUG
0	15	12	67	8	153	0
0%	6%	5%	26%	3%	60%	0%

Note: The following loglevels were omitted in this report:

• SKIP
• PASS
• DEBUG

[RosaWagner]

The author is Riccardo De Franceschi but the copyright indicates everywhere Sorkin Type, Maybe we could ask Eben about that.

Let's close as much FAILS as possible before merging;

• bumped up version number (name and head tables)
• regenerate METADATA.pb to be sure the files are in sync, eventually add Sorkin Type to the designers field + update categories (stroke=serif, category=display)
• Add outlines to the .notdef
• Update V-metrics: enabled bit 7, match typo metrics to current win/hhea metrics (1971, -589)
• update name ID13 to be "This Font Software is licensed under the SIL Open Font License, Version 1.1. This license is available with a FAQ at: https://scripts.sil.org/OFL"

[yanone]

Closing this because there's another PR that was made from a newly found source which should be used going forward.