-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Noto Sans Mongolian: Version 3.000; ttfautohint (v1.8.4.7-5d5b) added #6938
Conversation
FontBakery reportfontbakery version: 0.10.3 [1] Experimental checks🔥 FAIL: Shapes languages in all GF glyphsets. (com.google.fonts/check/glyphsets/shape_languages)
[1] Family checksℹ INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
[19] NotoSansMongolian-Regular.ttf🔥 FAIL: Check for METADATA subsets with zero support. (com.google.fonts/check/metadata/unsupported_subsets)
🔥 FAIL: Whitespace glyphs have ink? (com.google.fonts/check/whitespace_ink)
⚠ WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)
Or you can add the above codepoints to one of the subsets supported by the font: ⚠ WARN: On a family update, the DESCRIPTION.en_us.html file should ideally also be updated. (com.google.fonts/check/description/family_update)
⚠ WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
⚠ WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
⚠ WARN: Check if each glyph has the recommended amount of contours. (com.google.fonts/check/contour_count)
The following glyphs do not have the recommended number of contours:
[code: contour-count] ⚠ WARN: Check math signs have the same width. (com.google.fonts/check/math_signs_width)
Width = 322: ⚠ WARN: Check glyphs in mark glyph class are non-spacing. (com.google.fonts/check/gdef_spacing_marks)
⚠ WARN: Check mark characters are in GDEF mark glyph class. (com.google.fonts/check/gdef_mark_chars)
⚠ WARN: Are there any misaligned on-curve points? (com.google.fonts/check/outline_alignment_miss)
Use -F or --full-lists to disable shortening of long lists. [code: found-misalignments] ⚠ WARN: Are any segments inordinately short? (com.google.fonts/check/outline_short_segments)
Use -F or --full-lists to disable shortening of long lists. [code: found-short-segments] ⚠ WARN: Do any segments have colinear vectors? (com.google.fonts/check/outline_colinear_vectors)
ℹ INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
ℹ INFO: EPAR table present in font? (com.google.fonts/check/epar)
ℹ INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
PPM <= 65535: ℹ INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
ℹ INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
ℹ INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
Summary
Note: The following loglevels were omitted in this report:
|
I didn't put it there,
These glyphs are used for Mongolian shaping, and will be substituted. Please leave as they are.
There are some real problems here. We will need to add MVS4 to the Mongolian definition, and I'll manually add chinese-simplified to the METADATA.pb. |
FontBakery reportfontbakery version: 0.10.3 [1] Experimental checks🔥 FAIL: Shapes languages in all GF glyphsets. (com.google.fonts/check/glyphsets/shape_languages)
[1] Family checksℹ INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
[19] NotoSansMongolian-Regular.ttf🔥 FAIL: Check METADATA.pb includes production subsets. (com.google.fonts/check/metadata/includes_production_subsets)
🔥 FAIL: Whitespace glyphs have ink? (com.google.fonts/check/whitespace_ink)
⚠ WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)
Or you can add the above codepoints to one of the subsets supported by the font: ⚠ WARN: On a family update, the DESCRIPTION.en_us.html file should ideally also be updated. (com.google.fonts/check/description/family_update)
⚠ WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
⚠ WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
⚠ WARN: Check if each glyph has the recommended amount of contours. (com.google.fonts/check/contour_count)
The following glyphs do not have the recommended number of contours:
[code: contour-count] ⚠ WARN: Check math signs have the same width. (com.google.fonts/check/math_signs_width)
Width = 322: ⚠ WARN: Check glyphs in mark glyph class are non-spacing. (com.google.fonts/check/gdef_spacing_marks)
⚠ WARN: Check mark characters are in GDEF mark glyph class. (com.google.fonts/check/gdef_mark_chars)
⚠ WARN: Are there any misaligned on-curve points? (com.google.fonts/check/outline_alignment_miss)
Use -F or --full-lists to disable shortening of long lists. [code: found-misalignments] ⚠ WARN: Are any segments inordinately short? (com.google.fonts/check/outline_short_segments)
Use -F or --full-lists to disable shortening of long lists. [code: found-short-segments] ⚠ WARN: Do any segments have colinear vectors? (com.google.fonts/check/outline_colinear_vectors)
ℹ INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
ℹ INFO: EPAR table present in font? (com.google.fonts/check/epar)
ℹ INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
PPM <= 65535: ℹ INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
ℹ INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
ℹ INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
Summary
Note: The following loglevels were omitted in this report:
|
…1.8.4.7-5d5b) added * Noto Sans Mongolian Version 3.001; ttfautohint (v1.8.4.7-5d5b) taken from the upstream repo https://github.com/notofonts/mongolian.git at commit https://github.com/notofonts/mongolian/commit/.
Updated Noto Sans Mongolian: Version 3.001; ttfautohint (v1.8.4.7-5d5b) added004ff44: [gftools-packager] Noto Sans Mongolian: Version 3.001; ttfautohint (v1.8.4.7-5d5b) added
|
72fa562
to
004ff44
Compare
FontBakery reportfontbakery version: 0.10.3 [1] Experimental checks🔥 FAIL: Shapes languages in all GF glyphsets. (com.google.fonts/check/glyphsets/shape_languages)
[1] Family checksℹ INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
[18] NotoSansMongolian-Regular.ttf🔥 FAIL: Whitespace glyphs have ink? (com.google.fonts/check/whitespace_ink)
🔥 FAIL: Check that legacy accents aren't used in composite glyphs. (derived from com.google.fonts/check/legacy_accents) (com.google.fonts/check/legacy_accents)
⚠ WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)
Use -F or --full-lists to disable shortening of long lists. Or you can add the above codepoints to one of the subsets supported by the font: ⚠ WARN: On a family update, the DESCRIPTION.en_us.html file should ideally also be updated. (com.google.fonts/check/description/family_update)
⚠ WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
⚠ WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
⚠ WARN: Check if each glyph has the recommended amount of contours. (com.google.fonts/check/contour_count)
The following glyphs do not have the recommended number of contours:
[code: contour-count] ⚠ WARN: Check math signs have the same width. (com.google.fonts/check/math_signs_width)
Width = 322: ⚠ WARN: Check glyphs in mark glyph class are non-spacing. (com.google.fonts/check/gdef_spacing_marks)
⚠ WARN: Check mark characters are in GDEF mark glyph class. (com.google.fonts/check/gdef_mark_chars)
Use -F or --full-lists to disable shortening of long lists. [code: mark-chars] ⚠ WARN: Do any segments have colinear vectors? (com.google.fonts/check/outline_colinear_vectors)
⚠ WARN: Ensure soft_dotted characters lose their dot when combined with marks that replace the dot. (com.google.fonts/check/soft_dotted)
The dot of soft dotted characters should disappear in other cases, for example: ĩ̦ ĭ̦ i̦̇ i̦̊ i̦̋ ǐ̦ i̦̒ ĩ̧ ĭ̧ i̧̇ i̧̊ i̧̋ ǐ̧ i̧̒ j̦̀ j̦́ ĵ̦ j̦̃ j̦̄ j̦̆ Your font fully covers the following languages that require the soft-dotted feature: Lithuanian (Latn, 2,357,094 speakers). Your font does not cover the following languages that require the soft-dotted feature: Lugbara (Latn, 2,200,000 speakers), Igbo (Latn, 27,823,640 speakers), Kom (Latn, 360,685 speakers), Avokaya (Latn, 100,000 speakers), Dan (Latn, 1,099,244 speakers), Belarusian (Cyrl, 10,064,517 speakers), Aghem (Latn, 38,843 speakers), Ejagham (Latn, 120,000 speakers), Basaa (Latn, 332,940 speakers), Navajo (Latn, 166,319 speakers), Nateni (Latn, 100,000 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Ebira (Latn, 2,200,000 speakers), Dutch (Latn, 31,709,104 speakers), Ma’di (Latn, 584,000 speakers), Koonzime (Latn, 40,000 speakers). [code: soft-dotted] ℹ INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
ℹ INFO: EPAR table present in font? (com.google.fonts/check/epar)
ℹ INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
PPM <= 65535: ℹ INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
ℹ INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
ℹ INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
Summary
Note: The following loglevels were omitted in this report:
|
Latin Kernel -> Latin Core. Should be good now. |
Grr. This check is not relevant, and so is confusing. It is only relevant to precomposed mark glyphs. It checks that a precomposed letter like e.g. I'll check why Vietnamese is not working, but as this is only a Latin Core glyphset I don't think Vietnamese support is in scope anyway. |
Vietnamese is not expected to work here. @simoncozens Do we need to wait for the subset to include the missing mongolian codepoint in the glyphsets repo? |
I've added chinese-simplified. We do need Mongolian FVS4 added to the subset - eng team to merge googlefonts/glyphsets#143 and update internally. |
FontBakery reportfontbakery version: 0.10.3 [1] Experimental checks🔥 FAIL: Shapes languages in all GF glyphsets. (com.google.fonts/check/glyphsets/shape_languages)
[1] Family checksℹ INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
[18] NotoSansMongolian-Regular.ttf🔥 FAIL: Whitespace glyphs have ink? (com.google.fonts/check/whitespace_ink)
🔥 FAIL: Check that legacy accents aren't used in composite glyphs. (derived from com.google.fonts/check/legacy_accents) (com.google.fonts/check/legacy_accents)
⚠ WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)
Use -F or --full-lists to disable shortening of long lists. Or you can add the above codepoints to one of the subsets supported by the font: ⚠ WARN: On a family update, the DESCRIPTION.en_us.html file should ideally also be updated. (com.google.fonts/check/description/family_update)
⚠ WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
⚠ WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
⚠ WARN: Check if each glyph has the recommended amount of contours. (com.google.fonts/check/contour_count)
The following glyphs do not have the recommended number of contours:
[code: contour-count] ⚠ WARN: Check math signs have the same width. (com.google.fonts/check/math_signs_width)
Width = 322: ⚠ WARN: Check glyphs in mark glyph class are non-spacing. (com.google.fonts/check/gdef_spacing_marks)
⚠ WARN: Check mark characters are in GDEF mark glyph class. (com.google.fonts/check/gdef_mark_chars)
Use -F or --full-lists to disable shortening of long lists. [code: mark-chars] ⚠ WARN: Do any segments have colinear vectors? (com.google.fonts/check/outline_colinear_vectors)
⚠ WARN: Ensure soft_dotted characters lose their dot when combined with marks that replace the dot. (com.google.fonts/check/soft_dotted)
The dot of soft dotted characters should disappear in other cases, for example: ĩ̦ ĭ̦ i̦̇ i̦̊ i̦̋ ǐ̦ i̦̒ ĩ̧ ĭ̧ i̧̇ i̧̊ i̧̋ ǐ̧ i̧̒ j̦̀ j̦́ ĵ̦ j̦̃ j̦̄ j̦̆ Your font fully covers the following languages that require the soft-dotted feature: Lithuanian (Latn, 2,357,094 speakers). Your font does not cover the following languages that require the soft-dotted feature: Navajo (Latn, 166,319 speakers), Lugbara (Latn, 2,200,000 speakers), Igbo (Latn, 27,823,640 speakers), Belarusian (Cyrl, 10,064,517 speakers), Dutch (Latn, 31,709,104 speakers), Ejagham (Latn, 120,000 speakers), Nateni (Latn, 100,000 speakers), Basaa (Latn, 332,940 speakers), Aghem (Latn, 38,843 speakers), Kom (Latn, 360,685 speakers), Avokaya (Latn, 100,000 speakers), Dan (Latn, 1,099,244 speakers), Ma’di (Latn, 584,000 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Koonzime (Latn, 40,000 speakers), Ebira (Latn, 2,200,000 speakers). [code: soft-dotted] ℹ INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
ℹ INFO: EPAR table present in font? (com.google.fonts/check/epar)
ℹ INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
PPM <= 65535: ℹ INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
ℹ INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
ℹ INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
Summary
Note: The following loglevels were omitted in this report:
|
ed1b187: [gftools-packager] Noto Sans Mongolian: Version 3.000; ttfautohint (v1.8.4.7-5d5b) added