Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why does Noto Sans Mongolian claim chinese-simplified support? #7022

Closed
rsheeter opened this issue Nov 28, 2023 · 6 comments · Fixed by #7472
Closed

Why does Noto Sans Mongolian claim chinese-simplified support? #7022

rsheeter opened this issue Nov 28, 2023 · 6 comments · Fixed by #7472
Assignees
Labels
I API / Website / Platform fonts.google.com related stuff
Milestone

Comments

@rsheeter
Copy link
Collaborator

#6938 (comment) says it's being done but not why.

@eliheuer
Copy link
Collaborator

There is a bit of explanation in a previous comment, but still unclear to me what the rationale is: #6938 (comment)

@simoncozens
Copy link
Collaborator

Reading the appropriate Fontbakery warn, it seems to be so that we get CJK fullwidth punctuation in the font. I hadn't realised that adding subset definitions to the metadata.pb also affects the categorisation. In which case, we should change the fontbakery message; the suggestion of adding a new subset is not the way to resolve missing codepoints, they should instead be added to a nam file already declared by the font.

@chrissimpkins
Copy link
Collaborator

Is there anything to do here? If not, ok to close?

@chrissimpkins chrissimpkins removed this from the 2023 Q4 milestone Jan 2, 2024
@simoncozens
Copy link
Collaborator

Yes, I should add CJK fullwidth punctuation to the Mongolian subset in glyphsets and remove chinese-simplified from the subsets in METADATA.pb. I also want to clarify that fontbakery warning.

@simoncozens
Copy link
Collaborator

(I will do this after we've moved the glyphsets to the nam-files repo, or else it will probably get lost in the move.)

@chrissimpkins chrissimpkins added this to the 2024 Q1 milestone Jan 10, 2024
@github-project-automation github-project-automation bot moved this from Todo to In Dev / PR Merged in Google Fonts Mar 28, 2024
@EbenSorkin
Copy link
Collaborator

EbenSorkin commented Mar 28, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I API / Website / Platform fonts.google.com related stuff
Projects
Status: In Dev / PR Merged
Development

Successfully merging a pull request may close this issue.

6 participants