Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hedvig Letters Serif: Version 1.000 added #6897

Merged
merged 3 commits into from
Oct 25, 2023

Conversation

RosaWagner
Copy link
Contributor

c65d9f3: [gftools-packager] Hedvig Letters Serif: Version 1.000 added

dc009e8: Hedvig Letters Serif: added description

@github-actions

This comment was marked as outdated.

@RosaWagner RosaWagner linked an issue Oct 24, 2023 that may be closed by this pull request
9 tasks
@RosaWagner
Copy link
Contributor Author

RosaWagner commented Oct 24, 2023

🔥 FAIL: METADATA.pb font.name field contains font name in right format? (com.google.fonts/check/metadata/valid_name_values)
🔥 FAIL METADATA.pb font.name field ("Hedvig Letters Serif") does not match correct font name format ("Hedvig Letters Serif 24pt"). [code: mismatch]

Bug reported in fonttools/fontbakery#4262

🔥 FAIL: Check a font's STAT table contains compulsory Axis Values. (com.google.fonts/check/STAT)

Bug reported in googlefonts/axisregistry#99 (comment)

🔥 FAIL: Validates that when an instance record is included for the default instance, its subfamilyNameID value is set to a name ID whose string is equal to the string of either name ID 2 or 17, and its postScriptNameID value is set to a name ID whose string is equal to the string of name ID 6. (com.adobe.fonts/check/varfont/valid_default_instance_nameids)

Doesn't apply for Google Fonts's fonts with opsz axis because we expect the style name to reflect the origin (here 24pt Regular), but the style is only "Regular" in the FVAR table. This is the only exception we have for this Fail I think. I didn't raise an issue in FB yet.

@vv-monsalve
Copy link
Collaborator

Please confirm about the following:

  • The font is missing Ldot ldot, minute and second.
    Screen Shot 2023-10-25 at 10 13 43
  • The current vertical metrics look a bit tight and will not leave too much space for further language support (e.g. Vietnamese).
    Screen Shot 2023-10-25 at 10 37 59

@RosaWagner
Copy link
Contributor Author

  • they have localised middle dot so Ldot codepoint not required
  • there is no requirement for minute and second yet in Latin Core so I didn't bother them with that
  • the vertical metrics are made for Hedvig company employees to be able to use the font in workspace according to their design spec without having to change any spacing parameter. The factor is a bit higher than 1.3 which is not so bad.

@github-actions
Copy link

FontBakery report

fontbakery version: 0.10.2

[1] Family checks
INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
  • INFO From a total of 1 font files, 0 of them (0.00%) lack a STAT table.

    And these are the most common STAT axis orderings:
    ('opsz-wght', 1) [code: summary]


[23] HedvigLettersSerif[opsz].ttf
🔥 FAIL: METADATA.pb font.name field contains font name in right format? (com.google.fonts/check/metadata/valid_name_values)
  • 🔥 FAIL METADATA.pb font.name field ("Hedvig Letters Serif") does not match correct font name format ("Hedvig Letters Serif 24pt"). [code: mismatch]
🔥 FAIL: Check a font's STAT table contains compulsory Axis Values. (com.google.fonts/check/STAT)
  • 🔥 FAIL Compulsory STAT Axis Values are incorrect:
Name Axis Current Value Current Flags Current LinkedValue Expected Value Expected Flags Expected LinkedValue
Regular wght 400.0 2 None 400.0 0 700.0
[code: bad-axis-values]
🔥 FAIL: Validates that when an instance record is included for the default instance, its subfamilyNameID value is set to a name ID whose string is equal to the string of either name ID 2 or 17, and its postScriptNameID value is set to a name ID whose string is equal to the string of name ID 6. (com.adobe.fonts/check/varfont/valid_default_instance_nameids)
  • 🔥 FAIL 'Regular' instance has the same coordinates as the default instance; its subfamily name should be '24pt Regular' [code: invalid-default-instance-subfamily-name]
WARN: DESCRIPTION.en_us.html should end in a linebreak. (com.google.fonts/check/description/eof_linebreak)
  • WARN The last characther on DESCRIPTION.en_us.html is not a line-break. Please add it. [code: missing-eof-linebreak]
WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)
  • WARN The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02C7 CARON: try adding one of: yi, tifinagh, canadian-aboriginal

  • U+02D8 BREVE: try adding one of: yi, canadian-aboriginal

  • U+02D9 DOT ABOVE: try adding one of: yi, canadian-aboriginal

  • U+02DB OGONEK: try adding one of: yi, canadian-aboriginal

  • U+02DD DOUBLE ACUTE ACCENT: not included in any glyphset definition

  • U+0306 COMBINING BREVE: try adding one of: tifinagh, old-permic

  • U+030A COMBINING RING ABOVE: try adding syriac

  • U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: osage, cherokee

  • U+030C COMBINING CARON: try adding one of: tai-le, cherokee

  • U+0312 COMBINING TURNED COMMA ABOVE: not included in any glyphset definition
    33 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: latin, latin-ext, math, menu, symbols [code: unreachable-subsetting]

WARN: Are there caret positions declared for every ligature? (com.google.fonts/check/ligature_carets)
  • WARN This font lacks caret positioning values for these ligature glyphs:

    • arrowleft
    • arrowright

    [code: incomplete-caret-pos-data]

WARN: Is there kerning info for non-ligated sequences? (com.google.fonts/check/kerning_for_non_ligated_sequences)
  • WARN GPOS table lacks kerning info for the following non-ligated sequences:

    • f + f

    • f + i

    • i + b

    • b + f

    • f + h

    • h + i

    • i + k

    • k + l

    • l + t

    • t + t

    • hyphen + greater

    • less + hyphen [code: lacks-kern-info]

WARN: Combined length of family and style must not exceed 27 characters. (com.google.fonts/check/name/family_and_style_max_length)
  • WARN The combined length of family and style exceeds 27 chars in the following 'WINDOWS' entries:
    FONT_FAMILY_NAME = 'Hedvig Letters Serif 24pt' / SUBFAMILY_NAME = 'Regular'

Please take a look at the conversation at fonttools/fontbakery#2179 in order to understand the reasoning behind these name table records max-length criteria. [code: too-long]

WARN: METADATA.pb: Designers are listed correctly on the Google Fonts catalog? (com.google.fonts/check/metadata/designer_profiles)
  • WARN It seems that Kanon Foundry is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry. [code: profile-not-found]
  • WARN It seems that Alexander Örn is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry. [code: profile-not-found]
  • WARN It seems that Tor Weibull is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry. [code: profile-not-found]
WARN: Ensure variable fonts include an avar table. (com.google.fonts/check/mandatory_avar_table)
  • WARN This variable font does not have an avar table. [code: missing-avar]
WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
  • WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
WARN: Detect any interpolation issues in the font. (com.google.fonts/check/interpolation_issues)
  • WARN Interpolation issues were found in the font:

    • Contour order differs in glyph 'f_f': [0, 1] in <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f62fbdf1c60>, [1, 0] in <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f62fbdf1f30>. [code: interpolation-issues]
WARN: Check accent of Lcaron, dcaron, lcaron, tcaron (derived from com.google.fonts/check/alt_caron) (com.google.fonts/check/alt_caron)
  • WARN Lcaron is decomposed and therefore could not be checked. Please check manually. [code: decomposed-outline]
  • WARN dcaron is decomposed and therefore could not be checked. Please check manually. [code: decomposed-outline]
  • WARN lcaron is decomposed and therefore could not be checked. Please check manually. [code: decomposed-outline]
  • WARN tcaron is decomposed and therefore could not be checked. Please check manually. [code: decomposed-outline]
WARN: The variable font 'opsz' (Optical Size) axis coordinate should be between 10 and 16 on the 'Regular' instance. (com.google.fonts/check/varfont/regular_opsz_coord)
  • WARN The "opsz" (Optical Size) coordinate on the "Regular" instance is recommended to be a value in the range 10 to 16. Got 24.0 instead. [code: opsz-out-of-range]
WARN: Ensure dotted circle glyph is present and can attach marks. (com.google.fonts/check/dotted_circle)
  • WARN No dotted circle glyph present [code: missing-dotted-circle]
WARN: Ensure soft_dotted characters lose their dot when combined with marks that replace the dot. (com.google.fonts/check/soft_dotted)
  • WARN The dot of soft dotted characters used in orthographies must disappear in the following strings: į̀ į́ į̂ į̃ į̄ į̌

The dot of soft dotted characters should disappear in other cases, for example: į̆ į̇ į̈ į̊ į̋ į̒ į̦̀ į̦́ į̦̂ į̦̃ į̦̄ į̦̆ į̦̇ į̦̈ į̦̊ į̦̋ į̦̌ į̦̒ į̧̀ į̧́

Your font fully covers the following languages that require the soft-dotted feature: Lithuanian (Latn, 2,357,094 speakers), Dutch (Latn, 31,709,104 speakers).

Your font does not cover the following languages that require the soft-dotted feature: Nateni (Latn, 100,000 speakers), Avokaya (Latn, 100,000 speakers), Dan (Latn, 1,099,244 speakers), Ma’di (Latn, 584,000 speakers), Koonzime (Latn, 40,000 speakers), Basaa (Latn, 332,940 speakers), Aghem (Latn, 38,843 speakers), Kom (Latn, 360,685 speakers), Lugbara (Latn, 2,200,000 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Ejagham (Latn, 120,000 speakers), Igbo (Latn, 27,823,640 speakers), Navajo (Latn, 166,319 speakers), Belarusian (Cyrl, 10,064,517 speakers), Ebira (Latn, 2,200,000 speakers). [code: soft-dotted]

INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
  • INFO Hinting filesize impact:
ofl/hedviglettersserif/HedvigLettersSerif[opsz].ttf
Dehinted Size 119.9kb
Hinted Size 119.9kb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
INFO: Font has old ttfautohint applied? (com.google.fonts/check/old_ttfautohint)
  • INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 1.000'] [code: version-not-detected]
INFO: EPAR table present in font? (com.google.fonts/check/epar)
INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
  • INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
  • INFO Version string is: "Version 1.000"
    The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
    "Version 1.3; git-0d08353-release" [code: bad-format]
INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
  • INFO This font contains the following optional tables:

    • loca

    • prep

    • GPOS

    • GSUB

    • gasp [code: optional-tables]

INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
  • INFO ofl/hedviglettersserif [code: family-path]

Summary

💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 3 13 50 8 180 0
0% 1% 5% 20% 3% 71% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@vv-monsalve vv-monsalve merged commit eb1b603 into main Oct 25, 2023
9 checks passed
@vv-monsalve vv-monsalve deleted the gftools_packager_ofl_hedviglettersserif branch October 25, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Live
Development

Successfully merging this pull request may close these issues.

Add Hedvig Letters
2 participants