Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hedvig Letters Sans: Version 1.000; ttfautohint (v1.8.4.7-5d5b) added #6896

Merged
merged 2 commits into from
Oct 25, 2023

Conversation

RosaWagner
Copy link
Contributor

c8dfe32: [gftools-packager] Hedvig Letters Sans: Version 1.000; ttfautohint (v1.8.4.7-5d5b) added

723b70b: Hedvig Letters Sans: added description

@github-actions
Copy link

FontBakery report

fontbakery version: 0.10.2

[1] Family checks
INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
  • INFO From a total of 1 font files, 1 of them (100.00%) lack a STAT table.

    And these are the most common STAT axis orderings:
    [code: summary]


[20] HedvigLettersSans-Regular.ttf
🔥 FAIL: Does DESCRIPTION file contain broken links? (com.google.fonts/check/description/broken_links)
WARN: DESCRIPTION.en_us.html should end in a linebreak. (com.google.fonts/check/description/eof_linebreak)
  • WARN The last characther on DESCRIPTION.en_us.html is not a line-break. Please add it. [code: missing-eof-linebreak]
WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)
  • WARN The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02C7 CARON: try adding one of: yi, tifinagh, canadian-aboriginal

  • U+02D8 BREVE: try adding one of: yi, canadian-aboriginal

  • U+02D9 DOT ABOVE: try adding one of: yi, canadian-aboriginal

  • U+02DB OGONEK: try adding one of: yi, canadian-aboriginal

  • U+02DD DOUBLE ACUTE ACCENT: not included in any glyphset definition

  • U+0306 COMBINING BREVE: try adding one of: old-permic, tifinagh

  • U+030A COMBINING RING ABOVE: try adding syriac

  • U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: osage, cherokee

  • U+030C COMBINING CARON: try adding one of: tai-le, cherokee

  • U+0312 COMBINING TURNED COMMA ABOVE: not included in any glyphset definition
    33 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: latin, latin-ext, math, menu, symbols [code: unreachable-subsetting]

WARN: Are there caret positions declared for every ligature? (com.google.fonts/check/ligature_carets)
  • WARN This font lacks caret positioning values for these ligature glyphs:

    • arrowleft
    • arrowright

    [code: incomplete-caret-pos-data]

WARN: Is there kerning info for non-ligated sequences? (com.google.fonts/check/kerning_for_non_ligated_sequences)
  • WARN GPOS table lacks kerning info for the following non-ligated sequences:

    • f + f

    • f + i

    • i + b

    • b + f

    • f + h

    • h + i

    • i + k

    • k + l

    • l + t

    • t + t

    • hyphen + greater

    • less + hyphen [code: lacks-kern-info]

WARN: METADATA.pb: Designers are listed correctly on the Google Fonts catalog? (com.google.fonts/check/metadata/designer_profiles)
  • WARN It seems that Kanon Foundry is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry. [code: profile-not-found]
  • WARN It seems that Alexander Örn is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry. [code: profile-not-found]
  • WARN It seems that Tor Weibull is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry. [code: profile-not-found]
WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
  • WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
WARN: Check if each glyph has the recommended amount of contours. (com.google.fonts/check/contour_count)
  • WARN This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct.

The following glyphs do not have the recommended number of contours:

- Glyph name: aogonek	Contours detected: 3	Expected: 2

- Glyph name: eogonek	Contours detected: 3	Expected: 2

- Glyph name: Uogonek	Contours detected: 2	Expected: 1

- Glyph name: uogonek	Contours detected: 2	Expected: 1

- Glyph name: Uogonek	Contours detected: 2	Expected: 1

- Glyph name: aogonek	Contours detected: 3	Expected: 2

- Glyph name: eogonek	Contours detected: 3	Expected: 2

- Glyph name: uogonek	Contours detected: 2	Expected: 1

[code: contour-count]

WARN: Check accent of Lcaron, dcaron, lcaron, tcaron (derived from com.google.fonts/check/alt_caron) (com.google.fonts/check/alt_caron)
  • WARN Lcaron is decomposed and therefore could not be checked. Please check manually. [code: decomposed-outline]
  • WARN dcaron is decomposed and therefore could not be checked. Please check manually. [code: decomposed-outline]
  • WARN lcaron is decomposed and therefore could not be checked. Please check manually. [code: decomposed-outline]
  • WARN tcaron is decomposed and therefore could not be checked. Please check manually. [code: decomposed-outline]
WARN: Are there any misaligned on-curve points? (com.google.fonts/check/outline_alignment_miss)
  • WARN The following glyphs have on-curve points which have potentially incorrect y coordinates:

    • Q (U+0051): X=563.0,Y=-1.5 (should be at baseline 0?)

    • bracketleft (U+005B): X=281.0,Y=698.0 (should be at cap-height 700?)

    • bracketleft (U+005B): X=174.0,Y=698.0 (should be at cap-height 700?)

    • bracketright (U+005D): X=132.0,Y=698.0 (should be at cap-height 700?)

    • bracketright (U+005D): X=25.0,Y=698.0 (should be at cap-height 700?)

    • braceleft (U+007B): X=337.0,Y=698.0 (should be at cap-height 700?)

    • braceright (U+007D): X=23.0,Y=698.0 (should be at cap-height 700?)

    • macron (U+00AF): X=180.0,Y=701.0 (should be at cap-height 700?)

    • macron (U+00AF): X=458.0,Y=701.0 (should be at cap-height 700?)

    • Oslash (U+00D8): X=463.0,Y=701.0 (should be at cap-height 700?)

    • 30 more.

Use -F or --full-lists to disable shortening of long lists. [code: found-misalignments]

WARN: Are any segments inordinately short? (com.google.fonts/check/outline_short_segments)
  • WARN The following glyphs have segments which seem very short:

    • six (U+0036) contains a short segment L<<441.0,523.0>--<441.0,533.0>>

    • nine (U+0039) contains a short segment L<<149.0,177.0>--<149.0,167.0>>

    • at (U+0040) contains a short segment B<<666.0,150.0>-<666.0,128.0>-<678.0,115.5>>

    • paragraph (U+00B6) contains a short segment L<<251.0,321.0>--<226.0,321.0>>

    • germandbls (U+00DF) contains a short segment L<<117.0,520.0>--<117.0,534.0>>

    • Eng (U+014A) contains a short segment B<<550.5,-173.0>-<565.0,-169.0>-<571.5,-153.5>>

    • uni0162 (U+0162) contains a short segment L<<277.0,-70.0>--<285.0,-70.0>> [code: found-short-segments]

WARN: Ensure dotted circle glyph is present and can attach marks. (com.google.fonts/check/dotted_circle)
  • WARN No dotted circle glyph present [code: missing-dotted-circle]
WARN: Ensure soft_dotted characters lose their dot when combined with marks that replace the dot. (com.google.fonts/check/soft_dotted)
  • WARN The dot of soft dotted characters used in orthographies must disappear in the following strings: į̀ į́ į̂ į̃ į̄ į̌

The dot of soft dotted characters should disappear in other cases, for example: į̆ į̇ į̈ į̊ į̋ į̒ į̦̀ į̦́ į̦̂ į̦̃ į̦̄ į̦̆ į̦̇ į̦̈ į̦̊ į̦̋ į̦̌ į̦̒ į̧̀ į̧́

Your font fully covers the following languages that require the soft-dotted feature: Dutch (Latn, 31,709,104 speakers), Lithuanian (Latn, 2,357,094 speakers).

Your font does not cover the following languages that require the soft-dotted feature: Kom (Latn, 360,685 speakers), Ejagham (Latn, 120,000 speakers), Nateni (Latn, 100,000 speakers), Ma’di (Latn, 584,000 speakers), Aghem (Latn, 38,843 speakers), Ebira (Latn, 2,200,000 speakers), Navajo (Latn, 166,319 speakers), Avokaya (Latn, 100,000 speakers), Igbo (Latn, 27,823,640 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Dan (Latn, 1,099,244 speakers), Belarusian (Cyrl, 10,064,517 speakers), Basaa (Latn, 332,940 speakers), Lugbara (Latn, 2,200,000 speakers), Koonzime (Latn, 40,000 speakers). [code: soft-dotted]

INFO: Does DESCRIPTION file contain a upstream Git repo URL? (com.google.fonts/check/description/git_url)
INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
  • INFO Hinting filesize impact:
ofl/hedvigletterssans/HedvigLettersSans-Regular.ttf
Dehinted Size 59.0kb
Hinted Size 78.8kb
Increase 19.8kb
Change 33.5 %
[code: size-impact]
INFO: EPAR table present in font? (com.google.fonts/check/epar)
INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
  • INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
  • INFO Version string is: "Version 1.000; ttfautohint (v1.8.4.7-5d5b)"
    The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
    "Version 1.3; git-0d08353-release" [code: bad-format]
INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
  • INFO This font contains the following optional tables:

    • cvt

    • fpgm

    • loca

    • prep

    • GPOS

    • GSUB

    • gasp [code: optional-tables]

INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
  • INFO ofl/hedvigletterssans [code: family-path]

Summary

💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 1 12 64 8 169 0
0% 0% 5% 25% 3% 67% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@RosaWagner
Copy link
Contributor Author

🔥 FAIL: Does DESCRIPTION file contain broken links? (com.google.fonts/check/description/broken_links)
🔥 FAIL The following links are broken in the DESCRIPTION file:
https://fonts.google.com/specimen/Hedvig+Letters+Serif (status code: 404) [code: broken-links]

Links does not exists yet, will when #6897 is merged. We should remember to counter-check the link once in prod.

@RosaWagner RosaWagner linked an issue Oct 24, 2023 that may be closed by this pull request
9 tasks
@vv-monsalve
Copy link
Collaborator

Same as reported for the Serif font about missing glyphs and vertical metrics.

Screen Shot 2023-10-25 at 10 58 44

@vv-monsalve
Copy link
Collaborator

Taking the notes in the serif version as a confirmation to continue with this PR.

@vv-monsalve vv-monsalve merged commit 5043c7f into main Oct 25, 2023
@vv-monsalve vv-monsalve deleted the gftools_packager_ofl_hedvigletterssans branch October 25, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Live
Development

Successfully merging this pull request may close these issues.

Add Hedvig Letters
2 participants