Cloud Orchestrator can give hint to docker instances, that it's created by Cloud Orchestrator. #486
Conversation
0405ysj
requested review from
Databean,
adelva1984,
jemoreira,
jmacnak,
rmuthiah and
ser-io
as code owners
0405ysj
requested review from
ikicha and
k311093
and removed request for
Databean,
adelva1984,
jmacnak and
rmuthiah
| func (m *DockerInstanceManager) createDockerContainer(ctx context.Context, user accounts.User) (string, error) { | ||
| config := &container.Config{ | ||
| AttachStdin: true, | ||
| Env: []string{"HANDLED_BY_CLOUD_ORCHESTRATOR=true"}, |
There was a problem hiding this comment.
can you share the design doc for this? why is it needed? who is going to consume it?
There was a problem hiding this comment.
I can see you added b/383428636 in the PR's comments. Please add the bug to the commit message itself next time.
There was a problem hiding this comment.
What this env variable has to do with enabling vhost-user-vsock?
There was a problem hiding this comment.
As I mentioned from the PR description, google/android-cuttlefish#1721 consumes it.
Also resolving this conversation, since I think google/android-cuttlefish#1721 should be the better place to talk.
There was a problem hiding this comment.
Oh I see, it's used in google/android-cuttlefish@d248bf8
Marking this as unresolved for now to avoid merging in this PR.
I'll follow up here, once discussion in google/android-cuttlefish#1721 is done.
| func (m *DockerInstanceManager) createDockerContainer(ctx context.Context, user accounts.User) (string, error) { | ||
| config := &container.Config{ | ||
| AttachStdin: true, | ||
| Env: []string{"HANDLED_BY_CLOUD_ORCHESTRATOR=true"}, |
There was a problem hiding this comment.
Oh I see, it's used in google/android-cuttlefish@d248bf8
Marking this as unresolved for now to avoid merging in this PR.
I'll follow up here, once discussion in google/android-cuttlefish#1721 is done.
3 participants
Context: b/383428636
This hint can be used by google/android-cuttlefish#1721.