Skip to content

Cloud Orchestrator can give hint to docker instances, that it's created by Cloud Orchestrator. #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
0405ysj wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Cloud Orchestrator can give hint to docker instances, that it's created by Cloud Orchestrator. #486

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkg/app/instances/docker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,6 +362,7 @@ func (m *DockerInstanceManager) createDockerVolumeIfNeeded(ctx context.Context,
func (m *DockerInstanceManager) createDockerContainer(ctx context.Context, user accounts.User) (string, error) {
config := &container.Config{
AttachStdin: true,
Env: []string{"HANDLED_BY_CLOUD_ORCHESTRATOR=true"},
Copy link
Member

@ser-io ser-io Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you share the design doc for this? why is it needed? who is going to consume it?

Copy link
Member

@ser-io ser-io Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see you added b/383428636 in the PR's comments. Please add the bug to the commit message itself next time.

Copy link
Member

@ser-io ser-io Oct 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What this env variable has to do with enabling vhost-user-vsock?

Copy link
Collaborator Author

@0405ysj 0405ysj Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I mentioned from the PR description, google/android-cuttlefish#1721 consumes it.

Also resolving this conversation, since I think google/android-cuttlefish#1721 should be the better place to talk.

Copy link
Member

@ser-io ser-io Oct 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see, it's used in google/android-cuttlefish@d248bf8

Marking this as unresolved for now to avoid merging in this PR.

I'll follow up here, once discussion in google/android-cuttlefish#1721 is done.

Image: m.Config.Docker.DockerImageName,
Tty: true,
Labels: dockerLabelsDict(user),
Expand Down
Loading