SCons: Expand NoCache coverage
#104320
Merged
SCons: Expand NoCache coverage
#104320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent cache CI changes have revealed that quite a few builds still have moderately sized caches for PRs, despite the fact that they should be stripping anything not on the default branch. One possible reason for this is how some commands/builds weren't using their
NoCacheequivalents, which is what this PR addresses. This could be expanded to applyingNoCacheto emitters in the future, removing the need for our custom functions entirely, but that's better suited for a separate PR