Add const iteration support to Dictionary
#104047
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the assumption in #103999, we are able to bring
ConstIterator
toDictionary
without breaking theread_only
property. Since the innerHashMap
already has a nice iterator implementation, I just export it with alias to keep the change minimal.Main usecase of this is to replace
Dictionary::get_key_list()
. Previously if we want to iterate aDictionary
we have to write:This pattern includes unnecessary heap allocation (the
List
), redundant iteration (populate keys inget_key_list()
) and an extra hashmap lookup (if you need both key and value).With
ConstIterator
we can now write:No heap allocation, scan exactly one time and no hashmap lookup.
I measure performance diff between the two pattern with MRP from #100333 (Note this workload is constructed intentionally to be bottlenecked at
Dictionary
iteration,Dictionary
stringify would be a better showcase but unfortunately it is now bottlenecked byString
concat)Master:
This PR:
Callers who sort the key list or modify values in the loop are kept untouched.