Fix Embedded Game Window with user arguments #101739
Merged
+10
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruvzg
approved these changes
Jan 20, 2025
| } | ||
|
|
||
| E = N; | ||
| } | ||
|
|
||
| // Add the editor window's native ID so the started game can directly set it as its parent. | ||
| r_arguments.push_back("--wid"); | ||
| r_arguments.push_back(itos(DisplayServer::get_singleton()->window_get_native_handle(DisplayServer::WINDOW_HANDLE, get_window()->get_window_id()))); | ||
| List<String>::Element *N = r_arguments.insert_before(user_args_element, "--wid"); |
There was a problem hiding this comment.
Note: insert_before handle nullptr as push_back, so it's fine if it's not set.
There was a problem hiding this comment.
At first, I used a if(user_args_element) push_back else insert_before then I saw at insert_before handles nullptr as you said. Would it be preferable to manage the nullptr here?
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
main_run_argsand--. #101690This should fixes the user command line arguments when using
--or++.Tested with the issue MRP with and without the
--.