Style: Integrate new #pragma once syntax
#10756
Open
+24
−79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Repiteo
added
enhancement
topic:codestyle
content:example code
Repiteo
force-pushed
the
style/pragma-once
branch
from
630da6f to
da33f97
Compare
tetrapod00
reviewed
Mar 10, 2025
Comment on lines
+97
to
+98
| ``#ifdef``-based include guards | ||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ |
There was a problem hiding this comment.
Suggested change
| ``#ifdef``-based include guards | |
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | |
| ``#ifndef``-based include guards | |
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ |
Comment on lines
+100
to
+102
| Starting with 4.5, all files now use the ``#pragma once`` directive, as they | ||
| improve readability and declutter macros. Use of ``#ifdef``-based include | ||
| guards are now actively discouraged. |
There was a problem hiding this comment.
Suggested change
| Starting with 4.5, all files now use the ``#pragma once`` directive, as they | |
| improve readability and declutter macros. Use of ``#ifdef``-based include | |
| guards are now actively discouraged. | |
| Starting with Godot 4.5, all files now use the ``#pragma once`` directive, as they | |
| improve readability and declutter macros. Use of ``#ifndef``-based include | |
| guards are now actively discouraged. |
Both suggestions optional.
These are technically ifndef-based not ifdef-based, right? But maybe calling them colloquially "ifdef-based" still makes sense?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#pragma oncegodot#102298With
#pragma oncebeing the new stylistic syntax utilized in the main repo, this aims to update the docs to reflect that