Skip to content

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Jun 25, 2025

Demonstrate first person shooter and third person shooter cameras.

This salvages @lawnjelly's work on the demo and further refines it.

Preview

image

@lawnjelly
Copy link
Member

This is great! 🥳

I've added a bunch more comments and made some variable names clearer, hopefully you can copy the gdscript from:
#1220

I also discovered a bug in the SceneTreeFTI for toggling interpolation on / off 😊 , but have made a small fix PR so hopefully that will be closed for 4.5.

@Calinou Calinou force-pushed the add-3d-physics-interpolation-demo branch from caafd6a to 60d132a Compare June 30, 2025 15:21
@Calinou
Copy link
Member Author

Calinou commented Jun 30, 2025

I've added a bunch more comments and made some variable names clearer, hopefully you can copy the gdscript from:
#1220

Done. Note that I've refactored bullet.gd to use built-in Godot functionality whenever possible, which makes the script a fair bit shorter. I've also removed the scale clamping, as current Godot should have no problems with zero-scaled meshes.

@lawnjelly
Copy link
Member

Done. Note that I've refactored bullet.gd to use built-in Godot functionality whenever possible, which makes the script a fair bit shorter.

I'm sure that will be fine, the bullet isn't super important.

(I personally don't tend to use or recommend using Timer nodes as I don't find them a good approach to game timing imo, as they aren't accurate for tick based stuff, and can lead to order of operations bugs. But maybe users like them. 😁 )

Copy link
Member

@aaronfranke aaronfranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Style nitpicks are all I had to say about it (there are more instances than just the one I mentioned, including a boolean one). Merge whenever you'd like, preferably after fixing the style issues but those could be fixed later ¯\_(ツ)_/¯

Demonstrate first person shooter and third person shooter cameras.
@Calinou Calinou force-pushed the add-3d-physics-interpolation-demo branch from 8b4596c to c70741b Compare September 30, 2025 16:14
@aaronfranke aaronfranke merged commit 49718c4 into godotengine:master Sep 30, 2025
1 check passed
@Calinou Calinou deleted the add-3d-physics-interpolation-demo branch September 30, 2025 16:50
@aaronfranke aaronfranke added this to the 4.5 milestone Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants