Skip to content

Conversation

lawnjelly
Copy link
Member

Removes any dangling objects when toggling set_enabled() for SceneTreeFTI.
These could cause crashes / errors if deleted between toggling the setting.

Backport of #108131

MRP

(in 4.x, but same bug in 3.x)
Run godotengine/godot-demo-projects#1223 and keep toggling physics interpolation by pressing T while firing.. the DEV_ASSERT() will hit.

Notes

  • Sorry my bad, I forgot to clear these completely when adding more lists.
  • Should be very safe.

@lawnjelly lawnjelly added this to the 3.7 milestone Jun 30, 2025
@lawnjelly lawnjelly requested a review from a team as a code owner June 30, 2025 07:18
@lawnjelly lawnjelly requested a review from Calinou July 1, 2025 16:46
Copy link
Member

@rburing rburing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes total sense.

@lawnjelly lawnjelly merged commit 67ef412 into godotengine:3.x Jul 1, 2025
14 checks passed
@lawnjelly lawnjelly deleted the fti_clear_all3 branch July 1, 2025 17:22
@lawnjelly
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants