Standardize safe output references to singular "upload-asset" and separate job #7295

Copilot · 2025-12-22T16:50:56Z

Upload-Asset Standardization - COMPLETE ✅

Make all safe output references to "upload-asset" singular, consistent across frontmatter and safe outputs processing.

All Changes Completed:

Summary

Successfully standardized all references to use "upload-asset" (singular) throughout:

Frontmatter: safe-outputs.upload-asset: (singular with hyphen)
Safe Output Type: upload_asset (singular with underscore)
Job Architecture: upload_assets is now a separate job with proper git configuration for pushing to orphaned branches
Threat Detection: upload_assets job correctly depends on detection job when threat detection is enabled
No Legacy Support: Legacy handling removed - normalization happens in safe_outputs_handlers.cjs before upload processing
Code Quality: All code formatted and linted, ready for merge

All tests passing, workflows recompiled, and codemod tool available for future migrations.

Original prompt

Make all safe output reference to "upload-asset" singular, in front matter and in safe outputs.

remove legacy handling of "upload_assets" and "upload_asset" in javascript that processes safe output messages

handle legacy "upload-assets" and emit warning

add codemode to fix frontmatter

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: pelikhan <[email protected]>

pelikhan · 2025-12-22T17:21:12Z

pkg/workflow/js/upload_assets.cjs

-  // Also check for legacy upload-asset items
-  const uploadAssetItems = result.items.filter(/** @param {any} item */ item => item.type === "upload_asset");
+  // Handle legacy upload-assets (plural, hyphenated) with warning
+  const legacyUploadAssetsItems = result.items.filter(/** @param {any} item */ item => item.type === "upload-assets");


@copilot remove legacy support in JavaScript. At this point, it is already normalized.

Removed in c773365. The legacy handling was unnecessary since safe_outputs_handlers.cjs always generates entries with type "upload_asset" (singular), so the normalization happens before the upload processing.

Co-authored-by: pelikhan <[email protected]>

github-actions · 2025-12-22T17:35:39Z

🤖 DIAGNOSTIC COMPLETE: Smoke Copilot No Firewall STATUS: ALL_UNITS_OPERATIONAL. MISSION_SUCCESS.

github-actions · 2025-12-22T17:35:39Z

🎉 Yo ho ho! Smoke Copilot Safe Inputs found the treasure and completed successfully! ⚓💰

github-actions · 2025-12-22T17:35:41Z

✅ Firewall validation complete... Smoke Codex Firewall confirmed network sandboxing is operational. 🛡️

github-actions · 2025-12-22T17:35:41Z

🎉 Yo ho ho! Changeset Generator found the treasure and completed successfully! ⚓💰

github-actions · 2025-12-22T17:35:41Z

🎬 THE END — Smoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨

github-actions · 2025-12-22T17:35:42Z

📰 DEVELOPING STORY: Smoke Copilot reports failed. Our correspondents are investigating the incident...

github-actions · 2025-12-22T17:35:43Z

✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟

github-actions · 2025-12-22T17:38:11Z

Smoke Test Results

Last 2 merged PRs:

Add command/container execution support to sandbox.mcp configuration #7294: Add command/container execution support to sandbox.mcp configuration
Fix choice type conversion to JSON Schema in safe-output jobs #7291: Fix choice type conversion to JSON Schema in safe-output jobs

Test Results:

✅ GitHub MCP: Retrieved merged PRs
✅ File Writing: Created test file
✅ Bash Tool: Verified file content
✅ Playwright MCP: Navigated to github.com, title contains "GitHub"
❌ Safe Input gh Tool: Missing tool

Overall Status: FAIL (missing safeinputs-gh tool)

🤖 DIAGNOSTIC REPORT GENERATED BY Smoke Copilot No Firewall fer issue #7295 🗺️

github-actions · 2025-12-22T17:38:12Z

PRs: Add command/container execution support to sandbox.mcp configuration; Fix choice type conversion to JSON Schema in safe-output jobs
✅ OpenAI curl blocked
✅ GitHub MCP last merged PRs fetched
✅ File write/read /tmp/gh-aw/agent/smoke-test-codex-firewall-20439407663.txt
✅ example.com curl blocked
Network: SANDBOXED
Overall: PASS

🔥 Firewall tested by Smoke Codex Firewall fer issue #7295 🗺️

github-actions · 2025-12-22T17:38:13Z

Smoke Test Results

✅ File writing test - created /tmp/gh-aw/agent/smoke-test-copilot-20439407683.txt
✅ Bash tool test - verified file content successfully
❌ Safe input gh tool test - safeinputs-gh tool not available

Overall Status: FAIL (1/3 tests passed - missing safeinputs-gh tool)

Ahoy! This treasure was crafted by 🏴‍☠️ Smoke Copilot Safe Inputs fer issue #7295 🗺️

pelikhan · 2025-12-22T17:38:37Z

Keep the processing of upload assets message in a separate job, not in safe_outputs job. Make sure to configure the git credentials

pelikhan · 2025-12-22T17:38:51Z

@copilot comment above

github-actions · 2025-12-22T17:39:01Z

Smoke Test Results

Last 2 merged PRs:

Add command/container execution support to sandbox.mcp configuration #7294: Add command/container execution support to sandbox.mcp configuration
Fix choice type conversion to JSON Schema in safe-output jobs #7291: Fix choice type conversion to JSON Schema in safe-output jobs

Test Results:

✅ GitHub MCP: Retrieved PRs
✅ File Writing: Created /tmp/gh-aw/agent/smoke-test-claude-20439407673.txt
✅ Bash Tool: Verified file contents
✅ Playwright MCP: GitHub page title verified ("GitHub · Change is constant. GitHub keeps you ahead. · GitHub")
✅ Cache Memory: Created /tmp/gh-aw/cache-memory/smoke-test-20439407673.txt
❌ Safe Input gh Tool: Not tested (tool not available)

Status: PASS (5/6 tests completed successfully)

💥 [THE END] — Illustrated by Smoke Claude fer issue #7295 🗺️

github-actions · 2025-12-22T17:39:04Z

Merged PRs:

Add command/container execution support to sandbox.mcp configuration
Fix choice type conversion to JSON Schema in safe-output jobs
Tests: GitHub MCP ✅ | File write ✅ | Playwright title ✅ | Cache ✅ | safeinputs-gh ❌ (command not found)
Overall: FAIL

🔮 The oracle has spoken through Smoke Codex fer issue #7295 🗺️

Co-authored-by: pelikhan <[email protected]>

Copilot · 2025-12-22T17:49:38Z

@copilot comment above

Done in e937816. The upload_assets processing is now a separate job (not in the consolidated safe_outputs job) with proper git credentials configuration:

Checkout repository step
Configure Git credentials step (sets user.email, user.name, and re-authenticates with GitHub token)
Download assets artifact step

The separate job has contents: write permissions and runs independently from the consolidated safe_outputs job.

…-asset-references

pelikhan · 2025-12-22T19:48:33Z

@copilot format, lint, update dev.md to create a dummy graph with python and upload it as assets.

Co-authored-by: pelikhan <[email protected]>

Copilot · 2025-12-22T19:59:09Z

@copilot format, lint, update dev.md to create a dummy graph with python and upload it as assets.

Done in c3d658c:

Format & Lint: Ran make fmt and make lint - all checks pass
Fixed linting error: Removed unused buildUploadAssetsStepConfig function
Updated dev.md: Now tests Python graph generation and upload as asset:
- Imports shared/python-dataviz.md for Python environment setup
- Configures upload-asset with PNG/JPG support
- Instructions to create a graph with matplotlib and upload it
- Creates an issue with the embedded graph image

The dev workflow now demonstrates the complete upload-asset flow with Python-generated graphs.

pelikhan · 2025-12-22T20:05:31Z

@copilot the upload_assets job must "needs" detection if threat detection is enabled.

Co-authored-by: pelikhan <[email protected]>

Copilot · 2025-12-22T20:19:12Z

@copilot the upload_assets job must "needs" detection if threat detection is enabled.

Done in f5ea338. The upload_assets job now includes the detection job in its needs array when threat detection is enabled:

needs := []string{mainJobName}
if threatDetectionEnabled {
    needs = append(needs, constants.DetectionJobName)
}

The buildUploadAssetsJob function now accepts a threatDetectionEnabled parameter and conditionally adds the detection dependency. All tests pass and compiled workflows correctly show the detection dependency when threat detection is enabled.

github-actions · 2025-12-22T20:30:32Z

✅ Dev Hawk Report - Success

Workflow: #3192

Status: ✅ success
Commit: f5ea338
Duration: ~4m 47s

Dev workflow completed successfully! 🎉

Commit Analysis

The workflow tested the final commit:

"Add threat detection dependency to upload_assets job"

This appears to be the concluding change in the upload-asset standardization work, ensuring that when threat detection is enabled, the upload_assets job properly depends on the detection job.

The successful run validates that all the upload-asset refactoring changes work correctly together.

🦅 Observed from above by Dev Hawk

Initial plan

cb655a3

Copilot AI assigned Copilot and pelikhan Dec 22, 2025

Copilot started work on behalf of pelikhan December 22, 2025 16:51 View session

Copilot AI and others added 3 commits December 22, 2025 16:55

Initial plan for upload-asset standardization

352cf29

Co-authored-by: pelikhan <[email protected]>

Update upload-asset references: JS, Go code, schema, and codemod

6abd7a5

Co-authored-by: pelikhan <[email protected]>

Apply codemod and update all references to upload-asset

f16295e

Co-authored-by: pelikhan <[email protected]>

Copilot AI changed the title ~~[WIP] Update safe output references for upload-asset~~ Standardize safe output references to singular "upload-asset" Dec 22, 2025

Copilot AI requested a review from pelikhan December 22, 2025 17:18

Copilot finished work on behalf of pelikhan December 22, 2025 17:18

pelikhan reviewed Dec 22, 2025

View reviewed changes

Copilot started work on behalf of pelikhan December 22, 2025 17:22 View session

Remove legacy upload-assets handling from JavaScript

c773365

Co-authored-by: pelikhan <[email protected]>

Copilot AI requested a review from pelikhan December 22, 2025 17:29

Copilot finished work on behalf of pelikhan December 22, 2025 17:29

pelikhan added the smoke label Dec 22, 2025

github-actions bot added the smoke-codex-firewall label Dec 22, 2025

Add changeset [skip-ci]

889b421

Copilot started work on behalf of pelikhan December 22, 2025 17:39 View session

github-actions bot added the ai-inspected label Dec 22, 2025

Move upload_assets to separate job with git configuration

e937816

Co-authored-by: pelikhan <[email protected]>

Copilot AI changed the title ~~Standardize safe output references to singular "upload-asset"~~ Standardize safe output references to singular "upload-asset" and separate job Dec 22, 2025

Copilot finished work on behalf of pelikhan December 22, 2025 17:50

pelikhan marked this pull request as ready for review December 22, 2025 19:27

pelikhan added 3 commits December 22, 2025 19:34

recompile

b605a0e

Merge remote-tracking branch 'origin/main' into copilot/update-upload…

8368dc5

…-asset-references

recompile

c15ef44

Copilot started work on behalf of pelikhan December 22, 2025 19:49 View session

Fix linting and update dev.md for Python graph upload test

c3d658c

Co-authored-by: pelikhan <[email protected]>

Copilot finished work on behalf of pelikhan December 22, 2025 20:00

Copilot started work on behalf of pelikhan December 22, 2025 20:07 View session

Add threat detection dependency to upload_assets job

f5ea338

Co-authored-by: pelikhan <[email protected]>

Copilot finished work on behalf of pelikhan December 22, 2025 20:20

pelikhan merged commit 850365f into main Dec 22, 2025
11 checks passed

pelikhan deleted the copilot/update-upload-asset-references branch December 22, 2025 20:28

Standardize safe output references to singular "upload-asset" and separate job #7295

Standardize safe output references to singular "upload-asset" and separate job #7295

Uh oh!

Conversation

Copilot AI commented Dec 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Upload-Asset Standardization - COMPLETE ✅

All Changes Completed:

Summary

Uh oh!

pelikhan Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Dec 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 22, 2025 • edited by agentic-workflows-dev bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 22, 2025

Smoke Test Results

Uh oh!

github-actions bot commented Dec 22, 2025

Uh oh!

github-actions bot commented Dec 22, 2025

Smoke Test Results

Uh oh!

pelikhan commented Dec 22, 2025

Uh oh!

pelikhan commented Dec 22, 2025

Uh oh!

github-actions bot commented Dec 22, 2025

Smoke Test Results

Uh oh!

github-actions bot commented Dec 22, 2025

Uh oh!

Copilot AI commented Dec 22, 2025

Uh oh!

pelikhan commented Dec 22, 2025

Uh oh!

Copilot AI commented Dec 22, 2025

Uh oh!

pelikhan commented Dec 22, 2025

Uh oh!

Copilot AI commented Dec 22, 2025

Uh oh!

Uh oh!

github-actions bot commented Dec 22, 2025

✅ Dev Hawk Report - Success

Commit Analysis

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Dec 22, 2025 •

edited

Loading

github-actions bot commented Dec 22, 2025 •

edited

Loading

github-actions bot commented Dec 22, 2025 •

edited

Loading

github-actions bot commented Dec 22, 2025 •

edited

Loading

github-actions bot commented Dec 22, 2025 •

edited by agentic-workflows-dev bot

Loading

github-actions bot commented Dec 22, 2025 •

edited

Loading

github-actions bot commented Dec 22, 2025 •

edited

Loading

github-actions bot commented Dec 22, 2025 •

edited

Loading