-
Notifications
You must be signed in to change notification settings - Fork 34
Split update-project into create-project and update-project safe outputs #6077
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…e projects Co-authored-by: mnkiefer <[email protected]>
Co-authored-by: mnkiefer <[email protected]>
Co-authored-by: mnkiefer <[email protected]>
Co-authored-by: mnkiefer <[email protected]>
|
@pelikhan: As discussed yesterday, this splits the |
|
Did you test it with dev.md ? |
… to helper, normalize project name, remove PROJECT_GITHUB_TOKEN Co-authored-by: pelikhan <[email protected]>
This would mean modifying dev to test the create & update project scenarios and pushing that to main, then selecting this branch for testing? So if anyone else is currently testing their stuff with dev, they would be blocked, no? |
|
No
|
|
Additionally, we should have at least one active agent uses these in some way. I think issue monster could maybe create a project when it discovers a cluster with 10+ issues |
|
The job failed silently. Needs to fail the job. https://github.com/githubnext/gh-aw/actions/runs/20135501447/job/57787808209#step:4:1 |
|
Well known environement variables should be prefixed with GH_AW_... |
Yes, still working on it, will ping you when ready. 👍🏼 |
|
De-prioritized. |
Summary of Changes
Addressed all PR feedback from @pelikhan:
Changed default max from 10 to 1 for create-project
create_project.go,safe_outputs.go,main_workflow_schema.json, and documentationMoved generateCampaignId to separate helper file
project_helpers.cjswithgenerateCampaignIdand newnormalizeProjectNamefunctionsproject_helpers.test.cjs(28 tests covering edge cases)Added project name normalization
Removed PROJECT_GITHUB_TOKEN handling
github-tokenparameter in step'swithsectionFiles Modified
pkg/workflow/create_project.go- Changed default max to 1pkg/workflow/safe_outputs.go- Changed default max to 1pkg/parser/schemas/main_workflow_schema.json- Updated schema defaultsdocs/src/content/docs/reference/safe-outputs.md- Updated documentationpkg/workflow/js/create_project.cjs- Use helpers, normalize names, remove PROJECT_GITHUB_TOKENpkg/workflow/js/create_project.test.cjs- Import generateCampaignId from helperFiles Added
pkg/workflow/js/project_helpers.cjs- Shared helper functionspkg/workflow/js/project_helpers.test.cjs- Comprehensive test suite (28 tests)Validation
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.