Skip to content

[WIP] Address feedback and fix tests for Copilot CLI agentic engine #1015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
Closed

[WIP] Address feedback and fix tests for Copilot CLI agentic engine #1015

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
094a5b5
Initial plan
Copilot Sep 25, 2025
293bcae
Fix tests after adding copilot engine
Copilot Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion cmd/gh-aw/main_entry_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,11 @@ func TestValidateEngine(t *testing.T) {
engine: "codex",
expectErr: false,
},
{
name: "valid copilot engine",
engine: "copilot",
expectErr: false,
},
{
name: "invalid engine",
engine: "gpt4",
Expand Down Expand Up @@ -75,7 +80,7 @@ func TestValidateEngine(t *testing.T) {
return
}

if tt.errMessage != "" && err.Error() != fmt.Sprintf("invalid engine value '%s'. Must be 'claude' or 'codex'", tt.engine) {
if tt.errMessage != "" && err.Error() != fmt.Sprintf("invalid engine value '%s'. Must be 'copilot', 'claude' or 'codex'", tt.engine) {
t.Errorf("validateEngine(%q) error message = %v, want to contain %v", tt.engine, err.Error(), tt.errMessage)
}
} else {
Expand Down
4 changes: 2 additions & 2 deletions pkg/parser/schema_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ func TestValidateMainWorkflowFrontmatterWithSchema(t *testing.T) {
"engine": "invalid-engine",
},
wantErr: true,
errContains: "value must be one of 'claude', 'codex'",
errContains: "value must be one of 'copilot', 'claude', 'codex', 'custom'",
},
{
name: "invalid engine object format - invalid id",
Expand All @@ -127,7 +127,7 @@ func TestValidateMainWorkflowFrontmatterWithSchema(t *testing.T) {
},
},
wantErr: true,
errContains: "value must be one of 'claude', 'codex'",
errContains: "value must be one of 'claude', 'codex', 'custom'",
},
{
name: "invalid engine object format - missing id",
Expand Down
8 changes: 4 additions & 4 deletions pkg/workflow/agentic_engine_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ func TestEngineRegistry(t *testing.T) {

// Test that built-in engines are registered
supportedEngines := registry.GetSupportedEngines()
if len(supportedEngines) != 3 {
t.Errorf("Expected 3 supported engines, got %d", len(supportedEngines))
if len(supportedEngines) != 4 {
t.Errorf("Expected 4 supported engines, got %d", len(supportedEngines))
}

// Test getting engines by ID
Expand Down Expand Up @@ -116,7 +116,7 @@ func TestEngineRegistryCustomEngine(t *testing.T) {

// Test that supported engines list is updated
supportedEngines := registry.GetSupportedEngines()
if len(supportedEngines) != 4 {
t.Errorf("Expected 4 supported engines after adding test-custom, got %d", len(supportedEngines))
if len(supportedEngines) != 5 {
t.Errorf("Expected 5 supported engines after adding test-custom, got %d", len(supportedEngines))
}
}