Migrate collect output to TypeScript with SafeJobConfig validation#1010
Merged
Conversation
…ect_ndjson_output.ts Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback: Enhance TypeScript migration with interface and validation improvements
Migrate collect output to TypeScript with SafeJobConfig validation
Sep 25, 2025
pelikhan
added a commit
that referenced
this pull request
Sep 25, 2025
* feat: Implement safe output collection and validation for GitHub Actions - Added a new script to sanitize and validate output items for GitHub Actions. - Introduced functions for sanitizing content, validating JSON, and handling various output types. - Implemented error handling and logging for invalid inputs. - Configured maximum allowed counts for different output types. - Enhanced security by neutralizing mentions, filtering URLs, and truncating excessive content. - Stored validated output in a temporary JSON file for further processing. * feat: Enhance NDJSON output processing and validation - Updated `collect_ndjson_output.ts` to include type definitions for SafeOutputItem and SafeOutputConfigs. - Improved type safety by specifying types for function parameters and variables. - Refactored error handling to ensure errors are only pushed to the errors array if they exist. - Added type definitions for safe outputs configuration in a new file `safe-outputs-config.d.ts`. - Updated `create_discussion.js` and `create_issue.js` to improve readability and maintainability by restructuring code and enhancing error handling. - Added support for discussion categories and improved logging for created discussions and issues. - Updated `tsconfig.json` to include `collect_ndjson_output.ts` for TypeScript compilation. * [WIP] "Address feedback: Add strongly typed interfaces for output configuration" (#1009) * Migrate collect output to TypeScript with SafeJobConfig validation (#1010) * Initial plan * Add SafeJobConfig interface types and schema-based validation to collect_ndjson_output.ts Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> * [WIP] Address feedback on TypeScript migration for collect output (#1011) --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.