Skip to content

migrate collect output to type script#1008

Merged
pelikhan merged 6 commits intomainfrom
collect_output_ts
Sep 25, 2025
Merged

migrate collect output to type script#1008
pelikhan merged 6 commits intomainfrom
collect_output_ts

Conversation

@pelikhan
Copy link
Copy Markdown
Collaborator

@pelikhan pelikhan commented Sep 25, 2025

  • migrate to typescript
  • add inputs validation, sanitization

- Added a new script to sanitize and validate output items for GitHub Actions.
- Introduced functions for sanitizing content, validating JSON, and handling various output types.
- Implemented error handling and logging for invalid inputs.
- Configured maximum allowed counts for different output types.
- Enhanced security by neutralizing mentions, filtering URLs, and truncating excessive content.
- Stored validated output in a temporary JSON file for further processing.
- Updated `collect_ndjson_output.ts` to include type definitions for SafeOutputItem and SafeOutputConfigs.
- Improved type safety by specifying types for function parameters and variables.
- Refactored error handling to ensure errors are only pushed to the errors array if they exist.
- Added type definitions for safe outputs configuration in a new file `safe-outputs-config.d.ts`.
- Updated `create_discussion.js` and `create_issue.js` to improve readability and maintainability by restructuring code and enhancing error handling.
- Added support for discussion categories and improved logging for created discussions and issues.
- Updated `tsconfig.json` to include `collect_ndjson_output.ts` for TypeScript compilation.
@pelikhan
Copy link
Copy Markdown
Collaborator Author

@copilot

  • generate a set of strongly typed interface for the known message types in the safe output configuration messages (extends SafeOutputConfig in safe-outputs-config.d.ts)
  • apply types in collect_ndjson_output.ts

Copy link
Copy Markdown
Contributor

Copilot AI commented Sep 25, 2025

@pelikhan I've opened a new pull request, #1009, to work on those changes. Once the pull request is ready, I'll request review from you.

@pelikhan
Copy link
Copy Markdown
Collaborator Author

@copilot in the collect ndjson output file

  • add interface type for a safe job configuration item
  • use type when validating those messages
  • use schema defined in "inputs" to validate the fields. Apply sanitize if the type is a string

Copy link
Copy Markdown
Contributor

Copilot AI commented Sep 25, 2025

@pelikhan I've opened a new pull request, #1010, to work on those changes. Once the pull request is ready, I'll request review from you.

…1010)

* Initial plan

* Add SafeJobConfig interface types and schema-based validation to collect_ndjson_output.ts

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
@pelikhan
Copy link
Copy Markdown
Collaborator Author

@copilot format, recompile

Copy link
Copy Markdown
Contributor

Copilot AI commented Sep 25, 2025

@pelikhan I've opened a new pull request, #1011, to work on those changes. Once the pull request is ready, I'll request review from you.

@pelikhan pelikhan marked this pull request as ready for review September 25, 2025 18:48
@pelikhan pelikhan merged commit a141cbb into main Sep 25, 2025
14 checks passed
@pelikhan pelikhan deleted the collect_output_ts branch September 25, 2025 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants