Rust: Update legacy MaD models 4 #19948
+44
−39
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| extensions: | ||
| - addsTo: | ||
| pack: codeql/rust-all | ||
| extensible: sourceModel | ||
| data: | ||
| - ["<async_std::net::tcp::stream::TcpStream>::connect", "ReturnValue.Future.Field[core::result::Result::Ok(0)]", "remote", "manual"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,19 +1,19 @@ | ||
| extensions: | ||
| - addsTo: | ||
| pack: codeql/rust-all | ||
| extensible: summaryModel | ||
| data: | ||
| - ["futures_executor::local_pool::block_on", "Argument[0]", "ReturnValue", "value", "manual"] | ||
| - ["<futures_util::io::buf_reader::BufReader>::new", "Argument[0]", "ReturnValue", "taint", "manual"] | ||
| - ["futures-util::io::AsyncReadExt::read", "Argument[self]", "Argument[0].Reference", "taint", "manual"] | ||
| - ["futures-util::io::AsyncReadExt::read", "Argument[self].Reference", "Argument[0].Reference", "taint", "manual"] | ||
| - ["futures-util::io::AsyncReadExt::read_to_end", "Argument[self]", "Argument[0].Reference", "taint", "manual"] | ||
| - ["futures-util::io::AsyncReadExt::read_to_end", "Argument[self].Reference", "Argument[0].Reference", "taint", "manual"] | ||
| - ["futures-util::io::AsyncBufReadExt::read_line", "Argument[self]", "Argument[0].Reference", "taint", "manual"] | ||
| - ["futures-util::io::AsyncBufReadExt::read_line", "Argument[self].Reference", "Argument[0].Reference", "taint", "manual"] | ||
| - ["futures-util::io::AsyncBufReadExt::read_until", "Argument[self]", "Argument[1].Reference", "taint", "manual"] | ||
| - ["futures-util::io::AsyncBufReadExt::read_until", "Argument[self].Reference", "Argument[1].Reference", "taint", "manual"] | ||
| - ["futures-util::io::AsyncBufReadExt::fill_buf", "Argument[self]", "ReturnValue.Future.Field[core::result::Result::Ok(0)]", "taint", "manual"] | ||
| - ["futures-util::io::AsyncBufReadExt::lines", "Argument[self]", "ReturnValue", "taint", "manual"] | ||
| - ["<alloc::boxed::Box as core::iter::traits::iterator::Iterator>::next", "Argument[self]", "ReturnValue.Future.Field[core::option::Option::Some(0)]", "taint", "manual"] | ||
| - ["<futures-util::io::buf_reader::BufReader as futures_io::if_std::AsyncBufRead>::poll_fill_buf", "Argument[self].Reference", "ReturnValue.Field[core::task::poll::Poll::Ready(0)].Field[core::result::Result::Ok(0)]", "taint", "manual"] | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,14 +1,19 @@ | ||
| extensions: | ||
| - addsTo: | ||
| pack: codeql/rust-all | ||
| extensible: sourceModel | ||
| data: | ||
| - ["libc::unix::free", "Argument[0]", "pointer-invalidate", "manual"] | ||
| - ["libc::windows::free", "Argument[0]", "pointer-invalidate", "manual"] | ||
| - addsTo: | ||
| pack: codeql/rust-all | ||
| extensible: sinkModel | ||
| data: | ||
| - ["libc::unix::malloc", "Argument[0]", "alloc-size", "manual"] | ||
| - ["libc::windows::malloc", "Argument[0]", "alloc-size", "manual"] | ||
| - ["libc::unix::aligned_alloc", "Argument[1]", "alloc-size", "manual"] | ||
| - ["libc::windows::aligned_alloc", "Argument[1]", "alloc-size", "manual"] | ||
| - ["libc::unix::calloc", "Argument[0,1]", "alloc-size", "manual"] | ||
| - ["libc::windows::calloc", "Argument[0,1]", "alloc-size", "manual"] | ||
| - ["libc::unix::realloc", "Argument[1]", "alloc-size", "manual"] | ||
| - ["libc::windows::realloc", "Argument[1]", "alloc-size", "manual"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -43,7 +43,7 @@ async fn test_futures_rustls_futures_io() -> io::Result<()> { | |
| // using the `AsyncReadExt::read` extension method (higher-level) | ||
| let mut buffer1 = [0u8; 64]; | ||
| let bytes_read1 = futures::io::AsyncReadExt::read(&mut reader, &mut buffer1).await?; | ||
| sink(&buffer1[..bytes_read1]); // $ MISSING: hasTaintFlow=url | ||
|
|
||
| let mut buffer2 = [0u8; 64]; | ||
| let bytes_read2 = reader.read(&mut buffer2).await?; // we cannot resolve the `read` call, which comes from `impl<R: AsyncRead + ?Sized> AsyncReadExt for R {}` in `async_read_ext.rs` | ||
|
|
@@ -61,16 +61,16 @@ async fn test_futures_rustls_futures_io() -> io::Result<()> { | |
| let mut cx = Context::from_waker(futures::task::noop_waker_ref()); | ||
| let buffer = pinned.poll_fill_buf(&mut cx); | ||
| if let Poll::Ready(Ok(buf)) = buffer { | ||
| sink(&buffer); // $ MISSING: hasTaintFlow=url | ||
|
There was a problem hiding this comment. Currently the computed canonical path for this function is There was a problem hiding this comment. Hmm the |
||
| sink(buf); // $ MISSING: hasTaintFlow=url | ||
| } | ||
|
|
||
| // using the `AsyncBufRead` trait (alternative syntax) | ||
| let buffer2 = Pin::new(&mut reader2).poll_fill_buf(&mut cx); | ||
| match (buffer2) { | ||
| Poll::Ready(Ok(buf)) => { | ||
| sink(&buffer2); // $ MISSING: hasTaintFlow=url | ||
| sink(buf); // $ MISSING: hasTaintFlow=url | ||
| } | ||
| _ => { | ||
| // ... | ||
|
|
@@ -101,7 +101,7 @@ async fn test_futures_rustls_futures_io() -> io::Result<()> { | |
| // using the `AsyncReadExt::read` extension method (higher-level) | ||
| let mut buffer1 = [0u8; 64]; | ||
| let bytes_read1 = futures::io::AsyncReadExt::read(&mut reader2, &mut buffer1).await?; | ||
| sink(&buffer1[..bytes_read1]); // $ MISSING: hasTaintFlow=url | ||
|
|
||
| let mut buffer2 = [0u8; 64]; | ||
| let bytes_read2 = reader2.read(&mut buffer2).await?; // we cannot resolve the `read` call, which comes from `impl<R: AsyncRead + ?Sized> AsyncReadExt for R {}` in `async_read_ext.rs` | ||
|
|
@@ -114,7 +114,7 @@ async fn test_futures_rustls_futures_io() -> io::Result<()> { | |
| sink(&pinned); // $ hasTaintFlow=url | ||
| let mut cx = Context::from_waker(futures::task::noop_waker_ref()); | ||
| let buffer = pinned.poll_fill_buf(&mut cx); | ||
| sink(&buffer); // $ MISSING: hasTaintFlow=url | ||
| if let Poll::Ready(Ok(buf)) = buffer { | ||
| sink(buf); // $ MISSING: hasTaintFlow=url | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be
futures_util.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually might need to be
<_ as futures_util::io::AsyncReadExt>::readetc.