-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Rust: Update legacy MaD models 4 #19948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…r these last few cases).
I think it will be prudent to get the first two/three PRs merged before attempting to address the test failures here. |
The test failures look The relevant bits of code are
I would expect the canonical path to be either This should address the underlying issue #19988 |
I've brought in the fix for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
Final update of legacy MaD models to the new model format (continues from #19946 and should be independent of that).
There's a lot of guesswork involved in this last set of changes - i.e. cases where I couldn't find a real
getCanonicalPath
. There should be tests for most of them though so we will find out if we're way off.