WIP on jobs board by CuriousLearner · Pull Request #1102 · gitcoinco/web

CuriousLearner · 2018-05-08T07:23:21Z

Description

This is still a WIP. Will update it soon.

Checklist

linter status: 100% pass
changes don't break existing behavior
commit message follows commit guidelines

Affected core subsystem(s)

Testing

Refers/Fixes

Refs #958

stickler-ci · 2018-05-08T07:23:47Z

+
+var set_filter_header = function() {
+  var idxStatusEl = $('input[name=idx_status]:checked');
+  var filter_status = idxStatusEl.attr('val-ui') ? idxStatusEl.attr('val-ui') : 'All';


Expected blank line after variable declarations. (newline-after-var)

stickler-ci · 2018-05-08T07:23:48Z

+  var idxStatusEl = $('input[name=idx_status]:checked');
+  var filter_status = idxStatusEl.attr('val-ui') ? idxStatusEl.attr('val-ui') : 'All';
+  // TODO: See what all filters are to be displayed from designs
+  $('#filter').html("All");


Strings must use singlequote. (quotes)

stickler-ci · 2018-05-08T07:23:48Z

+
+  var matchesEl = $('#matches');
+  var
+  listingInfoEl = $('#listing-info');


Expected indentation of 6 spaces but found 2. (indent)

stickler-ci · 2018-05-08T07:23:48Z

@@ -0,0 +1,3 @@
+from django.test import TestCase


F401 'django.test.TestCase' imported but unused

can you add tests?

CuriousLearner · 2018-05-08T07:26:40Z

+from .models import Job
+
+
+def list_jobs(request):


This would be changed and just contain template response, since the views just calls the relevant API to fetch data.

@owocki

thelostone-mc · 2018-05-08T11:46:39Z

@CuriousLearner heads up -> we are moving to rem as against to px ^_^

owocki · 2018-05-08T15:01:52Z

@CuriousLearner heads up -> we are moving to rem as against to px ^_^

we should really have details about this (and other code standards which we follow) in the contributor guidelines, so that people have the opportunity to know upfront, before they submit the PR

thelostone-mc · 2018-05-10T09:46:53Z

we should really have details about this (and other code standards which we follow)

@owocki It's been added here

codecov · 2018-05-13T10:07:33Z

Codecov Report

❗ No coverage uploaded for pull request base (master@2f10de2). Click here to learn what that means.
The diff coverage is 27.27%.

@@            Coverage Diff            @@
##             master    #1102   +/-   ##
=========================================
  Coverage          ?   15.32%           
=========================================
  Files             ?      141           
  Lines             ?    10973           
  Branches          ?     1457           
=========================================
  Hits              ?     1682           
  Misses            ?     9285           
  Partials          ?        6

Impacted Files	Coverage Δ
app/app/settings.py	`84.04% <ø> (ø)`
app/jobs/views.py	`0% <0%> (ø)`
app/jobs/forms.py	`0% <0%> (ø)`
app/jobs/routers.py	`0% <0%> (ø)`
app/jobs/services.py	`0% <0%> (ø)`
app/app/urls.py	`0% <0%> (ø)`
app/jobs/filters.py	`0% <0%> (ø)`
app/jobs/api.py	`0% <0%> (ø)`
app/jobs/serializers.py	`0% <0%> (ø)`
app/jobs/apps.py	`0% <0%> (ø)`
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f10de2...5ea25f1. Read the comment docs.

mbeacom · 2018-05-14T19:24:52Z

@CuriousLearner Please follow the instructions in https://github.com/gitcoinco/web/blob/master/docs/CONTRIBUTING.md to enable precommit
and install it's dependencies.

owocki · 2018-05-16T23:30:15Z

#1102
#1079

which of these PRs should remain active?

CuriousLearner · 2018-05-17T09:35:49Z

@owocki #1102 should be the active one as discussed previously.
@zoek1 Do you want to collaborate on some of the things?

owocki · 2018-05-17T17:16:57Z

thanks @CuriousLearner i will comment on the other thread.. when do you think youll have this PR ready for review?

stickler-ci · 2018-05-19T16:18:05Z

+/* eslint no-redeclare: "warn" */
+
+var build_detail_page = function(result) {
+   var template = $.templates('#job_detail');


Expected indentation of 2 spaces but found 3. (indent)

stickler-ci · 2018-05-19T16:18:05Z

+var build_detail_page = function(result) {
+   var template = $.templates('#job_detail');
+
+   html = template.render(result);


Expected indentation of 2 spaces but found 3. (indent)

stickler-ci · 2018-05-19T16:18:05Z

+
+   html = template.render(result);
+
+   $('#rendered_job_detail').html(html);


Expected indentation of 2 spaces but found 3. (indent)

stickler-ci · 2018-05-19T16:18:05Z

+    var nonefound = true;
+
+    if (result) {
+       nonefound = false;


Expected indentation of 6 spaces but found 7. (indent)

stickler-ci · 2018-05-19T16:18:05Z

+
+    if (result) {
+       nonefound = false;
+        build_detail_page(result);


Expected indentation of 6 spaces but found 8. (indent)

stickler-ci · 2018-05-19T16:18:05Z

+    if (result) {
+       nonefound = false;
+        build_detail_page(result);
+        document.result = result;


Expected indentation of 6 spaces but found 8. (indent)

stickler-ci · 2018-05-19T16:18:06Z

+       nonefound = false;
+        build_detail_page(result);
+        document.result = result;
+        $('#rendered_job_detail').css('display', 'block');


Expected indentation of 6 spaces but found 8. (indent)

stickler-ci · 2018-05-19T16:18:06Z

+
+var main = function() {
+  setTimeout(function() {
+      pull_job_from_api();


Expected indentation of 4 spaces but found 6. (indent)

stickler-ci · 2018-05-19T16:18:06Z

+      // } else if (result['fulfiller_address'] !== '0x0000000000000000000000000000000000000000') {
+      //   result['my_bounty'] = '<a class="btn font-smaller-2 btn-sm btn-outline-dark" role="button" href="#">' + result['status'] + '</span></a>';
+      // }
+      console.log(result);


Unexpected console statement. (no-console)

stickler-ci · 2018-05-19T16:18:06Z

+
+      result['job_company'] = ((result['company'] ? result['company'] : 'Company Hidden') + ' &bull; ');
+
+      result['job_skill'] += result['skills'] ? result['skills'] : ''


Missing semicolon. (semi)

CuriousLearner · 2018-05-20T08:59:41Z

@owocki @mbeacom where do I find the list of skills to be populated in the Jobs Board?

mbeacom · 2018-05-21T00:02:05Z

@CuriousLearner I could be mistaken, as I didn't scope this initially, but I think we're using Keywords. You should be able to retrieve them via a GET against the keywords API endpoint.

owocki · 2018-05-21T18:31:54Z

yes Keywords is what you want to use

CuriousLearner · 2018-05-23T18:52:39Z

Update:

Right now working on initial form for job creation.

Need to apply filters/keywords in list view filtering and fix css.
Need css changes in detail view as well.

stickler-ci · 2018-05-27T08:22:07Z

+from datetime import timedelta
+
+from django.conf import settings
+from django.contrib.postgres.fields import ArrayField


F401 'django.contrib.postgres.fields.ArrayField' imported but unused

CuriousLearner · 2018-05-27T09:19:21Z

@mbeacom @owocki

Sure, I've used skills API helper to populate the choice field for skills.

I do have a question though:

I see that the description section for the job posting is a WYSIWYG editor. Do we already have something integrated with the project, or are there any preference for packages to use here?

CuriousLearner · 2018-05-27T15:44:30Z

Also, I see in the Job posting design that Job Type can be Full-time or Part-time, but the list view also shows a third job_type that says contract.

Do we need to update one of the designs here?

CuriousLearner · 2018-07-05T18:40:22Z

@thelostone-mc Can you take a look now please? :)

owocki · 2018-07-09T17:51:08Z

testing now

owocki · 2018-07-09T17:55:02Z

+var toggleAny = function(event) {
+  if (!event)
+    return;
+  // var key = event.target.name;


whats with this commented out code?

owocki · 2018-07-09T17:55:42Z

+    });
+  }
+
+  if (localStorage['keywords']) {


this will be a name collision with the dashboard.js which also has localStorage['keywords

stickler-ci · 2018-07-09T18:05:04Z

@@ -0,0 +1,3 @@
+from django.test import TestCase


F401 'django.test.TestCase' imported but unused

owocki · 2018-07-09T18:09:12Z

here is my QA notes:

CRITICAL:

it is possible to do SQL injection when posting a job - screenshot
search doesnt work
neither do the filters on the left hand side
the job/* pages are super slow to load. per this console output from my terminal, it looks like they request a bunch of info from github every pageload

HIGH PRIORITY

when a new job is submitted, admins should be emailed to approve it. here is a method you can copy
how come i can only add one skill ?
on the 'issue description', the placeholder text is bad. it should be "Please enter the job description as plaintext or markdown' screenshot
sidebar says 'back to issue explorer' but were browsing jobs not issue explorer
dashboard.js and jobs.js have a lot of duplicated / copied / pasted code.
bounty detail page does not match the design screenshot - with design / implementation

OTHER

this info button doesnt have a tooltip - screenshot
can we make this a button
responsiveness of each page could use some work. screenshot1 2 3
merge conflicts need resolved

@CuriousLearner let me know what you think of the above. we're hoping to get this shipped in the next week or so, so let us know what your availability is to work through the issues

thelostone-mc · 2018-07-09T18:20:43Z

+  font-size: 3em;
+}
+
+.company-name, #exp-lang, #job-post-duration {


could we break this up into multiple lines?

thelostone-mc · 2018-07-09T18:21:28Z

+    padding-left: 1em;
+    padding-right: 2em;
+  }
+}


Could we replace px and em with -> rem

mbeacom

Some general comments - We'll definitely need to address all of the comments presented by @owocki and ensure we're performing the appropriate field validation/cleaning.

mbeacom · 2018-07-09T18:16:03Z

    profile = profile_helper(handle, True)

-    keywords = []
+    keywords = list()


You shouldn't need to change this and is a commonly considered an antipattern in Python in favor of the shorthand []

mbeacom · 2018-07-09T18:17:35Z

+
+def job_detail(request, pk):
+    context = {
+        'pk': pk


Should we handle any kind of update functionality against details and use the form you've already created?

mbeacom · 2018-07-09T18:18:21Z

@@ -0,0 +1,111 @@
+{% comment %}


This template should extend base.html

mbeacom · 2018-07-09T18:18:33Z

@@ -0,0 +1,122 @@
+{% load i18n static %}
+<!DOCTYPE html>


This template should extend base.html

mbeacom · 2018-07-09T18:18:45Z

@@ -0,0 +1,120 @@
+{% comment %}


This template should extend base.html

mbeacom · 2018-07-09T18:34:21Z

+        verbose_name=_('Title'), max_length=200, null=False, blank=False
+    )
+    description = models.TextField(verbose_name=_('Description'))
+    github_profile_link = models.URLField(


Github profiles should link directly back to dashboard.Profile versus char/url storage of text representing a Profile.

mbeacom · 2018-07-09T18:34:45Z

+    company = models.CharField(_('Company'), max_length=50, null=True, blank=True)
+    apply_email = models.EmailField(_('Contact Email for Job'), null=True, blank=True)
+    posted_at = models.DateTimeField(_('Posted At'), null=False, blank=False, default=timezone.now)
+    posted_by_gitcoin_username = models.CharField(


This should be associated with the dashboard.Profile that created the Job versus charfield of username

mbeacom · 2018-07-09T18:35:00Z

@@ -0,0 +1,24 @@
+
+# Third Party Stuff


Replace with docstring

mbeacom · 2018-07-09T18:36:06Z

+
+
+def list_jobs(request):
+    context = dict()


Drop this and simply context={} if that's what you're going for here. Realistically, we probably want to pass some contextual data to the list view.

mbeacom · 2018-07-09T18:38:16Z

+
+
+def create_job(request):
+    context = dict()


When possible, please use the shorthand {}

owocki · 2018-07-10T23:15:37Z

@CuriousLearner let us know what you think of the above review!

* 'fix-958' of github.com:CuriousLearner/web: linter

stickler-ci · 2018-08-05T11:22:16Z

@@ -0,0 +1,3 @@
+from django.test import TestCase


F401 'django.test.TestCase' imported but unused

stickler-ci · 2018-08-05T11:44:55Z

@@ -0,0 +1,3 @@
+from django.test import TestCase


F401 'django.test.TestCase' imported but unused

* 'master' of https://github.com/gitcoinco/web: (76 commits) hack: trailing slash for profile (gitcoinco#1937) Minor tweaks to action plan textarea (gitcoinco#1856) fixes label on gas guzzler page, and adds an admin view for vizuailzations keep an eye on unsubscribes in preferences keep an eye on unsubscribes in preferences Split create_new_bounty kwargs building and check if once (gitcoinco#1892) press satisfy linter fix for https://gitcoincore.slack.com/archives/CAXQ7PT60/p1533912000000126 Update profile check to getattr share link not edit link does tip receive math in BigNumber, bc JS rounding issues copy updates newsletter 8/10 fix for slack not showing UP gas guzzlers linter gas guzzlers Error: insufficient funds for gas * price + value starts to track gas guzzlers, for later inclusion in the gitcoin gas station ...

stickler-ci · 2018-08-12T09:42:40Z

@@ -0,0 +1,3 @@
+from django.test import TestCase


F401 'django.test.TestCase' imported but unused

stickler-ci · 2018-08-12T10:20:15Z

@@ -0,0 +1,3 @@
+from django.test import TestCase


F401 'django.test.TestCase' imported but unused

stickler-ci · 2018-08-12T10:33:18Z

@@ -0,0 +1,3 @@
+from django.test import TestCase


F401 'django.test.TestCase' imported but unused

mbeacom · 2018-10-05T15:15:46Z

Is this something we should pursue rebasing and handing back off to @CuriousLearner (if interested) or bountying back out for completion? cc @owocki @PixelantDesign @thelostone-mc @SaptakS

owocki · 2018-10-05T18:46:49Z

i'd be curious to hear from @CuriousLearner if is interested in handling it.. if not, i think we backoff for now

CuriousLearner · 2018-10-07T13:51:13Z

Hey, @owocki @mbeacom I can do this, but I'll be traveling in October to the US for my DjangoCon US talk. So, I think I'll be able to handle this after that.

mbeacom · 2018-11-19T19:18:42Z

@CuriousLearner Thanks for the heads up - Closing for now. Feel free to re-open if/when you find the time!

WIP on jobs board

039133f

stickler-ci reviewed May 8, 2018

View reviewed changes

CuriousLearner commented May 8, 2018

View reviewed changes

PixelantDesign added the in progress label May 8, 2018

mbeacom added the wip label May 8, 2018

Overall styling for detail page with static data

e861b0f

mbeacom added 2 commits May 14, 2018 15:22

Merge branch 'master' into fix-958

485941e

Fix eslint, stylelint, and isort

bf64a0e

owocki mentioned this pull request May 17, 2018

WIP: Add job board #1079

Closed

20 tasks

CuriousLearner added 2 commits May 19, 2018 21:47

WIP job detail view

11af0de

Make Job detail view fetch data from API

c6b7d57

stickler-ci reviewed May 19, 2018

View reviewed changes

Fix linting + more dynamic render on job details page

58afbac

WIP job creation

6156a07

stickler-ci reviewed May 27, 2018

View reviewed changes

Fix skills to be fetched from keywords

786d983

owocki reviewed Jul 9, 2018

View reviewed changes

linter

4a11527

ghost assigned owocki Jul 9, 2018

stickler-ci reviewed Jul 9, 2018

View reviewed changes

thelostone-mc reviewed Jul 9, 2018

View reviewed changes

mbeacom suggested changes Jul 9, 2018

View reviewed changes

CuriousLearner added 2 commits July 29, 2018 02:23

Address reviews

633f1bd

Merge branch 'fix-958' of github.com:CuriousLearner/web into fix-958

f86ad21

* 'fix-958' of github.com:CuriousLearner/web: linter

stickler-ci reviewed Aug 5, 2018

View reviewed changes

CuriousLearner added 2 commits August 5, 2018 17:03

minor code fixes

ffa5c52

Merge upstream master

7dc1efc

stickler-ci reviewed Aug 5, 2018

View reviewed changes

CuriousLearner added 2 commits August 12, 2018 15:06

Address reviews

83db70c

stickler-ci reviewed Aug 12, 2018

View reviewed changes

Fix migrations

5feec00

stickler-ci reviewed Aug 12, 2018

View reviewed changes

Fix migrations

5ea25f1

stickler-ci reviewed Aug 12, 2018

View reviewed changes

mbeacom closed this Nov 19, 2018


		html = template.render(result);

		$('#rendered_job_detail').html(html);


		result['job_company'] = ((result['company'] ? result['company'] : 'Company Hidden') + ' • ');

		result['job_skill'] += result['skills'] ? result['skills'] : ''

Uh oh!

Conversation

CuriousLearner commented May 8, 2018

Description

Checklist

Affected core subsystem(s)

Testing

Refers/Fixes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

thelostone-mc commented May 8, 2018

Uh oh!

owocki commented May 8, 2018

Uh oh!

thelostone-mc commented May 10, 2018

Uh oh!

codecov bot commented May 13, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mbeacom commented May 14, 2018

Uh oh!

owocki commented May 16, 2018

Uh oh!

CuriousLearner commented May 17, 2018

Uh oh!

owocki commented May 17, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

CuriousLearner commented May 20, 2018

Uh oh!

mbeacom commented May 21, 2018

Uh oh!

owocki commented May 21, 2018

Uh oh!

CuriousLearner commented May 23, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

CuriousLearner commented May 27, 2018

Uh oh!

CuriousLearner commented May 27, 2018

Uh oh!

CuriousLearner commented Jul 5, 2018

Uh oh!

owocki commented Jul 9, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

codecov bot commented May 13, 2018 •

edited

Loading