Skip to content

Conversation

@zoek1
Copy link
Contributor

@zoek1 zoek1 commented May 5, 2018

Description
Checklist

Submit Job

  • User navigates to /jobs/new and enters in all information on the form.
  • github profile can be prefilled by logging in to gitcoin
  • validation is performed inline upon submit.
  • if validation passes, a new DB object is created (with active == N)
  • upon save, each field is scraped for script injection attacks and any javascript is removed.
  • an email is sent to admin settings.CONTACT_EMAIL requesting admin to approve the job ( see processed_faucet_request for a parallel of how emails are done)
  • when admin approves the job in the django admin, then an email is sent to the user who submitted it letting them know it's live
  • the job is listed on the jobs/ page

View Job

  • User sees a list of jobs at /jobs
  • Page is responsive (tablet, mobile, desktop)
  • There is a list of filters on the left, and search/sort on top that are updated upon click
  • if > 25 jobs are visible, pagination is enabled
  • When they click on a job they are taken to that page (job desc is markdown rendered)
  • the 'apply' button takes user to the job.apply_location
  • clicking on 'github profile' takes user to the posters github profile
  • clicking on a keyword takes one back to the job board page with that keyword prefilled
  • clicking 'back to job board' takes user back to their previous search

Technical

  • linter status: 100% pass
  • changes don't break existing behavior
  • commit message follows commit guidelines
Affected core subsystem(s)
Testing

Current visual status of list jobs
list_jobs

Current visual status of new job
submit-job

Current visual status of detail job
detail_page

Refers/Fixes

Refs: #958

@@ -0,0 +1,3 @@
from django.contrib import admin

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

F401 'django.contrib.admin' imported but unused

company = models.CharField(max_length=255)
github_profile = models.CharField(max_length=255, default='')
expires_date = models.DateTimeField(default=datetime.utcnow()+timedelta(days=30))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

W391 blank line at end of file

@@ -0,0 +1,3 @@
from django.test import TestCase

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

F401 'django.test.TestCase' imported but unused

@@ -0,0 +1,12 @@
from django.shortcuts import render

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

F401 'django.shortcuts.render' imported but unused

@owocki
Copy link
Contributor

owocki commented May 7, 2018

code looks good so far! looking forward to reviewing when its no longer WIP :)

@owocki
Copy link
Contributor

owocki commented May 16, 2018

@CuriousLearner @zoek1 hows this going? is it still active? very excited to get it live soon

@owocki owocki mentioned this pull request May 16, 2018
3 tasks
@owocki
Copy link
Contributor

owocki commented May 17, 2018

closing this in favor of #1102 per #1079

@owocki owocki closed this May 17, 2018
@owocki
Copy link
Contributor

owocki commented May 17, 2018

@zoek1 let me know if this was done in error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants