Skip to content

Customise file pattern and project directory#17

Open
dejagersh wants to merge 8 commits into
gimenete:masterfrom
Laptify:master
Open

Customise file pattern and project directory#17
dejagersh wants to merge 8 commits into
gimenete:masterfrom
Laptify:master

Conversation

@dejagersh

Copy link
Copy Markdown

Fixes:

#16
#15

Also, I added my IDE project folder to the gitignore

@hstandaert

Copy link
Copy Markdown

I can confirm this works 👍

@mskadu

mskadu commented Apr 17, 2020

Copy link
Copy Markdown

Is this repo active at all? There have been no commits since Jan 2019?

@dejagersh

Copy link
Copy Markdown
Author

It's not. You can either use ours at https://github.com/Laptify/eslint-action or use your own fork :)

@mskadu

mskadu commented Apr 17, 2020

Copy link
Copy Markdown

I dont mind using yours. But I'd prefer to join up with someone who is already and can continue to contribute going ahead. I can't make that commitment - not just yet.

Looks like someone else is actively maintaining a fork. Do you want to join forces with him? He's got good stuff being PR'ed into his repo too. Oh and he's got the Action for this listed in the Marketplace too.

In either case, 👍 for the good stuff!

@dejagersh

Copy link
Copy Markdown
Author

Absolutely, I understand. In fact, I didn't know there was an active fork. When I have time I will see if I can migrate to use that one! I prefer to use a widely used repo than my one with only me using it.

@mskadu

mskadu commented Apr 17, 2020

Copy link
Copy Markdown

I can't wait. Your change (this PR) is exactly what I need and is stopping me from using that Action. Most of my projects have nested node.js sub-projects ☹️ and so in it's current stage - that action cannot be used.

Looking forward to seeing your changes there. 👍

@dejagersh

Copy link
Copy Markdown
Author

hallee#4

@mskadu I just opened the PR 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants