Skip to content
This repository was archived by the owner on Sep 20, 2020. It is now read-only.

add support for yarn and source-root#3

Merged
hallee merged 8 commits into
hallee:masterfrom
MichaelSp:master
May 18, 2020
Merged

add support for yarn and source-root#3
hallee merged 8 commits into
hallee:masterfrom
MichaelSp:master

Conversation

@MichaelSp

@MichaelSp MichaelSp commented Apr 13, 2020

Copy link
Copy Markdown

@MichaelSp MichaelSp marked this pull request as draft April 13, 2020 19:34
@MichaelSp MichaelSp marked this pull request as ready for review April 13, 2020 19:40
@mskadu

mskadu commented Apr 17, 2020

Copy link
Copy Markdown

apologies as this comment is unrelated to this PR. I am posting here since you don't have Issues enabled on your repo. Can you please enable so we can post questions, etc there?

In the meanwhile, please consider merging in this PR on the parent repo here. I have requested the author to consider joining forces with you.

Clearly the original repo is dead.

Comment thread lib/run.js Outdated
Comment thread lib/run.js
Comment thread action.yaml Outdated
Co-authored-by: Hal Lee <hal@lee.me>
Comment thread lib/run.js

@MichaelSp MichaelSp left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I had to implement batch handling in order to test this again. Github only allows 50 annotations per PATCH request: https://developer.github.com/v3/checks/runs/#output-object-1

Now it should work as expected

@MichaelSp MichaelSp requested a review from hallee May 18, 2020 16:44
@hallee hallee merged commit 882e3ff into hallee:master May 18, 2020
@hallee

hallee commented May 18, 2020

Copy link
Copy Markdown
Owner

Thanks for contributing! This looks great.

@hallee hallee mentioned this pull request May 18, 2020
@darshkpatel

Copy link
Copy Markdown

Since Issues aren't enabled, I'm commenting here,
After merging this PR , the action seem to be throwing an error and failing

{"message":"Invalid request.\n\n\"summary\", \"title\" weren't supplied.","documentation_url":"https://developer.github.com/v3/checks/runs/#update-a-check-run"}

https://github.com/frg-fossee/eSim-Cloud/runs/687748133

hallee added a commit that referenced this pull request May 19, 2020
hallee added a commit that referenced this pull request May 19, 2020
@hallee

hallee commented May 19, 2020

Copy link
Copy Markdown
Owner

@darshkpatel Thanks for the heads up. I believe I've fixed those issues in #6, and also set this action to lint this repo so it's easier to test changes going forward. I also turned on issues for the repo. Let me know if you still have issues running this action

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants