Skip to content

Conversation

@andyleiserson
Copy link
Contributor

@andyleiserson andyleiserson commented Oct 20, 2025

Note: target is v27 branch. This backports a variation of a change in #8373.

As discussed in #8373, the assertion that !encoder.is_open is falsified when CommandEncoder::as_hal_mut has been called, so remove it.

Also adds a changelog entry for 98caa62 and a commit that updates Cargo.lock for the v27.0.2 release.

Testing
Untested here, but there are some related tests added on trunk in #8373.

Squash or Rebase? Rebase

Checklist

  • Run cargo fmt.
  • Run taplo format.
  • Run cargo clippy --tests. If applicable, add:
    • --target wasm32-unknown-unknown
  • Run cargo xtask test to run tests.
  • If this contains user-facing changes, add a CHANGELOG.md entry.

@andyleiserson andyleiserson changed the title Push trvsqtuvpstu Remove !encoder.is_open assertion Oct 20, 2025
@ErichDonGubler ErichDonGubler merged commit 787aa72 into gfx-rs:v27 Oct 21, 2025
40 of 41 checks passed
@ErichDonGubler ErichDonGubler self-assigned this Oct 21, 2025
@andyleiserson andyleiserson deleted the push-trvsqtuvpstu branch October 21, 2025 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants