Skip to content

Commit 787aa72

Browse files
andyleisersonErichDonGubler
authored andcommitted
Remove !encoder.is_open assertion
The encoder will be open if `CommandEncoder::as_hal_mut` has been used.
1 parent ffcb07e commit 787aa72

File tree

2 files changed

+9
-5
lines changed

2 files changed

+9
-5
lines changed

CHANGELOG.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,10 +42,18 @@ Bottom level categories:
4242

4343
### Bug Fixes
4444

45+
#### General
46+
47+
- Remove an assertion that causes problems if `CommandEncoder::as_hal_mut` is used. By @andyleiserson in [#8387](https://github.com/gfx-rs/wgpu/pull/8387).
48+
4549
#### DX12
4650

4751
- Align copies b/w textures and buffers via a single intermediate buffer per copy when `D3D12_FEATURE_DATA_D3D12_OPTIONS13.UnrestrictedBufferTextureCopyPitchSupported` is `false`. By @ErichDonGubler in [#7721](https://github.com/gfx-rs/wgpu/pull/7721).
4852

53+
#### Naga
54+
55+
- Fix a bug that resulted in the Metal error `program scope variable must reside in constant address space` in some cases. Backport of [#8311](https://github.com/gfx-rs/wgpu/pull/8311) by @teoxoy.
56+
4957
## v27.0.2 (2025-10-03)
5058

5159
### Bug Fixes

wgpu-core/src/command/mod.rs

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -357,11 +357,7 @@ impl CommandEncoderStatus {
357357
// Replace our state with `Consumed`, and return either the inner
358358
// state or an error, to be transferred to the command buffer.
359359
match mem::replace(self, Self::Consumed) {
360-
Self::Recording(inner) => {
361-
// Nothing should have opened the encoder yet.
362-
assert!(!inner.encoder.is_open);
363-
Self::Finished(inner)
364-
}
360+
Self::Recording(inner) => Self::Finished(inner),
365361
Self::Consumed | Self::Finished(_) => Self::Error(EncoderStateError::Ended.into()),
366362
Self::Locked(_) => Self::Error(EncoderStateError::Locked.into()),
367363
st @ Self::Error(_) => st,

0 commit comments

Comments
 (0)