feat(issues): Consolidate share and publish modals

.github/actions/artifacts/action.yml

@@ -26,6 +26,7 @@ runs:
   steps:
     - name: Download and Verify Codecov CLI
       shell: bash
+      continue-on-error: true
       run: |
         ./.github/actions/artifacts/download_codecov_cli.py
     - name: Upload Coverage and Test Results

fixtures/page_objects/explore_logs.py

@@ -0,0 +1,52 @@
+from selenium.webdriver.common.by import By
+
+from .base import BasePage
+from .global_selection import GlobalSelectionPage
+
+
+class ExploreLogsPage(BasePage):
+    def __init__(self, browser, client):
+        super().__init__(browser)
+        self.client = client
+        self.global_selection = GlobalSelectionPage(browser)
+
+    def visit_explore_logs(self, org):
+        self.browser.get(f"/organizations/{org}/explore/logs/")
+        self.wait_until_loaded()
+
+    def toggle_log_row_with_message(self, message):
+        row = self.get_log_row_with_message(message)
+        try:
+            expanded_count = len(
+                self.browser.find_elements(By.CSS_SELECTOR, '*[data-test-id="fields-tree"]')
+            )
+        except Exception:
+            expanded_count = 0
+        if expanded_count > 0:
+            row.click()
+            # If this is breaking make sure to only have one row expanded at a time.
+            # TODO: Target the correct field-tree with xpath.
+            self.browser.wait_until_not('[data-test-id="fields-tree"]')
+        else:
+            row.click()
+            self.browser.wait_until('[data-test-id="fields-tree"]')
+
+        return row
+
+    def get_log_row_with_message(self, message):
+        row = self.browser.find_element(
+            by=By.XPATH,
+            value=f'//*[@data-test-id="log-table-row" and .//*[contains(text(),"{message}")]]',
+        )
+        return row
+
+    def get_log_row_columns(self, row):
+        # The expanded row actually makes a new sibling row that contains the fields-tree.
+        columns = row.find_elements(
+            By.XPATH, 'following-sibling::*[1]//*[@data-test-id="attribute-tree-column"]'
+        )
+        return columns
+
+    def wait_until_loaded(self):
+        self.browser.wait_until_not('[data-test-id="loading-indicator"]')
+        self.browser.wait_until_test_id("logs-table")

migrations_lockfile.txt

@@ -29,4 +29,4 @@ tempest: 0002_make_message_type_nullable
 
 uptime: 0037_fix_drift_default_to_db_default
 
-workflow_engine: 0052_migrate_errored_metric_alerts
+workflow_engine: 0053_add_legacy_rule_indices

pyproject.toml

@@ -312,7 +312,6 @@ module = [
     "sentry.issues.status_change",
     "sentry.issues.status_change_consumer",
     "sentry.issues.status_change_message",
-    "sentry.issues.streamline",
     "sentry.issues.update_inbox",
     "sentry.lang.java.processing",
     "sentry.llm.*",

requirements-base.txt

@@ -68,7 +68,7 @@ rfc3986-validator>=0.1.1
 sentry-arroyo>=2.21.0
 sentry-kafka-schemas>=1.2.0
 sentry-ophio>=1.1.3
-sentry-protos==0.1.72
+sentry-protos==0.1.74
 sentry-redis-tools>=0.5.0
 sentry-relay>=0.9.8
 sentry-sdk[http2]>=2.25.1

requirements-dev-frozen.txt

@@ -189,7 +189,7 @@ sentry-forked-djangorestframework-stubs==3.15.3.post1
 sentry-forked-email-reply-parser==0.5.12.post1
 sentry-kafka-schemas==1.2.0
 sentry-ophio==1.1.3
-sentry-protos==0.1.72
+sentry-protos==0.1.74
 sentry-redis-tools==0.5.0
 sentry-relay==0.9.8
 sentry-sdk==2.27.0

requirements-frozen.txt

@@ -127,7 +127,7 @@ sentry-arroyo==2.21.0
 sentry-forked-email-reply-parser==0.5.12.post1
 sentry-kafka-schemas==1.2.0
 sentry-ophio==1.1.3
-sentry-protos==0.1.72
+sentry-protos==0.1.74
 sentry-redis-tools==0.5.0
 sentry-relay==0.9.8
 sentry-sdk==2.27.0

src/sentry/api/endpoints/organization_details.py

@@ -47,6 +47,7 @@
     DEBUG_FILES_ROLE_DEFAULT,
     EVENTS_MEMBER_ADMIN_DEFAULT,
     GITHUB_COMMENT_BOT_DEFAULT,
+    GITLAB_COMMENT_BOT_DEFAULT,
     HIDE_AI_FEATURES_DEFAULT,
     ISSUE_ALERTS_THREAD_DEFAULT,
     JOIN_REQUESTS_DEFAULT,
@@ -199,6 +200,12 @@
         bool,
         GITHUB_COMMENT_BOT_DEFAULT,
     ),
+    (
+        "gitlabPRBot",
+        "sentry:gitlab_pr_bot",
+        bool,
+        GITLAB_COMMENT_BOT_DEFAULT,
+    ),
     (
         "issueAlertsThreadFlag",
         "sentry:issue_alerts_thread_flag",
@@ -263,6 +270,7 @@ class OrganizationSerializer(BaseOrganizationSerializer):
     githubOpenPRBot = serializers.BooleanField(required=False)
     githubNudgeInvite = serializers.BooleanField(required=False)
     githubPRBot = serializers.BooleanField(required=False)
+    gitlabPRBot = serializers.BooleanField(required=False)
     issueAlertsThreadFlag = serializers.BooleanField(required=False)
     metricAlertsThreadFlag = serializers.BooleanField(required=False)
     require2FA = serializers.BooleanField(required=False)
@@ -793,6 +801,12 @@ class OrganizationDetailsPutSerializer(serializers.Serializer):
         required=False,
     )
 
+    # gitlab features
+    gitlabPRBot = serializers.BooleanField(
+        help_text="Specify `true` to allow Sentry to comment on recent pull requests suspected of causing issues. Requires a GitLab integration.",
+        required=False,
+    )
+
     # slack features
     issueAlertsThreadFlag = serializers.BooleanField(
         help_text="Specify `true` to allow the Sentry Slack integration to post replies in threads for an Issue Alert notification. Requires a Slack integration.",

src/sentry/api/endpoints/organization_events.py

@@ -29,6 +29,7 @@
     errors,
     metrics_enhanced_performance,
     metrics_performance,
+    ourlogs,
     spans_rpc,
     transactions,
 )
@@ -754,6 +755,8 @@ def fn(offset, limit):
 
         data_fn = data_fn_factory(dataset)
 
+        max_per_page = 1000 if dataset == ourlogs else None
+
         with handle_query_errors():
             # Don't include cursor headers if the client won't be using them
             if request.GET.get("noPagination"):
@@ -779,4 +782,5 @@ def fn(offset, limit):
                         standard_meta=True,
                         dataset=dataset,
                     ),
+                    max_per_page=max_per_page,
                 )

src/sentry/api/endpoints/organization_index.py

@@ -27,7 +27,6 @@
 from sentry.auth.superuser import is_active_superuser
 from sentry.db.models.query import in_iexact
 from sentry.hybridcloud.rpc import IDEMPOTENCY_KEY_LENGTH
-from sentry.issues.streamline import apply_streamline_rollout_group
 from sentry.models.organization import Organization, OrganizationStatus
 from sentry.models.organizationmember import OrganizationMember
 from sentry.models.projectplatform import ProjectPlatform
@@ -307,6 +306,7 @@ def post(self, request: Request) -> Response:
                 organization_id=org.id,
             )
 
-        apply_streamline_rollout_group(organization=org)
+        # New organizations should not see the legacy UI
+        org.update_option("sentry:streamline_ui_only", True)
 
         return Response(serialize(org, request.user), status=201)

src/sentry/api/endpoints/project_trace_item_details.py

@@ -44,6 +44,8 @@ def convert_rpc_attribute_to_json(
                     column_type = "string"
                 elif val_type in ["int", "float", "double"]:
                     column_type = "number"
+                    if val_type == "double":
+                        val_type = "float"
                 else:
                     raise BadRequest(f"unknown column type in protobuf: {val_type}")
 

src/sentry/api/endpoints/trace_explorer_ai_query.py

@@ -0,0 +1,116 @@
+from __future__ import annotations
+
+import logging
+from typing import Any
+
+import orjson
+import requests
+from django.conf import settings
+from rest_framework import status
+from rest_framework.response import Response
+
+from sentry import features
+from sentry.api.api_owners import ApiOwner
+from sentry.api.api_publish_status import ApiPublishStatus
+from sentry.api.base import region_silo_endpoint
+from sentry.api.bases import OrganizationEndpoint
+from sentry.models.organization import Organization
+from sentry.seer.seer_setup import get_seer_org_acknowledgement, get_seer_user_acknowledgement
+from sentry.seer.signed_seer_api import sign_with_seer_secret
+
+logger = logging.getLogger(__name__)
+
+from rest_framework.request import Request
+
+
+def send_translate_request(org_id: int, project_ids: list[int], natural_language_query: str) -> Any:
+    """
+    Sends a request to seer to create the initial cached prompt / setup the AI models
+    """
+    body = orjson.dumps(
+        {
+            "org_id": org_id,
+            "project_ids": project_ids,
+            "natural_language_query": natural_language_query,
+        }
+    )
+
+    response = requests.post(
+        f"{settings.SEER_AUTOFIX_URL}/v1/assisted-query/translate",
+        data=body,
+        headers={
+            "content-type": "application/json;charset=utf-8",
+            **sign_with_seer_secret(body),
+        },
+    )
+    response.raise_for_status()
+    return response.json()
+
+
+@region_silo_endpoint
+class TraceExplorerAIQuery(OrganizationEndpoint):
+    """
+    This endpoint is called when a user visits the trace explorer with the correct flags enabled.
+    """
+
+    publish_status = {
+        "POST": ApiPublishStatus.EXPERIMENTAL,
+    }
+    owner = ApiOwner.ML_AI
+
+    @staticmethod
+    def post(request: Request, organization: Organization) -> Response:
+        """
+        Checks if we are able to run Autofix on the given group.
+        """
+        project_ids = [int(x) for x in request.data.get("project_ids", [])]
+        natural_language_query = request.data.get("natural_language_query")
+
+        if len(project_ids) == 0 or not natural_language_query:
+            return Response(
+                {
+                    "detail": "Missing one or more required parameters: project_ids, natural_language_query"
+                },
+                status=status.HTTP_400_BAD_REQUEST,
+            )
+
+        if not features.has(
+            "organizations:gen-ai-explore-traces", organization=organization, actor=request.user
+        ):
+            return Response(
+                {"detail": "Organization does not have access to this feature"},
+                status=status.HTTP_403_FORBIDDEN,
+            )
+
+        user_acknowledgement = get_seer_user_acknowledgement(
+            user_id=request.user.id, org_id=organization.id
+        )
+        org_acknowledgement = user_acknowledgement or get_seer_org_acknowledgement(
+            org_id=organization.id
+        )
+
+        if not org_acknowledgement:
+            return Response(
+                {"detail": "Organization has not opted in to this feature."},
+                status=status.HTTP_403_FORBIDDEN,
+            )
+
+        if not settings.SEER_AUTOFIX_URL:
+            return Response(
+                {"detail": "Seer is not properly configured."},
+                status=status.HTTP_500_INTERNAL_SERVER_ERROR,
+            )
+        data = send_translate_request(organization.id, project_ids, natural_language_query)
+
+        return Response(
+            {
+                "status": "ok",
+                "query": data["query"],  # the sentry EQS query as a string
+                "stats_period": data["stats_period"],
+                "group_by": list(data.get("group_by", [])),
+                "visualization": list(
+                    data.get("visualization")
+                ),  # [{chart_type: 1, y_axes: ["count_message"]}, ...]
+                "sort": data["sort"],
+            }
+        )