feat(issues): Consolidate share and publish modals #90715
Closed
+5,070
−2,507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
Codecov ReportAttention: Patch coverage is ❌ We are unable to process any of the uploaded JUnit XML files. Please ensure your files are in the right format. Additional details and impacted files@@ Coverage Diff @@
## master #90715 +/- ##
===========================================
+ Coverage 45.57% 87.88% +42.30%
===========================================
Files 10257 10285 +28
Lines 581483 583457 +1974
Branches 22561 22517 -44
===========================================
+ Hits 265038 512781 +247743
+ Misses 316016 70249 -245767
+ Partials 429 427 -2 |
| | Old Style | Chonk Style | | --- | --- | --- | | Before | <img width="205" alt="before - old style" src="https://github.com/user-attachments/assets/b6f577f5-3b16-472e-9a05-08f061786406" /> | <img width="196" alt="before - chonk" src="https://github.com/user-attachments/assets/b0ffd68e-cf59-4b5c-b5d5-554d0b20602b" /> | After | <img width="202" alt="after - old style" src="https://github.com/user-attachments/assets/8ded1922-8d3d-443a-8f69-41c6750db84e" /> | <img width="268" alt="after - chonk" src="https://github.com/user-attachments/assets/dff3cdf5-70dc-451b-9cfb-4d2bfd3ab929" /> Fixes #90650 Followup to #90648
1. Correct error messages when starring/un-starring transactions 2. Update the starred transaction header to be a star and non-resizable Before  After 
This job should not fail and block deploys since it is not on the critical path
…90721) Related to getsentry/snuba#7145 (needs to be done before that can be merged) - we use 'double' in the wire for float64 accuracy
) Currently, we invoke this task with a list of `Project` models that are pickled. This has escaped our existing pickle detection logic as all calls to the task are mocked. This set of changes introduces a new `project_ids` parameter that will let us not need pickle. Once this has deployed, I'll change the callsites to pass `project_ids` and deprecate `projects` usage. Refs #90681
### Summary This asserts the attribute columns, which have regressed a few times, as well as some of the attribute values in each column
Record an analytics event for pagination clicks. The data we store are: - the type of table (samples, traces, aggregates) - the number of results rendered - the direction of the pagination (next vs previous, defined by the pagination component)
…rts (#90725) 1. Add user column to eap overview table <img width="1280" alt="image" src="https://github.com/user-attachments/assets/d8962e1c-5d71-411e-894b-d2bd1ddf5fa3" /> 2. Remove Slow ops Charts to eap overview pages as we have better span based charts like slow assets, and most-time consuming domains
Basic rendered in this context can contain a nowrapped link, just use the attribute value.
Create a detector serializer for the old rule endpoints that returns the same data as before but reads it from the new models. This is modeled off of the [AlertRuleSerializer](https://github.com/getsentry/sentry/blob/master/src/sentry/incidents/endpoints/serializers/alert_rule.py#L96) and I'm calling out the places that are different. I did pull put a lot of the code in `get_attrs` into their own functions because it's so long, but the core of it is the same.
We enabled deletions for all organizations. This is the default behaviour.
A follow-up to #90518. So far, the new logic has worked 100% of the time (over 6k calls) and there's no Sentry errors.
…90737) this is currently the number one flaky test at sentry -- for some reason it only seems to fail from a blank database with a particular number of tests ahead of it (some timing issue? some periodic data cleanup task? unclear to me at least). by modernizing the dates it seems to avoid that issue <!-- Describe your PR here. -->
before:  after: 
Deletions can get killed by deploys and timeouts. Reattempting only once a day can lead to deletions taking many days to complete. By reattempting more frequently should lead to deletions completing more quickly.
…elds on the AlertRuleWorkflow table (#90714) ## Description To be able to quickly reference items in this table by these keys we'll need them to be indexed
We have a specialized use case which requires a dedicated tpm function. This is because we want a table that groups by transaction, displaying transaction per minute for each transaction, and also calculates performance score for each transaction (which is calculated with non-transaction spans, so we can't just apply a global is_transaction filter)
Exposes `HIGHEST_ACCURACY` mode and uses it as the default if no sampling mode is defined. Eventually we want to lean into the fact that NORMAL mode is the default, but the frontend needs to be updated to make use of this. At the moment the frontend passes nothing for a high accuracy request, so we'll enforce the behaviour we expect here.
### Summary For the attribute tree, we want to constrain the tree to 1 column so that users can expand the pane to see more data. This PR also changes the column widths to auto size the column key and column value to at most 50/50, after which both key and value will start wrapping. #### Screenshots |larger without wrapping|still wrapping past 50%| |-|-| |||
Add percentile_if functions
This uses the new trace items search query builder powered by the trace items endpoints for autocompletion. This allows spans and logs to share the same endpoint.
Add failure_rate_if function, needed for frontend overview page
something about the old dates causes the values to sometimes disappear in snuba <!-- Describe your PR here. -->
Scrolls to RC, Solution, and Code Changes sections if you click their respective sidebar card. Otherwise scrolls to the bottom as before.
Switches reading of `uptime_status` (and `uptime_status_update_date`) to the `uptime_subscription` model. We'll need this to migrate to reading from detectors (and implementing the detector handler)
### Summary 'timestamp' doesn't exist in trace-item-details endpoint, we only have sentry.timestamp_nanos when mapping directly. This broke when we moved to passing `attributes` to renderExtra instead of the table row.
This moves the releases drawer hook to inside of AppLayout where organization should be loaded.
Centers the star and ellipsis buttons on a view. The view title left of the buttons is also centered, but it was hard to notice on a widescreen monitor. Also fixes the overflow problem Before:  After: 
This reverts commit 9c322b2. Co-authored-by: Zylphrex <[email protected]>
before: <img width="785" alt="SCR-20250501-macq" src="https://github.com/user-attachments/assets/625192cb-c090-49c2-8d2c-5e912116b659" /> after: <img width="910" alt="SCR-20250501-lzyc" src="https://github.com/user-attachments/assets/5dcfd519-c550-483f-839b-8f8e04cd124f" /> don't know when the misalignment happened (and i know the suspect labels will go away soon), but let's fix it for now
This PR fixes `<ErrorHandler>` to add a `cause` error to when we catch an error with a React Error Boundary. This will help us debug [this error](https://sentry.sentry.io/issues/6333431167/events/ecf1545d92834ceba543c2b62af63171/?project=11276) (and future ones that hit `<ErrorHandler>`). See [this issue](https://sentry-emerging-tech.sentry.io/issues/6580362564/?project=6326737&query=is%3Aunresolved%20issue.priority%3A%5Bhigh%2C%20medium%5D&referrer=issue-stream&stream_index=0) for what it will look like.
This should fix [this issue](https://sentry.sentry.io/issues/4191022159/?project=11276&query=is%3Aunresolved%20issue.priority%3A%5Bhigh%2C%20medium%5D%20useOrganization&referrer=issue-stream&stream_index=1) as the `/settings/` index page can link to invalid URLs when user is not apart of any orgs. (I actually think this *only* is visitable when the user is not part of any orgs, otherwise it redirects you to org settings). Replace/remove all org links on this index page. Also fixes text clipping due to overflow + ellipsis (look at the "g" in Organization) Old:  New:  Fixes JAVASCRIPT-2M6X
Currently we have custom logic in the DropdownMenu component which handles link items. The react-aria library should already be handling this, but we configured things a bit differently than react-aria expected which prevented it. This PR removes the custom behavior and provides a `href` for react-aria to use. I'm hoping that this change fixes some bugs I've seen on mobile devices. On iOS especially, taps on dropdown link items have no effect. Summary of changes: - Add `href` to the dropdown item state if `to` or `externalHref` is passed - Remove custom logic handling keyboard selection of a link item - Moves the dropdown item props from the container `li` element to the "inner item" (which is an anchor tag in the case of links) - Fixes tests that looked for `link` roles instead of `menuitemradio`
…y/sentry into roggenkemper/consolidatepublish
github-actions
bot
added
the
Scope: Backend
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
…y/sentry into roggenkemper/consolidatepublish
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr updates the share and publish modals from the issue details page.