feat(eap): Default unspecified sampling mode to high accuracy #90704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #90704 +/- ##
===========================================
+ Coverage 52.55% 87.84% +35.28%
===========================================
Files 10275 10283 +8
Lines 583109 583622 +513
Branches 22569 22568 -1
===========================================
+ Hits 306478 512694 +206216
+ Misses 276202 70495 -205707
- Partials 429 433 +4 |
…ing-mode-to-high-accuracy
edwardgou-sentry
approved these changes
May 1, 2025
narsaynorath
deleted the
nar/feat/explore-default-unspecified-sampling-mode-to-high-accuracy
branch
andrewshie-sentry
pushed a commit
that referenced
this pull request
May 12, 2025
Exposes `HIGHEST_ACCURACY` mode and uses it as the default if no sampling mode is defined. Eventually we want to lean into the fact that NORMAL mode is the default, but the frontend needs to be updated to make use of this. At the moment the frontend passes nothing for a high accuracy request, so we'll enforce the behaviour we expect here.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes
HIGHEST_ACCURACYmode and uses it as the default if no sampling mode is defined.Eventually we want to lean into the fact that NORMAL mode is the default, but the frontend needs to be updated to make use of this. At the moment the frontend passes nothing for a high accuracy request, so we'll enforce the behaviour we expect here.