Skip to content

feat(eap): Default unspecified sampling mode to high accuracy #90704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

narsaynorath
Copy link
Member

@narsaynorath narsaynorath commented Apr 30, 2025

Exposes HIGHEST_ACCURACY mode and uses it as the default if no sampling mode is defined.

Eventually we want to lean into the fact that NORMAL mode is the default, but the frontend needs to be updated to make use of this. At the moment the frontend passes nothing for a high accuracy request, so we'll enforce the behaviour we expect here.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 30, 2025
Copy link

codecov bot commented Apr 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #90704       +/-   ##
===========================================
+ Coverage   52.55%   87.84%   +35.28%     
===========================================
  Files       10275    10283        +8     
  Lines      583109   583622      +513     
  Branches    22569    22568        -1     
===========================================
+ Hits       306478   512694   +206216     
+ Misses     276202    70495   -205707     
- Partials      429      433        +4     

@narsaynorath narsaynorath marked this pull request as ready for review May 1, 2025 18:03
@narsaynorath narsaynorath requested review from a team as code owners May 1, 2025 18:03
@narsaynorath narsaynorath merged commit 8ac64fb into master May 1, 2025
63 checks passed
@narsaynorath narsaynorath deleted the nar/feat/explore-default-unspecified-sampling-mode-to-high-accuracy branch May 1, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants