feat(eap): Default unspecified sampling mode to high accuracy (#90704)

Exposes `HIGHEST_ACCURACY` mode and uses it as the default if no
sampling mode is defined.

Eventually we want to lean into the fact that NORMAL mode is the
default, but the frontend needs to be updated to make use of this. At
the moment the frontend passes nothing for a high accuracy request, so
we'll enforce the behaviour we expect here.

Author: narsaynorath

requirements-base.txt

@@ -68,7 +68,7 @@ rfc3986-validator>=0.1.1
 sentry-arroyo>=2.21.0
 sentry-kafka-schemas>=1.2.0
 sentry-ophio>=1.1.3
-sentry-protos==0.1.72
+sentry-protos==0.1.74
 sentry-redis-tools>=0.5.0
 sentry-relay>=0.9.8
 sentry-sdk[http2]>=2.25.1

requirements-dev-frozen.txt

@@ -189,7 +189,7 @@ sentry-forked-djangorestframework-stubs==3.15.3.post1
 sentry-forked-email-reply-parser==0.5.12.post1
 sentry-kafka-schemas==1.2.0
 sentry-ophio==1.1.3
-sentry-protos==0.1.72
+sentry-protos==0.1.74
 sentry-redis-tools==0.5.0
 sentry-relay==0.9.8
 sentry-sdk==2.27.0

requirements-frozen.txt

@@ -127,7 +127,7 @@ sentry-arroyo==2.21.0
 sentry-forked-email-reply-parser==0.5.12.post1
 sentry-kafka-schemas==1.2.0
 sentry-ophio==1.1.3
-sentry-protos==0.1.72
+sentry-protos==0.1.74
 sentry-redis-tools==0.5.0
 sentry-relay==0.9.8
 sentry-sdk==2.27.0

src/sentry/search/eap/constants.py

@@ -162,4 +162,5 @@
     "BEST_EFFORT": DownsampledStorageConfig.MODE_BEST_EFFORT,
     "PREFLIGHT": DownsampledStorageConfig.MODE_PREFLIGHT,
     "NORMAL": DownsampledStorageConfig.MODE_NORMAL,
+    "HIGHEST_ACCURACY": DownsampledStorageConfig.MODE_HIGHEST_ACCURACY,
 }

src/sentry/search/eap/utils.py

@@ -102,7 +102,7 @@ def transform_column_to_expression(column: Column) -> Expression:
 
 def validate_sampling(sampling_mode: SAMPLING_MODES | None) -> DownsampledStorageConfig:
     if sampling_mode is None:
-        return DownsampledStorageConfig(mode=DownsampledStorageConfig.MODE_UNSPECIFIED)
+        return DownsampledStorageConfig(mode=DownsampledStorageConfig.MODE_HIGHEST_ACCURACY)
     if sampling_mode not in SAMPLING_MODE_MAP:
         raise InvalidSearchQuery(f"sampling mode: {sampling_mode} is not supported")
     else:

src/sentry/search/events/types.py

@@ -81,7 +81,7 @@ class EventsResponse(TypedDict):
     meta: EventsMeta
 
 
-SAMPLING_MODES = Literal["BEST_EFFORT", "PREFLIGHT", "NORMAL"]
+SAMPLING_MODES = Literal["BEST_EFFORT", "PREFLIGHT", "NORMAL", "HIGHEST_ACCURACY"]
 
 
 @dataclass

tests/snuba/api/endpoints/test_organization_events_stats_span_indexed.py

@@ -2017,3 +2017,32 @@ def test_downsampling_can_go_to_higher_accuracy_tier(self):
         )
 
         assert response.data["meta"]["dataScanned"] == "partial"
+
+    def test_request_without_sampling_mode_defaults_to_highest_accuracy(self):
+        response = self._do_request(
+            data={
+                "start": self.day_ago,
+                "end": self.day_ago + timedelta(minutes=3),
+                "interval": "1m",
+                "yAxis": "count()",
+                "project": self.project.id,
+                "dataset": self.dataset,
+            },
+        )
+
+        assert response.data["meta"]["dataScanned"] == "full"
+
+    def test_request_to_highest_accuracy_mode(self):
+        response = self._do_request(
+            data={
+                "start": self.day_ago,
+                "end": self.day_ago + timedelta(minutes=3),
+                "interval": "1m",
+                "yAxis": "count()",
+                "project": self.project.id,
+                "dataset": self.dataset,
+                "sampling": "HIGHEST_ACCURACY",
+            },
+        )
+
+        assert response.data["meta"]["dataScanned"] == "full"