Skip to content

feat(scm): srcsrv file revision four source code mapping - #128876

Open
mujacica wants to merge 2 commits into
masterfrom
feat/perforce-srcsrv-file-revision
Open

feat(scm): srcsrv file revision four source code mapping#128876
mujacica wants to merge 2 commits into
masterfrom
feat/perforce-srcsrv-file-revision

Conversation

@mujacica

@mujacica mujacica commented Oct 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Use the file revision from srcsrv mappings on Symbolicator
  • For some SCM providers, Symbolicator can extract precise file revision ID (commit hash, changelist, etc) - based on the matched debug files image. In cases where we have precise information from symbolicator about it AND users opted in for this feature, prefer the Symbolicator extracted file revision ID over the current commit ID we are getting from releases/suspect commits

@mujacica
mujacica added this pull request to stack #128877 October 27, 2026 08:31
@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 27, 2026
@mujacica mujacica changed the title Feat/perforce srcsrv file revision feat(scm): srcsrv file revision four source code mapping Oct 27, 2026
@mujacica
mujacica marked this pull request as ready for review October 27, 2026 08:46
@mujacica
mujacica requested review from a team as code owners October 27, 2026 08:46
@mujacica
mujacica requested a review from loewenheim October 27, 2026 08:46
Base automatically changed from feat/native/pdb-srcsrv-paths to master October 28, 2026 07:30
@mujacica
mujacica requested review from a team as code owners October 28, 2026 07:30
@mujacica
feat(native): Expose a frame's file_revision in the event API
50af1b6 
Symbolicated frames keep the source server file_revision, but the frame API only returns keys it lists explicitly. Return it as fileRevision so the UI can pass it along when resolving source links.
@mujacica
feat(integrations): Resolve stack trace links at a frame's file revision
ce2e3ce 
Native frames symbolicated with source server info carry a per-file revision (a Perforce changelist for srcsrv-indexed PDBs). Accept it as fileRevision on the stacktrace-link and stacktrace-source-context endpoints and prefer it over the release's commitId, so links and fetched source context point at the revision the binary was built from.
@mujacica
mujacica force-pushed the feat/perforce-srcsrv-file-revision branch from 9d3538d to ce2e3ce Compare October 28, 2026 07:30

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@loewenheim loewenheim loewenheim approved these changes
@vgrozdanic vgrozdanic vgrozdanic approved these changes
@elramen elramen elramen approved these changes

Assignees

No one assigned

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mujacica @loewenheim @vgrozdanic @elramen