feat(integrations): Resolve stack trace links at a frame's file revision

Native frames symbolicated with source server info carry a per-file revision (a Perforce changelist for srcsrv-indexed PDBs). Accept it as fileRevision on the stacktrace-link and stacktrace-source-context endpoints and prefer it over the release's commitId, so links and fetched source context point at the revision the binary was built from.

Author: mujacica

src/sentry/issues/endpoints/project_stacktrace_link.py

@@ -72,7 +72,8 @@ def generate_context(parameters: QueryDict) -> StacktraceLinkContext:
         "file": parameters.get("file", ""),
         # XXX: Temp change to support try_path_munging until refactored
         "filename": parameters.get("file", ""),
-        "commit_id": parameters.get("commitId"),
+        # A frame's source server revision pins its file more precisely than the release commit.
+        "commit_id": parameters.get("fileRevision") or parameters.get("commitId"),
         "platform": parameters.get("platform"),
         "sdk_name": parameters.get("sdkName"),
         "abs_path": parameters.get("absPath"),
@@ -175,6 +176,8 @@ class ProjectStacktraceLinkEndpoint(ProjectEndpoint):
     `file`: The file path from the stack trace
     `commitId` (optional): The commit_id for the last commit of the
                            release associated to the stack trace's event
+    `fileRevision` (optional): The source server revision of the frame's file.
+                               Takes precedence over `commitId`.
     `sdkName` (optional): The sdk.name associated with the event
     `absPath` (optional): The abs_path field value of the relevant stack frame
     `module`   (optional): The module field value of the relevant stack frame
@@ -209,6 +212,14 @@ class ProjectStacktraceLinkEndpoint(ProjectEndpoint):
             OpenApiParameter(
                 "commitId", type=str, description="The commit ID associated with the event."
             ),
+            OpenApiParameter(
+                "fileRevision",
+                type=str,
+                description=(
+                    "The source server revision of the frame's file, if known. "
+                    "Takes precedence over `commitId`."
+                ),
+            ),
             OpenApiParameter(
                 "sdkName", type=str, description="The SDK name associated with the event."
             ),

src/sentry/issues/endpoints/project_stacktrace_source_context.py

@@ -29,6 +29,8 @@ class ProjectStacktraceSourceContextEndpoint(ProjectEndpoint):
     `file`: The file path from the stack trace (required)
     `lineNo`: The line number to fetch context around (required)
     `commitId` (optional): The commit_id for the last commit of the release
+    `fileRevision` (optional): The source server revision of the frame's file.
+                               Takes precedence over `commitId`.
     `platform` (optional): The platform of the event
     `sdkName` (optional): The sdk.name associated with the event
     `absPath` (optional): The abs_path field value of the relevant stack frame

tests/sentry/issues/endpoints/test_project_stacktrace_link.py

@@ -209,6 +209,18 @@ def test_config_and_source_url(self) -> None:
             assert response.data["sourceUrl"] == "https://sourceurl.com/"
             assert response.data["integrations"] == [serialized_integration(self.integration)]
 
+    @patch.object(ExampleIntegration, "get_stacktrace_link", return_value="https://sourceurl.com/")
+    def test_file_revision_takes_precedence_over_commit_id(
+        self, mock_get_stacktrace_link: MagicMock
+    ) -> None:
+        self._create_code_mapping(stack_root="usr/src/getsentry/", source_root="")
+        self.get_success_response(
+            self.organization.slug,
+            self.project.slug,
+            qs_params={"file": self.filepath, "commitId": "abc123", "fileRevision": "12345"},
+        )
+        assert mock_get_stacktrace_link.call_args.args[3] == "12345"
+
     @patch.object(ExampleIntegration, "get_stacktrace_link")
     def test_file_no_stack_root_match(self, mock_integration: MagicMock) -> None:
         # Pretend that the file was not found in the repository